Patch Detail
Show a patch.
GET /api/patches/23895/?format=api
{ "id": 23895, "url": "https://patchwork.libcamera.org/api/patches/23895/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23895/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250722102538.52706-1-uajain@igalia.com>", "date": "2025-07-22T10:25:38", "name": "pipeline: simple: Improve debug log in validate()", "commit_ref": "01a9b83f3833f1ccfec22c991de747403c46ae68", "pull_url": null, "state": "accepted", "archived": false, "hash": "9ca0ddb516074c9c8b7b350b615e4683eec3c12b", "submitter": { "id": 232, "url": "https://patchwork.libcamera.org/api/people/232/?format=api", "name": "Umang Jain", "email": "uajain@igalia.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23895/mbox/", "series": [ { "id": 5310, "url": "https://patchwork.libcamera.org/api/series/5310/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5310", "date": "2025-07-22T10:25:38", "name": "pipeline: simple: Improve debug log in validate()", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5310/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23895/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23895/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C2D6C3237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 22 Jul 2025 10:25:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6E9816902A;\n\tTue, 22 Jul 2025 12:25:38 +0200 (CEST)", "from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1E4C868F93\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Jul 2025 12:25:37 +0200 (CEST)", "from [49.36.71.87] (helo=uajain) by fanzine2.igalia.com with\n\tesmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1ueABj-0025xD-Mq; Tue, 22 Jul 2025 12:25:36 +0200" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"nWEX4+Kk\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:\n\tCc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tIn-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=FrleBOl9j8Aye7M8Ulxs3jAD8wzLUjEDGZiDImAgqfM=;\n\tb=nWEX4+KkzdwH6jKP5OJM5PtWMV\n\tjvAF4m4Y6upIisjxorJOC06Pnrj9cAK/XLDow+i9B+0aqKDJNDLWv4XtQ87YyL2ngeCPX6Zgrmn11\n\tUn2uXu26LPOaQthp6kLgMhRfVS+C+Q7dikUzkVVOdSGN5ypI9Y4cOHjuH+auTxqNXQTo1+Ft3V4TI\n\tjmPwPEb3UgyeSPy3PgSe4HT58LVhqjWE5yRVPxx/RxES6ARLLOlehlpktmNU79r+TnEm0IcftKqnN\n\t8qN0D6EJcsh27sGLD4hln/HHFYZ3RFMTjov+jR23hi/q5V4FsMNWMnQchXh4Y3L/En+r64gUo/F/1\n\tNjW86b3g==;", "From": "Umang Jain <uajain@igalia.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Umang Jain <uajain@igalia.com>", "Subject": "[PATCH] pipeline: simple: Improve debug log in validate()", "Date": "Tue, 22 Jul 2025 15:55:38 +0530", "Message-ID": "<20250722102538.52706-1-uajain@igalia.com>", "X-Mailer": "git-send-email 2.50.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Improve the debug log while adjusting the StreamConfiguration's\npixel format. The log should clearly indicate the requested pixel\nformat and the adjusted pixel format.\n\nSigned-off-by: Umang Jain <uajain@igalia.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex efb07051..492da967 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1204,7 +1204,9 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n \n \t\tPixelFormat pixelFormat = *it;\n \t\tif (cfg.pixelFormat != pixelFormat) {\n-\t\t\tLOG(SimplePipeline, Debug) << \"Adjusting pixel format\";\n+\t\t\tLOG(SimplePipeline, Debug)\n+\t\t\t\t<< \"Adjusting pixel format from \"\n+\t\t\t\t<< cfg.pixelFormat << \" to \" << pixelFormat;\n \t\t\tcfg.pixelFormat = pixelFormat;\n \t\t\tstatus = Adjusted;\n \t\t}\n", "prefixes": [] }