Patch Detail
Show a patch.
GET /api/patches/23893/?format=api
{ "id": 23893, "url": "https://patchwork.libcamera.org/api/patches/23893/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23893/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250721124826.8584-1-uajain@igalia.com>", "date": "2025-07-21T12:48:26", "name": "[v2] apps: cam: Print enum string for camera properties", "commit_ref": "c7c40ed1a35e67e9e87c81ae6648594520b0fa1d", "pull_url": null, "state": "accepted", "archived": false, "hash": "4b2c1e76c8e3a755f8376e64c53cffe67d13e1fe", "submitter": { "id": 232, "url": "https://patchwork.libcamera.org/api/people/232/?format=api", "name": "Umang Jain", "email": "uajain@igalia.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23893/mbox/", "series": [ { "id": 5308, "url": "https://patchwork.libcamera.org/api/series/5308/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5308", "date": "2025-07-21T12:48:26", "name": "[v2] apps: cam: Print enum string for camera properties", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5308/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23893/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23893/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 126E7BDCC1\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 21 Jul 2025 12:48:27 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 349EE68FE4;\n\tMon, 21 Jul 2025 14:48:26 +0200 (CEST)", "from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7F0E168FB1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Jul 2025 14:48:22 +0200 (CEST)", "from [49.36.71.87] (helo=uajain) by fanzine2.igalia.com with\n\tesmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1udpwL-001hwV-9x; Mon, 21 Jul 2025 14:48:21 +0200" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"kJKO2r8B\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:\n\tDate:Subject:Cc:To:From:Sender:Reply-To:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tIn-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=6fJrKZp1xoOi5Ktn6/qxf9hfBzOKjfwMQhM9zi8gkkQ=;\n\tb=kJKO2r8BcEAcuKOIBwj1fdVCOP\n\tKhewQC/NtMhc86HB0kFmvqY3ys2nn0PZ+r1OBFQKyGw3xlVNCrtyUFcVJRYhn/Dr+miGvQAqQS6GG\n\tqaZkT5B6c+0uHckVquRXyjuYXXEmTBQs9ck3qFFfFy6eRaOtpp/5La3tbWwqMLkueZBLedGjBMBL0\n\tkN2fdXGdSHr08KdkpdDQfwrPIaj0zDDmx/xxeooIxU4NV0uVnL2FFdMYwZygfwXn7AB7FeaBe1LQe\n\tgs2agBKBRPr0bGpVintNyhnrXiTatVmOiSOgUQvup1MNXqvc1Kj8RGCljWpMSibHh9VtFxmosy3EI\n\tP84LNfNg==;", "From": "Umang Jain <uajain@igalia.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Umang Jain <uajain@igalia.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>", "Subject": "[PATCH v2] apps: cam: Print enum string for camera properties", "Date": "Mon, 21 Jul 2025 18:18:26 +0530", "Message-ID": "<20250721124826.8584-1-uajain@igalia.com>", "X-Mailer": "git-send-email 2.50.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Some camera properties might be set as a enumeration for e.g.\nproperties::Location. Instead of printing the int32_t values\nfor the enumeration, print the enum string as well. This will\nenhance the readability for the user.\n\nSigned-off-by: Umang Jain <uajain@igalia.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nTested-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\nChanges in v2:\n- Comestic changes \n- Use id->enumerators() to detect controlID has enum values\n---\n src/apps/cam/camera_session.cpp | 12 +++++++++++-\n 1 file changed, 11 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\nindex f63fcb22..1596a25a 100644\n--- a/src/apps/cam/camera_session.cpp\n+++ b/src/apps/cam/camera_session.cpp\n@@ -236,7 +236,17 @@ void CameraSession::listProperties() const\n \t\tconst ControlId *id = properties::properties.at(key);\n \n \t\tstd::cout << \"Property: \" << id->name() << \" = \"\n-\t\t\t << value.toString() << std::endl;\n+\t\t\t << value.toString();\n+\n+\t\tif (!id->enumerators().empty()) {\n+\t\t\tint32_t val = value.get<int32_t>();\n+\t\t\tconst auto &iter = id->enumerators().find(val);\n+\n+\t\t\tif (iter != id->enumerators().end())\n+\t\t\t\tstd::cout << \" (\" << iter->second << \")\";\n+\t\t}\n+\n+\t\tstd::cout << std::endl;\n \t}\n }\n \n", "prefixes": [ "v2" ] }