Patch Detail
Show a patch.
GET /api/patches/23845/?format=api
{ "id": 23845, "url": "https://patchwork.libcamera.org/api/patches/23845/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23845/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250717220539.2434556-2-dan.scally@ideasonboard.com>", "date": "2025-07-17T22:05:39", "name": "[2/2] libcamera: mali-c55: Correct expected entity function", "commit_ref": "21e54eff95b5935cb183c0250a71e49b90d6a4c2", "pull_url": null, "state": "accepted", "archived": false, "hash": "b5ed871b8a8c883f6a8498bbf7cfdb79c3a5c540", "submitter": { "id": 156, "url": "https://patchwork.libcamera.org/api/people/156/?format=api", "name": "Dan Scally", "email": "dan.scally@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23845/mbox/", "series": [ { "id": 5295, "url": "https://patchwork.libcamera.org/api/series/5295/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5295", "date": "2025-07-17T22:05:38", "name": "[1/2] libcamera: mali-c55: Set bytesused appropriately", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5295/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23845/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23845/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0C523BE175\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 17 Jul 2025 22:06:02 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 896F268F89;\n\tFri, 18 Jul 2025 00:05:59 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4D55E68F7D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Jul 2025 00:05:55 +0200 (CEST)", "from mail.ideasonboard.com\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id CF3E178C;\n\tFri, 18 Jul 2025 00:05:20 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"DK2j48iY\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1752789920;\n\tbh=jfCe4aKA1+dVGIzuFV9tNhx4YwoktjAfRis9D0tfbHM=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=DK2j48iYya0fzhbm8MYgFf9PsZhYjwkvKf0n92ioctBVABOp2cjxWNzqDnGU7qXL2\n\t2G8JfIbkN05MjODZE5wQSpR/m11nYtNSnPNLOlIAKWthhP4poEZ5/Nfu7+praCJVAg\n\tdRrNPCtHO86UxxWXK5GveOZ8IU3gPh5P2ePustI8=", "From": "Daniel Scally <dan.scally@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Daniel Scally <dan.scally@ideasonboard.com>", "Subject": "[PATCH 2/2] libcamera: mali-c55: Correct expected entity function", "Date": "Thu, 17 Jul 2025 23:05:39 +0100", "Message-Id": "<20250717220539.2434556-2-dan.scally@ideasonboard.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20250717220539.2434556-1-dan.scally@ideasonboard.com>", "References": "<20250717220539.2434556-1-dan.scally@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The mali-c55 pipeline handler currently looks for a media entity with\nthe function MEDIA_ENT_F_IO_V4L to recognise a memory input subdevice.\nThis is apparently intended for video device entities, and we should\nbe looking for MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER. Correct the\nentity function that the pipeline handler looks for.\n\nSigned-off-by: Daniel Scally <dan.scally@ideasonboard.com>\n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex 17ad2055..25540ba1 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -1709,7 +1709,7 @@ bool PipelineHandlerMaliC55::match(DeviceEnumerator *enumerator)\n \t *\n \t * MEDIA_ENT_F_CAM_SENSOR - The test pattern generator\n \t * MEDIA_ENT_F_VID_IF_BRIDGE - A CSI-2 receiver\n-\t * MEDIA_ENT_F_IO_V4L - An input device\n+\t * MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER - An input device\n \t *\n \t * The last one will be unsupported for now. The TPG is relatively easy,\n \t * we just register a Camera for it. If we have a CSI-2 receiver we need\n@@ -1735,7 +1735,7 @@ bool PipelineHandlerMaliC55::match(DeviceEnumerator *enumerator)\n \t\t\t\treturn registered;\n \n \t\t\tbreak;\n-\t\tcase MEDIA_ENT_F_IO_V4L:\n+\t\tcase MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER:\n \t\t\tLOG(MaliC55, Warning) << \"Memory input not yet supported\";\n \t\t\tbreak;\n \t\tdefault:\n", "prefixes": [ "2/2" ] }