Patch Detail
Show a patch.
GET /api/patches/23826/?format=api
{ "id": 23826, "url": "https://patchwork.libcamera.org/api/patches/23826/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23826/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250716142027.236277-6-uajain@igalia.com>", "date": "2025-07-16T14:20:25", "name": "[RFC,5/6] libcamera: simple: Require metadata only when software ISP is used", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "adf57768443f08befa8495a3913c97b599410b7f", "submitter": { "id": 232, "url": "https://patchwork.libcamera.org/api/people/232/?format=api", "name": "Umang Jain", "email": "uajain@igalia.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23826/mbox/", "series": [ { "id": 5289, "url": "https://patchwork.libcamera.org/api/series/5289/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5289", "date": "2025-07-16T14:20:20", "name": "libcamera: simple: Enable Raw capture", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5289/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23826/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23826/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5AC5AC3237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 16 Jul 2025 14:20:37 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EC08E68F84;\n\tWed, 16 Jul 2025 16:20:32 +0200 (CEST)", "from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C4D0C68F71\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 16 Jul 2025 16:20:28 +0200 (CEST)", "from [49.36.69.57] (helo=uajain) by fanzine2.igalia.com with\n\tesmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1uc2zj-00HLf5-SS; Wed, 16 Jul 2025 16:20:28 +0200" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"BJjYKQCc\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=e5oieVphXTG/5OXatTPAesu9MMTgwZveR+uHZ30m/vM=;\n\tb=BJjYKQCcbmKjDhaMPorI2wPyeg\n\tWB1F+QwcqlsEftbWfgl5sTmhtNHx/HjCNeKQoAjE22Fx1L8nf2v77tPriB2iPFVPq4s2eO3HFnBX+\n\tccSolEcQUaxgSyK70gxco5QrueYieP9k8dhu2DIb7aLpyrGOKJO78FdQT9jf/ic5aHUVjMEwy4p6i\n\t/RjkBRNYtRqqRH1nbto3DU21rpUw+IVb1A1QaKz7kQCvyZ/bKYBs+RcbN5u1EL++ZWF9FluGIESwZ\n\t+TStN5MR66hz1V0wU2eXqCd927V6JkGK5aiOFdZMHCFCsE8sez28tCrnGjvi/ME/fQgtJcit3hqLr\n\tqUqimYnQ==;", "From": "Umang Jain <uajain@igalia.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tRobert Mader <robert.mader@collabora.com>", "Subject": "[RFC PATCH 5/6] libcamera: simple: Require metadata only when\n\tsoftware ISP is used", "Date": "Wed, 16 Jul 2025 19:50:25 +0530", "Message-ID": "<20250716142027.236277-6-uajain@igalia.com>", "X-Mailer": "git-send-email 2.50.0", "In-Reply-To": "<20250716142027.236277-1-uajain@igalia.com>", "References": "<20250716142027.236277-1-uajain@igalia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Milan Zamazal <mzamazal@redhat.com>\n\nIf software ISP is enabled then metadata is required in the simple\npipeline. But this doesn't apply if the software ISP is not actually\nused, for example when only a raw stream is produced. Then the pipeline\nwaits for metadata that never comes.\n\nThis patch fixes the problem by requiring metadata only when software\nISP is used.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 1dccfbb1..75469e3a 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1600,6 +1600,7 @@ int SimplePipelineHandler::queueRequestDevice(Camera *camera, Request *request)\n \tint ret;\n \n \tstd::map<const Stream *, FrameBuffer *> buffers;\n+\tbool metadataRequired = false;\n \n \tfor (auto &[stream, buffer] : request->buffers()) {\n \t\t/*\n@@ -1609,6 +1610,7 @@ int SimplePipelineHandler::queueRequestDevice(Camera *camera, Request *request)\n \t\t */\n \t\tif (data->useConversion_) {\n \t\t\tbuffers.emplace(stream, buffer);\n+\t\t\tmetadataRequired = !!data->swIsp_;\n \t\t} else {\n \t\t\tret = data->video_->queueBuffer(buffer);\n \t\t\tif (ret < 0)\n@@ -1616,7 +1618,7 @@ int SimplePipelineHandler::queueRequestDevice(Camera *camera, Request *request)\n \t\t}\n \t}\n \n-\tdata->frameInfo_.create(request, !!data->swIsp_);\n+\tdata->frameInfo_.create(request, metadataRequired);\n \tif (data->useConversion_) {\n \t\tdata->conversionQueue_.push({ request, std::move(buffers) });\n \t\tif (data->swIsp_)\n", "prefixes": [ "RFC", "5/6" ] }