Patch Detail
Show a patch.
GET /api/patches/23825/?format=api
{ "id": 23825, "url": "https://patchwork.libcamera.org/api/patches/23825/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23825/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250716142027.236277-5-uajain@igalia.com>", "date": "2025-07-16T14:20:24", "name": "[RFC,4/6] libcamera: simple: Validate raw streams if requested", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "6862b01d249e47da14d67ae964285c2d8382d470", "submitter": { "id": 232, "url": "https://patchwork.libcamera.org/api/people/232/?format=api", "name": "Umang Jain", "email": "uajain@igalia.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23825/mbox/", "series": [ { "id": 5289, "url": "https://patchwork.libcamera.org/api/series/5289/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5289", "date": "2025-07-16T14:20:20", "name": "libcamera: simple: Enable Raw capture", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5289/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23825/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23825/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 55190C32C8\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 16 Jul 2025 14:20:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D00C368F81;\n\tWed, 16 Jul 2025 16:20:31 +0200 (CEST)", "from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A6F8268F6E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 16 Jul 2025 16:20:27 +0200 (CEST)", "from [49.36.69.57] (helo=uajain) by fanzine2.igalia.com with\n\tesmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1uc2zi-00HLf5-Nn; Wed, 16 Jul 2025 16:20:27 +0200" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"O9cJCLtD\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:\n\tMessage-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type:Content-ID:\n\tContent-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc\n\t:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=9OZ41oDWYbu+b0piOe7uvPxGpJtW+hbDuA3SKY1xXSI=;\n\tb=O9cJCLtDDlk4NBJ2kfXVqxQSJ/\n\tk31RTHgRVeMlEeoAFoE5VEQgNdFESlOlVC+6Bm1tWs7e0dd/PAHGzhMJS3mg1mn1ZwAyIjbXlwnot\n\tX/rk8jEQZsXCy8OjysTjXaJSqpduhuBhUTvWEla4KshhRtCHOyHZWxzVqn4DnGWjzxRIGLnzWFrtG\n\teVW5pTWnaRUjapDQRZ7oIJuYZu/yDDEBIS0D7sVN3Gx2A0rmQDrh2HcyLoefX3/VTHryKNbPMc67z\n\tCJcp40UA6lC4DNQBYaLOZQpF3iGyGk6DnOdkD/GJIh7x/F+GFveag31qIhCU6iycO2WAzXLjCewZC\n\tfEvG7hFA==;", "From": "Umang Jain <uajain@igalia.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tRobert Mader <robert.mader@collabora.com>, Umang Jain <uajain@igalia.com>", "Subject": "[RFC PATCH 4/6] libcamera: simple: Validate raw streams if requested", "Date": "Wed, 16 Jul 2025 19:50:24 +0530", "Message-ID": "<20250716142027.236277-5-uajain@igalia.com>", "X-Mailer": "git-send-email 2.50.0", "In-Reply-To": "<20250716142027.236277-1-uajain@igalia.com>", "References": "<20250716142027.236277-1-uajain@igalia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Validate the raw streams if requested in the camera configuration.\nInitially check for a raw stream request and find a [format, size] that\ncan satisfy that. Adjust the raw stream accordingly to the pipeline\nconfiguration (pipeConfig_), if necessary.\n\nSigned-off-by: Umang Jain <uajain@igalia.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 44 +++++++++++++++++-------\n 1 file changed, 32 insertions(+), 12 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex d6c92391..1dccfbb1 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1147,19 +1147,24 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n \n \t/*\n \t * Find the best configuration for the pipeline using a heuristic.\n-\t * First select the pixel format based on the streams (which are\n-\t * considered ordered from highest to lowest priority). Default to the\n-\t * first pipeline configuration if no streams request a supported pixel\n-\t * format.\n+\t * First select the pixel format based on the raw streams followed by\n+\t * non-raw streams (which are considered ordered from highest to lowest\n+\t * priority). Default to the first pipeline configuration if no streams\n+\t * request a supported pixel format.\n \t */\n \tconst std::vector<const SimpleCameraData::Configuration *> *configs =\n \t\t&data_->formats_.begin()->second;\n \n-\tfor (const StreamConfiguration &cfg : config_) {\n-\t\tauto it = data_->formats_.find(cfg.pixelFormat);\n-\t\tif (it != data_->formats_.end()) {\n-\t\t\tconfigs = &it->second;\n-\t\t\tbreak;\n+\tauto rawIter = data_->formats_.find(requestedRawFormat);\n+\tif (rawIter != data_->formats_.end()) {\n+\t\tconfigs = &rawIter->second;\n+\t} else {\n+\t\tfor (const StreamConfiguration &cfg : config_) {\n+\t\t\tauto it = data_->formats_.find(cfg.pixelFormat);\n+\t\t\tif (it != data_->formats_.end()) {\n+\t\t\t\tconfigs = &it->second;\n+\t\t\t\tbreak;\n+\t\t\t}\n \t\t}\n \t}\n \n@@ -1218,8 +1223,23 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n \n \tfor (unsigned int i = 0; i < config_.size(); ++i) {\n \t\tStreamConfiguration &cfg = config_[i];\n+\t\tconst bool raw = isFormatRaw(cfg.pixelFormat);\n+\n+\t\t/* Adjust the raw pixel format and size. */\n+\t\tif (raw) {\n+\t\t\tif (cfg.pixelFormat != pipeConfig_->captureFormat ||\n+\t\t\t cfg.size != pipeConfig_->captureSize) {\n+\t\t\t\tcfg.pixelFormat = pipeConfig_->captureFormat;\n+\t\t\t\tcfg.size = pipeConfig_->captureSize;\n+\n+\t\t\t\tLOG(SimplePipeline, Debug)\n+\t\t\t\t\t<< \"Adjusting raw stream to \"\n+\t\t\t\t\t<< cfg.toString();\n+\t\t\t\tstatus = Adjusted;\n+\t\t\t}\n+\t\t}\n \n-\t\t/* Adjust the pixel format and size. */\n+\t\t/* Adjust the non-raw pixel format and size. */\n \t\tauto it = std::find(pipeConfig_->outputFormats.begin(),\n \t\t\t\t pipeConfig_->outputFormats.end(),\n \t\t\t\t cfg.pixelFormat);\n@@ -1227,13 +1247,13 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n \t\t\tit = pipeConfig_->outputFormats.begin();\n \n \t\tPixelFormat pixelFormat = *it;\n-\t\tif (cfg.pixelFormat != pixelFormat) {\n+\t\tif (!raw && cfg.pixelFormat != pixelFormat) {\n \t\t\tLOG(SimplePipeline, Debug) << \"Adjusting pixel format\";\n \t\t\tcfg.pixelFormat = pixelFormat;\n \t\t\tstatus = Adjusted;\n \t\t}\n \n-\t\tif (!pipeConfig_->outputSizes.contains(cfg.size)) {\n+\t\tif (!raw && !pipeConfig_->outputSizes.contains(cfg.size)) {\n \t\t\tSize adjustedSize = pipeConfig_->captureSize;\n \t\t\t/*\n \t\t\t * The converter (when present) may not be able to output\n", "prefixes": [ "RFC", "4/6" ] }