Patch Detail
Show a patch.
GET /api/patches/23735/?format=api
{ "id": 23735, "url": "https://patchwork.libcamera.org/api/patches/23735/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23735/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250703114225.2074071-6-paul.elder@ideasonboard.com>", "date": "2025-07-03T11:42:20", "name": "[v2,5/8] libcamera: camera_manager: Add LayerManager", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "69850e11e9f0f7217d99fcd5ba406cc46a6eacad", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23735/mbox/", "series": [ { "id": 5267, "url": "https://patchwork.libcamera.org/api/series/5267/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5267", "date": "2025-07-03T11:42:15", "name": "Add Layers support", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5267/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23735/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23735/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 64249BDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 3 Jul 2025 11:42:57 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0D95C68E53;\n\tThu, 3 Jul 2025 13:42:57 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 24B4468E5C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 3 Jul 2025 13:42:54 +0200 (CEST)", "from neptunite.hamster-moth.ts.net (unknown\n\t[IPv6:2404:7a81:160:2100:c61b:f3bf:2578:6674])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E6245667;\n\tThu, 3 Jul 2025 13:42:28 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"gao/JnoJ\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1751542950;\n\tbh=I32D9UINd7c7S7BdrRsz7Y9DNTN1rCnQRHfaIqpBB64=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=gao/JnoJDOTRmQE+B75MfW4NbVGF9sxEVct9D9gUB3WC2rkz7+083pZm8XIbEnbwy\n\tLEwmdEoYp/BupppjEuNtIv3M+u/HIasDUAs1vXDkZ7wmuX+zSls+swC/sVQDRyT1hd\n\taT+BoP4eO7JTgTcJkpoTpfjw8GAyZOZzFSkMrICc=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Paul Elder <paul.elder@ideasonboard.com>, kieran.bingham@ideasonboard.com,\n\tbarnabas.pocze@ideasonboard.com", "Subject": "[PATCH v2 5/8] libcamera: camera_manager: Add LayerManager", "Date": "Thu, 3 Jul 2025 20:42:20 +0900", "Message-ID": "<20250703114225.2074071-6-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.47.2", "In-Reply-To": "<20250703114225.2074071-1-paul.elder@ideasonboard.com>", "References": "<20250703114225.2074071-1-paul.elder@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Add to the CameraManager a LayerManager member. This allows us to have\none LayerManager that handles loading all the layer shared objects, and\nthen each Camera can access the layer via the LayerManager via through\nthe CameraManager.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n\n---\nNew in v2\n---\n include/libcamera/internal/camera_manager.h | 3 +++\n src/libcamera/camera_manager.cpp | 2 ++\n 2 files changed, 5 insertions(+)", "diff": "diff --git a/include/libcamera/internal/camera_manager.h b/include/libcamera/internal/camera_manager.h\nindex 0150ca61f7de..ef5b0688de23 100644\n--- a/include/libcamera/internal/camera_manager.h\n+++ b/include/libcamera/internal/camera_manager.h\n@@ -25,6 +25,7 @@ namespace libcamera {\n class Camera;\n class DeviceEnumerator;\n class IPAManager;\n+class LayerManager;\n class PipelineHandlerFactoryBase;\n \n class CameraManager::Private : public Extensible::Private, public Thread\n@@ -39,6 +40,7 @@ public:\n \tvoid removeCamera(std::shared_ptr<Camera> camera) LIBCAMERA_TSA_EXCLUDES(mutex_);\n \n \tIPAManager *ipaManager() const { return ipaManager_.get(); }\n+\tLayerManager *layerManager() const { return layerManager_.get(); }\n \n protected:\n \tvoid run() override;\n@@ -66,6 +68,7 @@ private:\n \n \tstd::unique_ptr<IPAManager> ipaManager_;\n \tProcessManager processManager_;\n+\tstd::unique_ptr<LayerManager> layerManager_;\n };\n \n } /* namespace libcamera */\ndiff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex e62e7193cfdc..0f202fc6314e 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -15,6 +15,7 @@\n \n #include \"libcamera/internal/camera.h\"\n #include \"libcamera/internal/device_enumerator.h\"\n+#include \"libcamera/internal/layer_manager.h\"\n #include \"libcamera/internal/ipa_manager.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n \n@@ -41,6 +42,7 @@ CameraManager::Private::Private()\n \t: initialized_(false)\n {\n \tipaManager_ = std::make_unique<IPAManager>();\n+\tlayerManager_ = std::make_unique<LayerManager>();\n }\n \n int CameraManager::Private::start()\n", "prefixes": [ "v2", "5/8" ] }