Patch Detail
Show a patch.
GET /api/patches/2372/?format=api
{ "id": 2372, "url": "https://patchwork.libcamera.org/api/patches/2372/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2372/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20191126233620.1695316-25-niklas.soderlund@ragnatech.se>", "date": "2019-11-26T23:36:14", "name": "[libcamera-devel,24/30] libcamera: stream: Make FrameBuffer support mandatory", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1ca1358c585be581fea9cfb9e36daf69c7593894", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2372/mbox/", "series": [ { "id": 579, "url": "https://patchwork.libcamera.org/api/series/579/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=579", "date": "2019-11-26T23:35:50", "name": "libcamera: Rework buffer API", "version": 1, "mbox": "https://patchwork.libcamera.org/series/579/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2372/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2372/checks/", "tags": {}, "headers": { "Return-Path": "<niklas.soderlund@ragnatech.se>", "Received": [ "from bin-mail-out-06.binero.net (bin-mail-out-06.binero.net\n\t[195.74.38.229])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A1ABB61C59\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 27 Nov 2019 00:39:44 +0100 (CET)", "from bismarck.berto.se (p54ac5865.dip0.t-ipconnect.de\n\t[84.172.88.101]) by bin-vsp-out-02.atm.binero.net (Halon) with ESMTPA\n\tid 0564c944-10a6-11ea-a0b9-005056917f90;\n\tWed, 27 Nov 2019 00:39:43 +0100 (CET)" ], "X-Halon-ID": "0564c944-10a6-11ea-a0b9-005056917f90", "Authorized-sender": "niklas@soderlund.pp.se", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Wed, 27 Nov 2019 00:36:14 +0100", "Message-Id": "<20191126233620.1695316-25-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.24.0", "In-Reply-To": "<20191126233620.1695316-1-niklas.soderlund@ragnatech.se>", "References": "<20191126233620.1695316-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH 24/30] libcamera: stream: Make FrameBuffer\n\tsupport mandatory", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Tue, 26 Nov 2019 23:39:44 -0000" }, "content": "All pipelines now uses V4L2Streams, make using a sub-class of Stream\nwhich implements the FrameBuffer interface helpers mandatory. Remove the\nfallback implementations in the Stream base class to prevent the base\nclass to be instantiated directly.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n include/libcamera/stream.h | 12 ++++--------\n 1 file changed, 4 insertions(+), 8 deletions(-)", "diff": "diff --git a/include/libcamera/stream.h b/include/libcamera/stream.h\nindex 395148e45d342d92..a3c692c347340382 100644\n--- a/include/libcamera/stream.h\n+++ b/include/libcamera/stream.h\n@@ -7,7 +7,6 @@\n #ifndef __LIBCAMERA_STREAM_H__\n #define __LIBCAMERA_STREAM_H__\n \n-#include <errno.h>\n #include <map>\n #include <memory>\n #include <string>\n@@ -89,13 +88,10 @@ protected:\n \tfriend class Camera;\n \n \tvirtual int allocateBuffers(const StreamConfiguration &config,\n-\t\t\t\t std::vector<FrameBuffer *> *buffers)\n-\t{\n-\t\treturn -EINVAL;\n-\t}\n-\tvirtual void releaseBuffers() { return; }\n-\tvirtual int start() { return -EINVAL; }\n-\tvirtual void stop() { return; }\n+\t\t\t\t std::vector<FrameBuffer *> *buffers) = 0;\n+\tvirtual void releaseBuffers() = 0;\n+\tvirtual int start() = 0;\n+\tvirtual void stop() = 0;\n \n \tint mapBuffer(const Buffer *buffer);\n \tvoid unmapBuffer(const Buffer *buffer);\n", "prefixes": [ "libcamera-devel", "24/30" ] }