Patch Detail
Show a patch.
GET /api/patches/23700/?format=api
{ "id": 23700, "url": "https://patchwork.libcamera.org/api/patches/23700/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23700/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250701090630.2654208-1-barnabas.pocze@ideasonboard.com>", "date": "2025-07-01T09:06:30", "name": "[v2] libcamera: pipeline: uvcvideo: Handle controls during startup", "commit_ref": "6b5cc1c92a33704e23bab2e5da699fa1d0678803", "pull_url": null, "state": "accepted", "archived": false, "hash": "f92179777c44c9f05a3726feba1e335903b46dfd", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23700/mbox/", "series": [ { "id": 5261, "url": "https://patchwork.libcamera.org/api/series/5261/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5261", "date": "2025-07-01T09:06:30", "name": "[v2] libcamera: pipeline: uvcvideo: Handle controls during startup", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5261/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23700/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23700/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8205AC3237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 1 Jul 2025 09:06:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 265E768E1B;\n\tTue, 1 Jul 2025 11:06:35 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C247668E16\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 1 Jul 2025 11:06:33 +0200 (CEST)", "from pb-laptop.local (185.221.143.107.nat.pool.zt.hu\n\t[185.221.143.107])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6B8A6C74\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 1 Jul 2025 11:06:11 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wkHU2Vco\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1751360771;\n\tbh=lmb3GZis32ZW6ushc1jz3+bth7Jqx9WtwvgmT6tZjQo=;\n\th=From:To:Subject:Date:From;\n\tb=wkHU2Vco0oJEOGuQlsRKtwDZAkl2I+V7R1CElg/YHB3ToXz3SFNEryLBUzeFgrRot\n\tWMGmnd0Je3kBDPFHaGYmfS9/YzlJwCzIVIopLliLpWuzK9Z4fzbU1N5k2j2apmm5gc\n\tdN5cBbSQSc+GBKy+E5VrghXGu7MOttEGdr+mBoBs=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v2] libcamera: pipeline: uvcvideo: Handle controls during\n\tstartup", "Date": "Tue, 1 Jul 2025 11:06:30 +0200", "Message-ID": "<20250701090630.2654208-1-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.50.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Process the control list passed to `Camera::start()`, and set\nthe V4L2 controls accordingly.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 27 +++++++++++++-------\n 1 file changed, 18 insertions(+), 9 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\nindex d52b88042..4b5816dfd 100644\n--- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n@@ -100,7 +100,7 @@ public:\n private:\n \tint processControl(const UVCCameraData *data, ControlList *controls,\n \t\t\t unsigned int id, const ControlValue &value);\n-\tint processControls(UVCCameraData *data, Request *request);\n+\tint processControls(UVCCameraData *data, const ControlList &reqControls);\n \n \tbool acquireDevice(Camera *camera) override;\n \tvoid releaseDevice(Camera *camera) override;\n@@ -287,7 +287,7 @@ int PipelineHandlerUVC::exportFrameBuffers(Camera *camera, Stream *stream,\n \treturn data->video_->exportBuffers(count, buffers);\n }\n \n-int PipelineHandlerUVC::start(Camera *camera, [[maybe_unused]] const ControlList *controls)\n+int PipelineHandlerUVC::start(Camera *camera, const ControlList *controls)\n {\n \tUVCCameraData *data = cameraData(camera);\n \tunsigned int count = data->stream_.configuration().bufferCount;\n@@ -296,13 +296,22 @@ int PipelineHandlerUVC::start(Camera *camera, [[maybe_unused]] const ControlList\n \tif (ret < 0)\n \t\treturn ret;\n \n-\tret = data->video_->streamOn();\n-\tif (ret < 0) {\n-\t\tdata->video_->releaseBuffers();\n-\t\treturn ret;\n+\tif (controls) {\n+\t\tret = processControls(data, *controls);\n+\t\tif (ret < 0)\n+\t\t\tgoto err_release_buffers;\n \t}\n \n+\tret = data->video_->streamOn();\n+\tif (ret < 0)\n+\t\tgoto err_release_buffers;\n+\n \treturn 0;\n+\n+err_release_buffers:\n+\tdata->video_->releaseBuffers();\n+\n+\treturn ret;\n }\n \n void PipelineHandlerUVC::stopDevice(Camera *camera)\n@@ -412,11 +421,11 @@ int PipelineHandlerUVC::processControl(const UVCCameraData *data, ControlList *c\n \treturn 0;\n }\n \n-int PipelineHandlerUVC::processControls(UVCCameraData *data, Request *request)\n+int PipelineHandlerUVC::processControls(UVCCameraData *data, const ControlList &reqControls)\n {\n \tControlList controls(data->video_->controls());\n \n-\tfor (const auto &[id, value] : request->controls())\n+\tfor (const auto &[id, value] : reqControls)\n \t\tprocessControl(data, &controls, id, value);\n \n \tfor (const auto &ctrl : controls)\n@@ -444,7 +453,7 @@ int PipelineHandlerUVC::queueRequestDevice(Camera *camera, Request *request)\n \t\treturn -ENOENT;\n \t}\n \n-\tint ret = processControls(data, request);\n+\tint ret = processControls(data, request->controls());\n \tif (ret < 0)\n \t\treturn ret;\n \n", "prefixes": [ "v2" ] }