Patch Detail
Show a patch.
GET /api/patches/23689/?format=api
{ "id": 23689, "url": "https://patchwork.libcamera.org/api/patches/23689/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23689/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250630081126.2384387-4-stefan.klug@ideasonboard.com>", "date": "2025-06-30T08:11:18", "name": "[v1,3/6] pipeline: rkisp1: Limit the maximum number of buffers queued in", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "4f5d4e83fe2c7238079e2fe95b5432660bc1261a", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23689/mbox/", "series": [ { "id": 5257, "url": "https://patchwork.libcamera.org/api/series/5257/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5257", "date": "2025-06-30T08:11:15", "name": "rkisp1: Allow usage of more than 4 buffers", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5257/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23689/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23689/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 99963C3237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 30 Jun 2025 08:11:46 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5010268E00;\n\tMon, 30 Jun 2025 10:11:45 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B3E161529\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 30 Jun 2025 10:11:41 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:883b:eaf8:7aec:d1d4])\n\tby perceval.ideasonboard.com (Postfix) with UTF8SMTPSA id 9F16C1352; \n\tMon, 30 Jun 2025 10:11:19 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ufCRbK8t\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1751271079;\n\tbh=0FD3dymIMrRUYE8sCRP1lb5ss/0Vt5MX7pZmwpw9qF4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=ufCRbK8tNq9IZz8fu1iWGQUfi5ZyMLJHr1EZxKPwyiOHCRZoWZz3QSlVkMEUFsOij\n\tn952I7xS6XYPiBxUTFfS8xU1r0YrgtUQmtYL672tEoZefyrexQGEP9hC/HZv1U3OtE\n\tEjlOb86kFp99pCCTVaodJq9Wq7VJrLtHq1nntqgA=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v1 3/6] pipeline: rkisp1: Limit the maximum number of buffers\n\tqueued in", "Date": "Mon, 30 Jun 2025 10:11:18 +0200", "Message-ID": "<20250630081126.2384387-4-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.48.1", "In-Reply-To": "<20250630081126.2384387-1-stefan.klug@ideasonboard.com>", "References": "<20250630081126.2384387-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "To keep the regulation of the algorithms as short as possible and to\nallow more buffers to be created than the v4l2 device allows to be queued,\nlimit the amount of buffers that get queued into the device to the pipeline depth.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n\n---\n\nChanges in v1:\n- Replaced function overload with constructor param\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 8 +++++++-\n 1 file changed, 7 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 675f0a7490a6..bd14ab237064 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -155,6 +155,12 @@ private:\n \tTransform combinedTransform_;\n };\n \n+namespace {\n+\n+const unsigned int kPipelineDepth = 4;\n+\n+};\n+\n class PipelineHandlerRkISP1 : public PipelineHandler\n {\n public:\n@@ -684,7 +690,7 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()\n */\n \n PipelineHandlerRkISP1::PipelineHandlerRkISP1(CameraManager *manager)\n-\t: PipelineHandler(manager), hasSelfPath_(true), useDewarper_(false)\n+\t: PipelineHandler(manager, kPipelineDepth), hasSelfPath_(true), useDewarper_(false)\n {\n }\n \n", "prefixes": [ "v1", "3/6" ] }