Patch Detail
Show a patch.
GET /api/patches/23655/?format=api
{ "id": 23655, "url": "https://patchwork.libcamera.org/api/patches/23655/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23655/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250625161458.31006-1-uajain@igalia.com>", "date": "2025-06-25T16:14:58", "name": "camera_sensor: Expand on computeTransform() documentation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "fea59dec44169aca96afa710d8214cec0416364f", "submitter": { "id": 232, "url": "https://patchwork.libcamera.org/api/people/232/?format=api", "name": "Umang Jain", "email": "uajain@igalia.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23655/mbox/", "series": [ { "id": 5248, "url": "https://patchwork.libcamera.org/api/series/5248/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5248", "date": "2025-06-25T16:14:58", "name": "camera_sensor: Expand on computeTransform() documentation", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5248/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23655/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23655/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D03F0BDCBF\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 25 Jun 2025 16:15:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A400561533;\n\tWed, 25 Jun 2025 18:15:02 +0200 (CEST)", "from fanzine2.igalia.com (fanzine2.igalia.com [213.97.179.56])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A9F3461533\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 25 Jun 2025 18:15:00 +0200 (CEST)", "from [49.36.69.141] (helo=uajain)\n\tby fanzine2.igalia.com with esmtpsa \n\t(Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256)\n\t(Exim) id 1uUSm3-008bHs-Dv; Wed, 25 Jun 2025 18:14:59 +0200" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=igalia.com header.i=@igalia.com\n\theader.b=\"eOSWFVqc\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com;\n\ts=20170329;\n\th=Content-Transfer-Encoding:MIME-Version:Message-ID:Date:Subject:\n\tCc:To:From:Sender:Reply-To:Content-Type:Content-ID:Content-Description:\n\tResent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:\n\tIn-Reply-To:References:List-Id:List-Help:List-Unsubscribe:List-Subscribe:\n\tList-Post:List-Owner:List-Archive;\n\tbh=VqJC0R0uBZB5SynRyIO2lueJbUzL9yTBwj/CKCvMJqU=;\n\tb=eOSWFVqc1FvmplAIkSGQ4KVZG2\n\tco9sOV77X7HAl/5eDYEwiF+dgMiqdRsUkx8aawoIrEU7r3uUl9fKA8d59IZkCLKOIo2uscSWSG2ds\n\t9iQM6McV2fUqEQhGhC8wdY2XWGqIJVSpjovkdVaIWhX6eIVjs+bs3o9q/33Bi6olIUXnMHIphJYK/\n\tXv7eP6nypg3lrJMzBPJgjHszM+RbrOihptJ3twzDfTbIQdvWtaqYP2k9jQWk47m6YtysE8CsY54d9\n\to6TpgImYmDhuTa7TJlj8jostYhgIpck44RIbIFa/j9PDgsukrsU1+ZnXBW2FWtVurFsjKK85Pg8g5\n\tve3X4c5g==;", "From": "Umang Jain <uajain@igalia.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Umang Jain <uajain@igalia.com>", "Subject": "[PATCH] camera_sensor: Expand on computeTransform() documentation", "Date": "Wed, 25 Jun 2025 21:44:58 +0530", "Message-ID": "<20250625161458.31006-1-uajain@igalia.com>", "X-Mailer": "git-send-email 2.50.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The description for computeTransform() when the desired orientation\ncannot be achieved, can be expanded a further bit, to clearly report\nthat orientation will be adjusted to native camera sensor mounting\norientation.\n\nSigned-off-by: Umang Jain <uajain@igalia.com>\n---\n src/libcamera/sensor/camera_sensor.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/sensor/camera_sensor.cpp b/src/libcamera/sensor/camera_sensor.cpp\nindex d19b5e2e..6f4a13fe 100644\n--- a/src/libcamera/sensor/camera_sensor.cpp\n+++ b/src/libcamera/sensor/camera_sensor.cpp\n@@ -302,7 +302,8 @@ int CameraSensor::setEmbeddedDataEnabled(bool enable)\n * camera sensor, likely at configure() time.\n *\n * If the requested \\a orientation cannot be obtained, the \\a orientation\n- * parameter is adjusted to report the current image orientation and\n+ * parameter is adjusted to report the native image orientation (i.e.\n+ * physical mounting orientation of the camera sensor) and\n * Transform::Identity is returned.\n *\n * If the requested \\a orientation can be obtained, the function computes a\n", "prefixes": [] }