Patch Detail
Show a patch.
GET /api/patches/23606/?format=api
{ "id": 23606, "url": "https://patchwork.libcamera.org/api/patches/23606/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23606/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250619111614.1132382-1-kieran.bingham@ideasonboard.com>", "date": "2025-06-19T11:16:14", "name": "libcamera: controls: Revert incorrect SPDX removal", "commit_ref": "5f4d2ac935ee40e901bacc844869c96a20c296c7", "pull_url": null, "state": "accepted", "archived": false, "hash": "91918909f910c1bc185c4719ede781248f24f433", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23606/mbox/", "series": [ { "id": 5233, "url": "https://patchwork.libcamera.org/api/series/5233/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5233", "date": "2025-06-19T11:16:14", "name": "libcamera: controls: Revert incorrect SPDX removal", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5233/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23606/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23606/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D2B56BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 19 Jun 2025 11:16:24 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3438E68DE3;\n\tThu, 19 Jun 2025 13:16:24 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC09868DDB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 Jun 2025 13:16:22 +0200 (CEST)", "from Monstersaurus.hippo-penny.ts.net\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E3CDA2EC;\n\tThu, 19 Jun 2025 13:16:08 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"l+MHSOLA\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1750331769;\n\tbh=hqorLrEeSzh+gzVL42d7IyWPiQvj1eF1oBdQfPKHPA8=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=l+MHSOLAgt5oxN0Z/HAnuZkUSWmDuhc36cLWsAomURcdcAVW6xBrs9Yvy/NkPgzTH\n\t5Zg+nWrP3+9YEF8V00Ew5PZrQlUQVGNDRtRyG/rzjy6BbfBb4jmlMt4jQUSVJttNQZ\n\t1SyFexFa4tNTRoHT/Bpv1SItfidg1f55vnh4cvHc=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH] libcamera: controls: Revert incorrect SPDX removal", "Date": "Thu, 19 Jun 2025 12:16:14 +0100", "Message-ID": "<20250619111614.1132382-1-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In commit 6a09deaf7d4a (\"controls: Add FrameWallClock control\") the\nexisting SPDX was accidentally removed, likely from a rebase operation\nat some point.\n\nUnfortunately as this patch had already collected Reviewed-by tags, the\nsurruptious removal wasn't noticed until after it was merged.\n\nRe-insert the existing SPDX and copyright banner as the header to the\ncontrol definitions file.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n\nOoops, I merged something that interferred with the existing copyright\nheader. This brings it back again.\n\n src/libcamera/control_ids_core.yaml | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\nindex 028919ef3d3e..46f51436c215 100644\n--- a/src/libcamera/control_ids_core.yaml\n+++ b/src/libcamera/control_ids_core.yaml\n@@ -1,4 +1,6 @@\n-\n+# SPDX-License-Identifier: LGPL-2.1-or-later\n+#\n+# Copyright (C) 2019, Google Inc.\n #\n %YAML 1.1\n ---\n", "prefixes": [] }