Patch Detail
Show a patch.
GET /api/patches/23570/?format=api
{ "id": 23570, "url": "https://patchwork.libcamera.org/api/patches/23570/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23570/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250616084733.18707-8-mzamazal@redhat.com>", "date": "2025-06-16T08:47:25", "name": "[v10,07/13] config: Look up pipelines match list in configuration file", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "00d7c10f21efa21aa1e4a5351a841baee816fcd5", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23570/mbox/", "series": [ { "id": 5220, "url": "https://patchwork.libcamera.org/api/series/5220/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5220", "date": "2025-06-16T08:47:18", "name": "Add global configuration file", "version": 10, "mbox": "https://patchwork.libcamera.org/series/5220/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23570/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23570/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2DF62C3237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 16 Jun 2025 08:48:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 819F068DD6;\n\tMon, 16 Jun 2025 10:48:12 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C902068DC6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 16 Jun 2025 10:48:09 +0200 (CEST)", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-593-3_1qHOHQNRWVx7glXNUN7Q-1;\n\tMon, 16 Jun 2025 04:48:06 -0400", "from mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.15])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 67F191801BD8; Mon, 16 Jun 2025 08:48:05 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.226.135])\n\tby mx-prod-int-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 3D8B91956094; Mon, 16 Jun 2025 08:48:02 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"RgXYoySb\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1750063688;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=r14txaJ0G6tckH0QcLCrdFm1NtoW0hnAPrx2xeh+Ze4=;\n\tb=RgXYoySbnb1eLTKd7I4Buopi6cqXtTzXUwD8TubvZvwgtmSed13B+MUW3ntt++Ls5LdaP5\n\tIMMyWqfvarnTbj0Lkjj9OOMvLXKlE4MuYoFvWRxrPwgfAzN/J79J3LM2gJoGUnjYdhI207\n\tAei99YmyBDpL8tNrVme4vbdnIZFUDGI=", "X-MC-Unique": "3_1qHOHQNRWVx7glXNUN7Q-1", "X-Mimecast-MFC-AGG-ID": "3_1qHOHQNRWVx7glXNUN7Q_1750063685", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<pobrn@protonmail.com>, Laurent Pinchart\n\t<laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v10 07/13] config: Look up pipelines match list in\n\tconfiguration file", "Date": "Mon, 16 Jun 2025 10:47:25 +0200", "Message-ID": "<20250616084733.18707-8-mzamazal@redhat.com>", "In-Reply-To": "<20250616084733.18707-1-mzamazal@redhat.com>", "References": "<20250616084733.18707-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.15", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "PtOrL737ePEL29EYDIt_4B__vZuYNA8nqjhg8tCLwfQ_1750063685", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Let's add a configuration file item for the pipelines match list.\n\nThe configuration snippet:\n\n configuration:\n pipelines_match_list: rkisp1,simple\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/camera_manager.cpp | 9 +++++----\n 1 file changed, 5 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex c47fd3677..b4d56c3aa 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -111,14 +111,15 @@ void CameraManager::Private::createPipelineHandlers()\n \t * file and only fallback on environment variable or all handlers, if\n \t * there is no configuration file.\n \t */\n-\tconst char *pipesList =\n-\t\tutils::secure_getenv(\"LIBCAMERA_PIPELINES_MATCH_LIST\");\n-\tif (pipesList) {\n+\tstd::optional<std::string> pipesList =\n+\t\tconfiguration().envOption(\"LIBCAMERA_PIPELINES_MATCH_LIST\",\n+\t\t\t\t\t \"pipelines_match_list\");\n+\tif (pipesList.has_value()) {\n \t\t/*\n \t\t * When a list of preferred pipelines is defined, iterate\n \t\t * through the ordered list to match the enumerated devices.\n \t\t */\n-\t\tfor (const auto &pipeName : utils::split(pipesList, \",\")) {\n+\t\tfor (const auto &pipeName : utils::split(pipesList.value(), \",\")) {\n \t\t\tconst PipelineHandlerFactoryBase *factory;\n \t\t\tfactory = PipelineHandlerFactoryBase::getFactoryByName(pipeName);\n \t\t\tif (!factory)\n", "prefixes": [ "v10", "07/13" ] }