Patch Detail
Show a patch.
GET /api/patches/23561/?format=api
{ "id": 23561, "url": "https://patchwork.libcamera.org/api/patches/23561/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23561/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250613120623.1073184-1-barnabas.pocze@ideasonboard.com>", "date": "2025-06-13T12:06:23", "name": "[v1] meson: Update `gtest` wrap to 1.17.0", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "4ed6f02934e197765eb6d98e406ab4d5b17e3ee1", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23561/mbox/", "series": [ { "id": 5218, "url": "https://patchwork.libcamera.org/api/series/5218/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5218", "date": "2025-06-13T12:06:23", "name": "[v1] meson: Update `gtest` wrap to 1.17.0", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5218/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23561/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23561/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7ED3AC3237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 13 Jun 2025 12:06:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 32BBD68DBE;\n\tFri, 13 Jun 2025 14:06:29 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 19F5F68DB4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Jun 2025 14:06:27 +0200 (CEST)", "from pb-laptop.local (185.221.143.107.nat.pool.zt.hu\n\t[185.221.143.107])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 91739ED\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 13 Jun 2025 14:06:17 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"So6QLxwT\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1749816377;\n\tbh=nvwdyTm1SY6y6aHwcI5j/8y38rwQBJoiT9W6p6/bEKM=;\n\th=From:To:Subject:Date:From;\n\tb=So6QLxwTxtW+5wykDeq2TMBVO8hN2pawKTD3gt66MdQSONL+mE1Z7bxqn7EkfciO1\n\tXTFUZPZfdEtXyw1UD1eTxtRRYMd/keoHCyizln9DMewT7lJ1zV3R1Cx8oZWz/VcqkI\n\tvpnCo9T0m3mA0zkxqy0QdIaBPCQGNMnjXTYEvHDY=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1] meson: Update `gtest` wrap to 1.17.0", "Date": "Fri, 13 Jun 2025 14:06:23 +0200", "Message-ID": "<20250613120623.1073184-1-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Update `gtest` to the latest available version in the wrapdb,\n1.17.0, which was released on 2025-04-30. The wrap file has not\nbeen updated since it was added, using version 1.11.0, which\nwas released more than 4 years ago.\n\nDue to changes in the wrap file, googletest is compiled as a\nlibrary instead of just attaching its sources the build targets\nusing it, so the `default_library=static` option is added to\npreserve the same behaviour.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/apps/lc-compliance/meson.build | 5 ++++-\n subprojects/.gitignore | 2 +-\n subprojects/gtest.wrap | 18 +++++++++---------\n 3 files changed, 14 insertions(+), 11 deletions(-)", "diff": "diff --git a/src/apps/lc-compliance/meson.build b/src/apps/lc-compliance/meson.build\nindex 80b9a1602..cb2506b65 100644\n--- a/src/apps/lc-compliance/meson.build\n+++ b/src/apps/lc-compliance/meson.build\n@@ -2,7 +2,10 @@\n \n libgtest = dependency('gtest', version : '>=1.10.0',\n required : get_option('lc-compliance'),\n- fallback : ['gtest', 'gtest_dep'])\n+ fallback : ['gtest', 'gtest_dep'],\n+ default_options : [\n+ 'default_library=static',\n+ ])\n \n if opt_lc_compliance.disabled() or not libevent.found() or not libgtest.found()\n lc_compliance_enabled = false\ndiff --git a/subprojects/.gitignore b/subprojects/.gitignore\nindex b08d69907..3e9a39182 100644\n--- a/subprojects/.gitignore\n+++ b/subprojects/.gitignore\n@@ -1,6 +1,6 @@\n # SPDX-License-Identifier: CC0-1.0\n \n-/googletest-release*\n+/googletest-*\n /libpisp\n /libyaml\n /libyuv\ndiff --git a/subprojects/gtest.wrap b/subprojects/gtest.wrap\nindex 8892e1842..3a9771450 100644\n--- a/subprojects/gtest.wrap\n+++ b/subprojects/gtest.wrap\n@@ -1,13 +1,13 @@\n-# SPDX-License-Identifier: CC0-1.0\n-\n [wrap-file]\n-directory = googletest-release-1.11.0\n-source_url = https://github.com/google/googletest/archive/release-1.11.0.zip\n-source_filename = gtest-1.11.0.zip\n-source_hash = 353571c2440176ded91c2de6d6cd88ddd41401d14692ec1f99e35d013feda55a\n-patch_filename = gtest_1.11.0-1_patch.zip\n-patch_url = https://wrapdb.mesonbuild.com/v2/gtest_1.11.0-1/get_patch\n-patch_hash = d38c39184384608b08419be52aed1d0f9d9d1b5ed71c0c35e51cccbdddab7084\n+directory = googletest-1.17.0\n+source_url = https://github.com/google/googletest/archive/refs/tags/v1.17.0.tar.gz\n+source_filename = googletest-1.17.0.tar.gz\n+source_hash = 65fab701d9829d38cb77c14acdc431d2108bfdbf8979e40eb8ae567edf10b27c\n+patch_filename = gtest_1.17.0-3_patch.zip\n+patch_url = https://wrapdb.mesonbuild.com/v2/gtest_1.17.0-3/get_patch\n+patch_hash = 3e2799683f27c6dce138b7bae823416581c467ddde755c9a516c0863225f0ceb\n+source_fallback_url = https://github.com/mesonbuild/wrapdb/releases/download/gtest_1.17.0-3/googletest-1.17.0.tar.gz\n+wrapdb_version = 1.17.0-3\n \n [provide]\n gtest = gtest_dep\n", "prefixes": [ "v1" ] }