Patch Detail
Show a patch.
GET /api/patches/23555/?format=api
{ "id": 23555, "url": "https://patchwork.libcamera.org/api/patches/23555/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23555/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250612071643.989998-1-hui.fang@nxp.com>", "date": "2025-06-12T07:16:43", "name": "libcamera: v4l2_videodevice: Enumerate all resolutions on V4L2_FRMSIZE_TYPE_DISCRET", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": false, "hash": "18d95912c1a6fbc0406c5a511d52d38cdfc7962e", "submitter": { "id": 186, "url": "https://patchwork.libcamera.org/api/people/186/?format=api", "name": "Fang Hui", "email": "hui.fang@nxp.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23555/mbox/", "series": [ { "id": 5216, "url": "https://patchwork.libcamera.org/api/series/5216/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5216", "date": "2025-06-12T07:16:43", "name": "libcamera: v4l2_videodevice: Enumerate all resolutions on V4L2_FRMSIZE_TYPE_DISCRET", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5216/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23555/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23555/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 45794BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 12 Jun 2025 07:57:35 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BFB4B68DC0;\n\tThu, 12 Jun 2025 09:57:33 +0200 (CEST)", "from DU2PR03CU002.outbound.protection.outlook.com\n\t(mail-northeuropeazlp170110003.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:c200::3])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DB93A61550\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 12 Jun 2025 09:57:30 +0200 (CEST)", "from DB9PR04MB9284.eurprd04.prod.outlook.com (2603:10a6:10:36c::8)\n\tby PA2PR04MB10122.eurprd04.prod.outlook.com (2603:10a6:102:40a::7)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8835.19;\n\tThu, 12 Jun 2025 07:57:29 +0000", "from DB9PR04MB9284.eurprd04.prod.outlook.com\n\t([fe80::c5dc:4676:2254:2f4]) by\n\tDB9PR04MB9284.eurprd04.prod.outlook.com\n\t([fe80::c5dc:4676:2254:2f4%4]) with mapi id 15.20.8835.019;\n\tThu, 12 Jun 2025 07:57:29 +0000" ], "Authentication-Results": [ "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"NMM8CMBE\";\n\tdkim-atps=neutral", "dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=nxp.com;" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n\tb=cW+Ws/L8vn2KWqkCsA8+0FiDxbPk5RQcqfOfTvv+AH62oywtEGJzbrYjNYCuLwZLi821qoi0x7kYDUc+Z6VgbSV4Q7p8uqc0k+WD9d1dDwL9HmcJTIfVgCo4KVwceHMh6sOtDI49/Jb8O6DA+oeSxaLgcoY0DsacjcmwX03+Q3/pDt89ovOLXG/qnF5CGklE56nC6G2FmzELYFBlv2RVEDuTuyUGh9axu3EOcfLGcCeONzhFQWZ6MYGZyD589qFBaf6aPuKYRtLMrL19fPdWSnxhJjLuYsK76kBodQyHMWRXvKdEN+g8l/UgP77QovVpEtV6grmnaApakrHjLhhMNw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector10001;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=EgpAigX7tdGS8kC2HRflLQpL2pAnX7TZ9XKcMqtbSOQ=;\n\tb=nxczSxfytQn7W3yfeZF3ZYYnAS1H5IDaCd75aREVv5gAFj3E9AYp2LGGjzBujI//yMfVVlo2zE7XkPIpajDtmK1wrdVX7D8YQ7sTKLOCFqO6LPSf3+DXhqZQ2tb8jba6whvExuzR1He2FuG10A3i2xtz4Qse3hOPvrhiTvaHSPVyMDdSOo7Zcchyaf2fqyZPcrddFxtamT+i4v8tHzvA3cjd8wIDs78lnvIFd2FLc/6fajniuiGHXKeXrGNdRE5wrS1QPcZJiBq41w8WyuPZb8c7fzbH7EhrBMVpsH4qDKxYFIBH4fLiz63u//BnfkWYsYceis9ALSxoQhAbShlimA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com;\n\tdkim=pass header.d=nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=EgpAigX7tdGS8kC2HRflLQpL2pAnX7TZ9XKcMqtbSOQ=;\n\tb=NMM8CMBErRRx0u577o7KJtKy5HAVhjagZ4e9PskmkW9Kw6v4bLfQ6nEXMZav4m/nO5NjEvmhuQ36/9tlCUMNm11pPNP4K60Cpz4kYgO244eTXCF1QmJd0QjXIY2ZGByTjNn3AnaGb0nC911HRxUsu7tZlo3/e0S4+2ykIIXkyNcsZgcc2IiR9lKBIYI/HDokuNpOb927kQGycESYXH2xXBN5CpO0QpIQUzeVDq2XNA0DNhEKI+EekN66D36Pcq3Qet4/IRoIfWoiKXwDf5Aox1VAx9kbbrTr/nFHW9oTQ8MkXndXn9imPfRkGXtfbBX95SGS1gbfceHOya8CB7EFkQ==", "From": "Fang Hui <hui.fang@nxp.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "hui.fang@nxp.com, jacopo.mondi@ideasonboard.com,\n\tbarnabas.pocze@ideasonboard.com, laurent.pinchart@ideasonboard.com", "Subject": "[PATCH] libcamera: v4l2_videodevice: Enumerate all resolutions on\n\tV4L2_FRMSIZE_TYPE_DISCRET", "Date": "Thu, 12 Jun 2025 15:16:43 +0800", "Message-Id": "<20250612071643.989998-1-hui.fang@nxp.com>", "X-Mailer": "git-send-email 2.25.1", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SI1PR02CA0045.apcprd02.prod.outlook.com\n\t(2603:1096:4:1f6::16) To DB9PR04MB9284.eurprd04.prod.outlook.com\n\t(2603:10a6:10:36c::8)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "DB9PR04MB9284:EE_|PA2PR04MB10122:EE_", "X-MS-Office365-Filtering-Correlation-Id": "eb3a87dd-cb39-4e6f-3935-08dda986c719", "X-LD-Processed": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n\tARA:13230040|376014|52116014|366016|1800799024|38350700014; ", "X-Microsoft-Antispam-Message-Info": "EhSufKF7TpRv7Rf5exdoNyrshQbSTo8VMifzAmFXw8Mw70vO0ZS0riW6WJynf6K5VP79MnmMzSZB69p8CzbEFagCCNoEdG9ke/54ezTjaZMY3/XGXX4SBTEWOLRZNQUcEREKpkVj9gLIciBHAJHMSw/bNCqdL4/L1jdZ5p+j3FP0AWkB/Z2qhEHazNmFt5H/th4+j4eUoazpcJxZWRTkpKlEvfTMeJBgVmAq/zQhV0zkX+5hr3pKczoMLcXDf9FqAgfK9t4mkSQqc5Sa2FFgThFxhTvtOHo3PwW5sqCP9bvK8Fl7yriaOz37GMSAjnGPV0H0HJbYYOEbezwaVdr2zrfe1N0G8v5m2HCYRrP9cJ/OG51kk+DCZRNoho8PMYXM7s4Qx9dMAlRJ/6tjdm4PuO1ub3hU5NtpgSZUC7f0KwlCEGnAq+OyekBvu7rXrktg5/fToC/Jl4aQtZAkjF1qoBiVGPbWMeg/bTB9Cc8p5EiwNeSplyugdkaqoQsQJ3ZFpczXXFAcsbUCmPOGcBxAwXrKGauLLoFatxyB9JDY8bQLJe25z1OUO5B1/LXI3fHt2njAriSnquB+zmddEU/6n4QL4t83Ah/YukOwqUsffuosuYFQJXF8Bx6Idsze+lIeBc2ThXv22oM6KTZiZ966uiyiZo6fAdedWSWud/pWWQi2Y75jnBAaiLaUSI0XQ+MUBvIf6aq8PVV3ROgFSvmAg7iiFTfwibc1EigczQ5y19lemDg+LfecLEZa78hYSdzjtljoqICFZj3nGddhEoUpHGPY76QMOwYpCO0+qv8dhKYxxFt+U0zujAe0C8/QM3h8J6FSa5XQuqzCA5eD7tkY+yUwPONmFzlZQ9+R9f1xEhR8oxGnDLb9lMT91TwMSNKo65vN/cKOQElM5Q6fRvW8ifVWo6S1B2KI1SkgddieykHNQC6T0lPBs4M+C1SCIjuu0kjL22e+GR5nNjSePSwIbZmufAsDkIfRa07Th10AIRnrPVAiKNSH/0WDzaHbjHMefMbyB9oFYZjnCt8vh03yklGGsz43qs/6hrS06rAJ2+poLUN7gATLLKdTi732T77fooz88o2712Y0mjqQpatxdA/nm1xDWbQgbD7vfK8+L4shGuh81hvCFhNhyBH8XPLRXPcYSOaSeV+uqXc2MvGyYjQY+PIc7kGZb9HB2XtmPwrCRxWmnQIOMIOCFuZyGzGdhIy9nZM/Zv8Xt6Cgmv5Zvod0eI6po165VVbN11/A+4XUNGo4pr8i6ZI7RZUsJD90FooPyG2BzU8Hzza6/0CQA7wuzBbS+WaQ2wlwzN9CTNJG8yLrmM0NrGfnfRDzANFGW6MSFP98kAoRMGB8CqP6GoJQGkXznE1XtZDSzPxC2BlyFF4LCAWIYgS9RKUK1LkSQNM2OhUHSEARC9HNEgP/v0vx/QVbroNvVg4D1g/XVqwnhYaCyuCiFtHb9RAnQ0RwNqlLNfjmXd6aozp7CVqYaw==", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:DB9PR04MB9284.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230040)(376014)(52116014)(366016)(1800799024)(38350700014);\n\tDIR:OUT; SFP:1101; ", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "IhSoKh7Dw9ax2JkfXiHHPScdkKyBAUkhuQHE8Nhd1uom/Bz/Ic8jR+oShp/KIY/1ZEWzAo43lp+l1LdfwEeNaweqL4Gaj1x+0+T3Sn/1vKbwhOKalme1Ei86DQLJhgDbvfYmwao2Fq0EJxs0uXghiyipLnwTAXqm7MhyiTkUNT85N92+8ynzd+yWmQUoRwwT0VMvlFRK+Xw5aP1349SXdjl1v7xelvJ+TRZ5CiS/QEPBse6Qf6cvGFruhTJqhTwiMn605q8AO63O3lMnzhWxZaQv9KnBGtYIBW2LrJiMNmb5Q1KH2TsKu43E1+Ef/Ma2Xu+WbPrwZaawuEBEr2KPhVO+9MTEKjTm1EE4sFa9h6Ma5yyq2rXl1O2T0mlPZYQEvLtrqb9vnTdfAtCaAtuy251wIXhM2g5iZE67fH4PaTn463e6xIjtiz2xEGNdMXKorwYfaBLtJX/EiZAnRlis0oSbrWcPWbRQAWb8b/HPOsepfGe1MGSaEOfj4JvBkKSC1JC4B6rF8kAiwLMUeuIaK0isiWw+eQ/owArP2O30GctcEjf1Q2k3dk2w/ui5prUZtbyzl2qWRMAAXeidLjjNSD2JLIlmM+X7iIOmnKsP1nzoHc/GTcUX2FWZKr3agKCnyKikqWMCEqpugRx1U31vTpB0Uxd5mRh18shncFPBA9FnoPPykUPev9/Ki29/DUTNk4EDkkGzEsrlsbdDiglhD4QAyvWD1htoAtN2RPVRjksGw5BkSiKASzgzQ+dkA2Gsg2BEnXeJiDE/4VndV4x1V1yE/V9Db0tV8AVC/ZSCew3nWSfzq1p5Df/0No83KUgNRvXHcP0Vj6L4panIAd8+ey6w9D7kKQtakX5gyH859bL02WIoSBn73Y1V7ylbs/zLyW8001vYYS/ddoSUQlE1Ea5csA+pLAwVdEVvnTHxjhBVJt5DAsQUcAejfoBHbNWRAo3sNZTLXXPA05onCMNJz6dCEdinY3lUzEwUQTHhXQ0IAyo4vOEYsIJOt3icZj9eoY6JLp9kQYRameoJvWLMOs1x6LUOTB+p4c/BlPkEgtshRRNcSYNY1/WWbf66APA7tFjH6GBMBmYKAP9VJMfWWTLACwOgD7HzZJddW7Vd0rUgB7qZchmtq5Xo9QVknnj/AoSV+1tmD4QQFAi6fPfgHxKTdZMdUrv/z1aKEyQ7njKebDXODk6dL7RHblytEjs7arcosbyYyYX/M7PTLFOBGGKGg0KjJaC/IFvPKA4bf/VAkqLcJkvD9eZMeFDMGY8wk61LrSpHTUr50cD0CWijVUJu7WZSjIJQPcvzfGPXdTQSJ+2vqTACSQy2hsA5CMaaiD9wI3pR2AHqMAewTBsbYtNmWlNHOsw5+L1ulR2PLkNFSdWLSJ4sIcgYEstHuJgJtRpFpMfpWkUkUcJzqNDFjolAbjcsfnAN4ZTozPgZ5pLKijP14HodfGjZFZi/dCtRtcsj5Rw03Jtu/A/qazRPdyI1AGIj/olGg1syFojtvBeuR/CeIgEA81dpMAPF6GwX/EhRvDk/MPZxXHk21/+ck5OhoFtk2pien4rFdvUV1kwdCLKUOD7E92AZr3Q48XEI", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "eb3a87dd-cb39-4e6f-3935-08dda986c719", "X-MS-Exchange-CrossTenant-AuthSource": "DB9PR04MB9284.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "12 Jun 2025 07:57:29.3010\n\t(UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "WODvfoQ+wLIt3PlUo0wal+T6bZvqXHDxo1b/VHfBjqOHcPcZy34eIUuXKqvGxj0wKxDsNI1cvy85hvM0YMb2EQ==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PA2PR04MB10122", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Use \"continue\" instead of \"break\" to complete the \"sizes\".\n\nSigned-off-by: Fang Hui <hui.fang@nxp.com>\n---\n src/libcamera/v4l2_videodevice.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex d53aa2d3..3d6273e1 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -1204,7 +1204,7 @@ std::vector<SizeRange> V4L2VideoDevice::enumSizes(V4L2PixelFormat pixelFormat)\n \t\tcase V4L2_FRMSIZE_TYPE_DISCRETE:\n \t\t\tsizes.emplace_back(Size{ frameSize.discrete.width,\n \t\t\t\t\t\t frameSize.discrete.height });\n-\t\t\tbreak;\n+\t\t\tcontinue;\n \t\tcase V4L2_FRMSIZE_TYPE_CONTINUOUS:\n \t\t\tsizes.emplace_back(Size{ frameSize.stepwise.min_width,\n \t\t\t\t\t\t frameSize.stepwise.min_height },\n", "prefixes": [] }