Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 23531,
    "url": "https://patchwork.libcamera.org/api/patches/23531/?format=api",
    "web_url": "https://patchwork.libcamera.org/patch/23531/",
    "project": {
        "id": 1,
        "url": "https://patchwork.libcamera.org/api/projects/1/?format=api",
        "name": "libcamera",
        "link_name": "libcamera",
        "list_id": "libcamera_core",
        "list_email": "libcamera-devel@lists.libcamera.org",
        "web_url": "",
        "scm_url": "",
        "webscm_url": ""
    },
    "msgid": "<20250611013245.133785-26-bryan.odonoghue@linaro.org>",
    "date": "2025-06-11T01:32:35",
    "name": "[25/35] libcamera: shaders: Use highp not mediump for float precision",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": false,
    "hash": "1be27c382aa8a6cb48a4d14854ff0ed550331eb6",
    "submitter": {
        "id": 175,
        "url": "https://patchwork.libcamera.org/api/people/175/?format=api",
        "name": "Bryan O'Donoghue",
        "email": "bryan.odonoghue@linaro.org"
    },
    "delegate": null,
    "mbox": "https://patchwork.libcamera.org/patch/23531/mbox/",
    "series": [
        {
            "id": 5212,
            "url": "https://patchwork.libcamera.org/api/series/5212/?format=api",
            "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5212",
            "date": "2025-06-11T01:32:10",
            "name": "Add GLES 2.0 GPUISP to libcamera",
            "version": 1,
            "mbox": "https://patchwork.libcamera.org/series/5212/mbox/"
        }
    ],
    "comments": "https://patchwork.libcamera.org/api/patches/23531/comments/",
    "check": "pending",
    "checks": "https://patchwork.libcamera.org/api/patches/23531/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>",
        "X-Original-To": "parsemail@patchwork.libcamera.org",
        "Delivered-To": "parsemail@patchwork.libcamera.org",
        "Received": [
            "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 44B53C3330\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 11 Jun 2025 01:34:16 +0000 (UTC)",
            "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CD9C768DF0;\n\tWed, 11 Jun 2025 03:34:15 +0200 (CEST)",
            "from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com\n\t[IPv6:2a00:1450:4864:20::32e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E509768DBD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 11 Jun 2025 03:34:10 +0200 (CEST)",
            "by mail-wm1-x32e.google.com with SMTP id\n\t5b1f17b1804b1-450cfb6a794so39717245e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 Jun 2025 18:34:10 -0700 (PDT)",
            "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4532514138asm5680625e9.3.2025.06.10.18.34.07\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 10 Jun 2025 18:34:09 -0700 (PDT)"
        ],
        "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"XN8ghr73\"; dkim-atps=neutral",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1749605650; x=1750210450;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=pgxhz6GMo/Uz+bg1jme6l3ObzPAtkWH3ImPuJmWGaLM=;\n\tb=XN8ghr73/06hzpAQ6xWdnyhInVJ3027L7+rRQ7oaWpi7bU+zDKHQECr98YPWkZ9Akg\n\txmtUL1ZXw0HP9sQ0m1HZwBRznerAtz0/oUPPp4j7pJaCi3ys/kqhJVj7XhTxv3alAsBf\n\tdUNfzwK35YLblLm02MQaCYCEFwMNyZLH+TmKGMP16VWnlOvGOO4BYhNQZI1Tvi1jc7Zb\n\tTZK7cUsvKW94er4THxv7j8giV51YEq1TXoypxS11xpXBpKOdSIwxXBfbAowvdYqr9EgW\n\taavWLBnyW/XZq1BZ5vtw7K+CLR8pXpDAUYE9KmQ9On3o49DPZR5g8aZe0l5DB5mDmZZa\n\tdvfA==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1749605650; x=1750210450;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=pgxhz6GMo/Uz+bg1jme6l3ObzPAtkWH3ImPuJmWGaLM=;\n\tb=K7sGs3fEL0Yl/fdsNd8dKnlTu3IWwye8EuQOmgQlcQ5symEgpnxhI8XSTLDN79jG2t\n\tNcxzjApKBJHnWb/BUrUrX+FiDI/2ORkgCtxHUz4DiObwZhtNfB/JTgF3L3lLOPMlgHay\n\tDM8KWahU/dxqeGOzocyO8TNSeOqy7SJ5W5eTT22JM4PLr41xWcgYJysOPxjk9EAti0Z1\n\twZunXAowR8+gBVKSsxngG9l0+q7pCJcV90YCaaUz85Bl1Yo5uHagtfLcFNzDIQIKwZro\n\t8R7VP7FR3gQY2Oj9Lu5DZEts/ZCi4yl6woYneHZOcBAJwEVbwq8rsIiApmEZh1PzCFFj\n\t+cUg==",
        "X-Gm-Message-State": "AOJu0YzJy+J+ugw4Dk8qYhPG/5IKrtvZeLXep/9XKGjjDj1qqMuRd31g\n\tAag5U6eTksBK2M+rBX8+HCJu76W0/gTXaYN0Xk7nGa2XR3GzH9Q1S60BgcqYUcVf9+8YGkSk086\n\tylA6husc=",
        "X-Gm-Gg": "ASbGnctKSoVtPkZoinrJW4d5vVmBRVruOelIW9u5+1taRO2sY2V79+ELVEQMa3NQVtR\n\to1Vqa5Do55oeMgpk5TcRjeNO3HN1c4UqKAkxHVQmDKO7VHgvGr6CwXslLJHoQ2NnwYiYSosNiqm\n\tC79vVZz7n2iz4DyxhgYGHBIjqTXI2JNwzqGHulF4Q/L6rRqC1G34rAbmZNEGen5t48ZEt1YBvqg\n\ttRZi2+jWfYCeOXcr9RuL6Dq/wpUMwVmlLI693w9ZnPEVsOAPKRHfiGTG6BCpFe8bg+WUUw9132R\n\t2Fqcu68nHLuUnrspPsQ3wRS5Xi9sOqNSB17SugFWx/MaDnMwj6DKeekgS6Q492KUcz/6N55XKeu\n\th0DGHSP+In/BRGWycWq3KjlQtfczlvWB3dUAp04hGgBZlvon7hxW2",
        "X-Google-Smtp-Source": "AGHT+IHAeQVTih220wDwDwuZDwTwvKPsNjxkcqrCwSYrrZ2XDCt5bV2PiUppGXUGRbDMgDTUIFDYQA==",
        "X-Received": "by 2002:a05:600c:630f:b0:442:d9f2:ded8 with SMTP id\n\t5b1f17b1804b1-45324882060mr10318085e9.15.1749605649984; \n\tTue, 10 Jun 2025 18:34:09 -0700 (PDT)",
        "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>",
        "To": "libcamera-devel@lists.libcamera.org",
        "Cc": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>",
        "Subject": "[PATCH 25/35] libcamera: shaders: Use highp not mediump for float\n\tprecision",
        "Date": "Wed, 11 Jun 2025 02:32:35 +0100",
        "Message-ID": "<20250611013245.133785-26-bryan.odonoghue@linaro.org>",
        "X-Mailer": "git-send-email 2.49.0",
        "In-Reply-To": "<20250611013245.133785-1-bryan.odonoghue@linaro.org>",
        "References": "<20250611013245.133785-1-bryan.odonoghue@linaro.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "libcamera-devel@lists.libcamera.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "<libcamera-devel.lists.libcamera.org>",
        "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>",
        "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>",
        "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>",
        "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>",
        "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>",
        "Errors-To": "libcamera-devel-bounces@lists.libcamera.org",
        "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"
    },
    "content": "We get better sample resolution with highp instead of mediump.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n include/libcamera/internal/shaders/RGB.frag             | 2 +-\n include/libcamera/internal/shaders/YUV_2_planes.frag    | 2 +-\n include/libcamera/internal/shaders/YUV_3_planes.frag    | 2 +-\n include/libcamera/internal/shaders/YUV_packed.frag      | 2 +-\n include/libcamera/internal/shaders/bayer_1x_packed.frag | 2 +-\n include/libcamera/internal/shaders/bayer_8.frag         | 2 +-\n 6 files changed, 6 insertions(+), 6 deletions(-)",
    "diff": "diff --git a/include/libcamera/internal/shaders/RGB.frag b/include/libcamera/internal/shaders/RGB.frag\nindex 4c374ac9..72439589 100644\n--- a/include/libcamera/internal/shaders/RGB.frag\n+++ b/include/libcamera/internal/shaders/RGB.frag\n@@ -6,7 +6,7 @@\n  */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/include/libcamera/internal/shaders/YUV_2_planes.frag b/include/libcamera/internal/shaders/YUV_2_planes.frag\nindex 1d5d1206..d286f117 100644\n--- a/include/libcamera/internal/shaders/YUV_2_planes.frag\n+++ b/include/libcamera/internal/shaders/YUV_2_planes.frag\n@@ -6,7 +6,7 @@\n  */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/include/libcamera/internal/shaders/YUV_3_planes.frag b/include/libcamera/internal/shaders/YUV_3_planes.frag\nindex 8f788e90..8e3e0b4a 100644\n--- a/include/libcamera/internal/shaders/YUV_3_planes.frag\n+++ b/include/libcamera/internal/shaders/YUV_3_planes.frag\n@@ -6,7 +6,7 @@\n  */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/include/libcamera/internal/shaders/YUV_packed.frag b/include/libcamera/internal/shaders/YUV_packed.frag\nindex b9ef9d41..3c9e3e39 100644\n--- a/include/libcamera/internal/shaders/YUV_packed.frag\n+++ b/include/libcamera/internal/shaders/YUV_packed.frag\n@@ -6,7 +6,7 @@\n  */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n varying vec2 textureOut;\ndiff --git a/include/libcamera/internal/shaders/bayer_1x_packed.frag b/include/libcamera/internal/shaders/bayer_1x_packed.frag\nindex f53f5575..19b13ad0 100644\n--- a/include/libcamera/internal/shaders/bayer_1x_packed.frag\n+++ b/include/libcamera/internal/shaders/bayer_1x_packed.frag\n@@ -20,7 +20,7 @@\n  */\n \n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n /*\ndiff --git a/include/libcamera/internal/shaders/bayer_8.frag b/include/libcamera/internal/shaders/bayer_8.frag\nindex 7e35ca88..aa7a1b00 100644\n--- a/include/libcamera/internal/shaders/bayer_8.frag\n+++ b/include/libcamera/internal/shaders/bayer_8.frag\n@@ -16,7 +16,7 @@ Copyright (C) 2021, Linaro\n \n //Pixel Shader\n #ifdef GL_ES\n-precision mediump float;\n+precision highp float;\n #endif\n \n /** Monochrome RGBA or GL_LUMINANCE Bayer encoded texture.*/\n",
    "prefixes": [
        "25/35"
    ]
}