Patch Detail
Show a patch.
GET /api/patches/23530/?format=api
{ "id": 23530, "url": "https://patchwork.libcamera.org/api/patches/23530/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23530/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250611013245.133785-25-bryan.odonoghue@linaro.org>", "date": "2025-06-11T01:32:34", "name": "[24/35] libcamera: software_isp: debayer_egl: Make DebayerEGL an environment option", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "bb96e51b2b0e665a524530259915d457800d7e79", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23530/mbox/", "series": [ { "id": 5212, "url": "https://patchwork.libcamera.org/api/series/5212/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5212", "date": "2025-06-11T01:32:10", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5212/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23530/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23530/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 29B55C332F\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 11 Jun 2025 01:34:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C976868DED;\n\tWed, 11 Jun 2025 03:34:11 +0200 (CEST)", "from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com\n\t[IPv6:2a00:1450:4864:20::42b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0AE6F68DE6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 11 Jun 2025 03:34:08 +0200 (CEST)", "by mail-wr1-x42b.google.com with SMTP id\n\tffacd0b85a97d-3a54690d369so2526618f8f.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 Jun 2025 18:34:08 -0700 (PDT)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4532514138asm5680625e9.3.2025.06.10.18.34.05\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 10 Jun 2025 18:34:06 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"lLudW9Dz\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1749605647; x=1750210447;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=nN7QQs29c7ZiuR6fFmq8f7fL7inu3gEud9GNwcrxGBU=;\n\tb=lLudW9DzfhvKX9v9Bqg7UJ0wg0ekrtzm25FaTy9uTaGS7cTTI9RnFcUTXzwEGgoLzH\n\t+NTGAe1vW3mRHf/ffth5Z6mKKxU/qj3OXdRBlzIs40WxATEKQHqkSUyAleOmlqJiGfGr\n\tZChV06ljma7wDrk8IQO9F+y/VO7511Jl/aPMDCelFhzM0KNFxyL6MlLFB3fq6ZaPH5lE\n\terRNzMau8DR3thB6xnILl9QyhSMJLB2fCfYKvf9lWk2oUPyKHQtnelp54GDtLl1pnjUD\n\tn6J4MsTRavNpvQckMo2TTZWnOZb1MYhKyyiYxGtOiZecgsw7G6fkZUP7dPmjiCxkI1IB\n\tl9Gg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1749605647; x=1750210447;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=nN7QQs29c7ZiuR6fFmq8f7fL7inu3gEud9GNwcrxGBU=;\n\tb=uXC5yU40SiN9EPs5onMedTrT3cVyw6W3rhtoXR3ArFH7Cew1lL+q9vuvrHN77UJVF7\n\teVLjgklkDgo48zENXXJN8AXNptcSkzlmzkd0GCEaIbaziFsUBI5rkFSzbN55zI1hKjGU\n\tXdiYO27ys/UaA0hH+Q0wByAfZG5XmzKGuE/PRLxqEr4KsWR8Qip6U9sMGocCRRa8xydb\n\tDDgXOUkpOtYvde5RT5+HBX0/uEUPVZ0fOBBBgl3AR6EAzp7a313SOIdG5Gohz7+cU5oj\n\tvV4m7OoCJpLPXd+HvWun87OlXQQ2bP2aum9fOWKX0A1GraGKdrevFvN9nBxm4o6rme3Z\n\tR0cA==", "X-Gm-Message-State": "AOJu0YwT2YTQ0c3S6OWtJrNjfCusGND4Ly/+dpGrkYFj9Jc0uTCVPDZF\n\t/d7Ci2uZY2TjYYtd8VeXqAyI6Gf/YGNGV1c5LV0cBHIAjKlam9j+S20FGi8Mnz2ebtXbE4smTMj\n\tXkDPKQMI=", "X-Gm-Gg": "ASbGnctS4sitFH27HI+f1icRg+BnjyogIhhml6ubMIfX869maGfcAKjpEdBKeXwCrZy\n\tWKruGS96YuMoZStVkdIwqt466Glx8Cnzm055I/8vK3Wumn+3imCuMCy7897rVpdBWkxxBfoQnEF\n\tnhHLEMfcqBel6oe73Tr+KM8IbrZj+7ElDWsZyolb0vzjycfaXvzzIVf0wuyNv2ulqdNVludjUo3\n\tZVH+AqUB0QT1qEk6yj2RfJNJdirNbrn23dd0AJk5wCco9ll64MKTuDA6M4/yOxl4wpw47l3iaf2\n\tudYt41+M2IvqFclon4qeDvHOWyLSxfclr3J5ymxi0gdi0tzlS/0QlkhuiIj22fi6SEM22IMlzWs\n\tWbl/Byqsx0GnlumPoJB8c4KJYyHOjkUnf8pbJngTlBykNiV2HK9eu", "X-Google-Smtp-Source": "AGHT+IG7txomHBd4bLRRUyKtkH+QlcXafsKUElr9vUw1lgKNjvJlhLMqfOsLDPbd0zEwq5Dz5UNZnQ==", "X-Received": "by 2002:a05:6000:144f:b0:3a5:1471:d89b with SMTP id\n\tffacd0b85a97d-3a558a426c7mr854224f8f.53.1749605647406; \n\tTue, 10 Jun 2025 18:34:07 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "Subject": "[PATCH 24/35] libcamera: software_isp: debayer_egl: Make DebayerEGL\n\tan environment option", "Date": "Wed, 11 Jun 2025 02:32:34 +0100", "Message-ID": "<20250611013245.133785-25-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250611013245.133785-1-bryan.odonoghue@linaro.org>", "References": "<20250611013245.133785-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "If GPUISP support is available make it so an environment variable can\nswitch it on.\n\nGiven we don't have full feature parity with CPUISP just yet on pixel\nformat output, we should default to CPUISP mode giving the user the option\nto switch on GPUISP by setting LIBCAMERA_SOFTISP_MODE=gpu\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/software_isp.cpp | 19 ++++++++++++++++++-\n 1 file changed, 18 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex e8fa8a17..ff4471c0 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -15,6 +15,7 @@\n \n #include <libcamera/base/log.h>\n #include <libcamera/base/thread.h>\n+#include <libcamera/base/utils.h>\n \n #include <libcamera/controls.h>\n #include <libcamera/formats.h>\n@@ -25,6 +26,9 @@\n #include \"libcamera/internal/software_isp/debayer_params.h\"\n \n #include \"debayer_cpu.h\"\n+#if HAVE_DEBAYER_EGL\n+#include \"debayer_egl.h\"\n+#endif\n \n /**\n * \\file software_isp.cpp\n@@ -114,7 +118,20 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t}\n \tstats->statsReady.connect(this, &SoftwareIsp::statsReady);\n \n-\tdebayer_ = std::make_unique<DebayerCpu>(std::move(stats));\n+#if HAVE_DEBAYER_EGL\n+\tconst char *softISPMode = utils::secure_getenv(\"LIBCAMERA_SOFTISP_MODE\");\n+\n+\tif (softISPMode && !strcmp(softISPMode, \"gpu\"))\n+\t\tdebayer_ = std::make_unique<DebayerEGL>(std::move(stats));\n+#endif\n+\tif (!debayer_)\n+\t\tdebayer_ = std::make_unique<DebayerCpu>(std::move(stats));\n+\n+\tif (!debayer_) {\n+\t\tLOG(SoftwareIsp, Error) << \"Failed to create Debayer object\";\n+\t\treturn;\n+\t}\n+\n \tdebayer_->inputBufferReady.connect(this, &SoftwareIsp::inputReady);\n \tdebayer_->outputBufferReady.connect(this, &SoftwareIsp::outputReady);\n \n", "prefixes": [ "24/35" ] }