Patch Detail
Show a patch.
GET /api/patches/23518/?format=api
{ "id": 23518, "url": "https://patchwork.libcamera.org/api/patches/23518/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23518/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250611013245.133785-13-bryan.odonoghue@linaro.org>", "date": "2025-06-11T01:32:22", "name": "[12/35] libcamera: software_isp: Start the ISP thread in configure", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "1578d8bb23a077b2af27ae5277ba772b5d83063c", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23518/mbox/", "series": [ { "id": 5212, "url": "https://patchwork.libcamera.org/api/series/5212/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5212", "date": "2025-06-11T01:32:10", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5212/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23518/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23518/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AE7EEC3328\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 11 Jun 2025 01:33:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2276568DD1;\n\tWed, 11 Jun 2025 03:33:39 +0200 (CEST)", "from mail-wm1-x330.google.com (mail-wm1-x330.google.com\n\t[IPv6:2a00:1450:4864:20::330])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D991E68DD7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 11 Jun 2025 03:33:35 +0200 (CEST)", "by mail-wm1-x330.google.com with SMTP id\n\t5b1f17b1804b1-4508287895dso2307325e9.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 Jun 2025 18:33:35 -0700 (PDT)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4532514138asm5680625e9.3.2025.06.10.18.33.32\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 10 Jun 2025 18:33:34 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"Yaii2vC0\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1749605615; x=1750210415;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=wJmpJgXrFEG5KEN1zSnXvlqRixc3EGKyYYkVA8Fbs4k=;\n\tb=Yaii2vC0X+c9Nj1ZS3kyd2tljheXQL+05HgXcw9hirnFOvC2YjRIsfOzGU6fiLYAVW\n\tHRffkgNEbZklt1ZKTEQ3EEufNn72uOZdV+Ou+rum/03TsYElNuO/z7HA4JvjvG8rxF/y\n\tU78i7mVQPK7Fow9NbC97k2eIydD0GjKSNEkA5m4e+PZ2KG1xNPLm3rLw3agtayAL3Mo4\n\tbBbxdIeIEk1D9vABn2SHBqdoA8GYgGehoc5Lr4Wi5XbZCctX61BvWKeTkxy3+iPE1WpI\n\tfj02dCSI1PHd6gcxW+3QI7SuWJrR2t1c0ccrP+G0bD+W+nMWrfj4bdn+tXq2yFkekVIo\n\thpXA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1749605615; x=1750210415;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=wJmpJgXrFEG5KEN1zSnXvlqRixc3EGKyYYkVA8Fbs4k=;\n\tb=mlZeO3ECSBI6O/KVKl9myZrWjI82xM6VuWflHn1ucuGc+pKZhoNt+mgM13iFKLztkg\n\t60j6c1oFm/VrS0KBfFMgMdmxp7OdL6PX/Itg+Ut63sCwa5HFK1wdzt5Bv+LLqEoO34+b\n\tjKbUFj3sioSIv7HixqNryfaZfG7fSvegZor6cnjl84Ymt54W9wANIyxH2wOIEn4ZVumK\n\tHWZTIAsFALrmmhukddoYbh8TKFnuW21lljpM571cbwuiCRsFtoTGnR56qie9zlbtzEHF\n\twvFkg4C0k13r9flA0fTYrPe0A/O/SyxkdplQrkPMDtdSu1uYAeUivjRdtkujxxjQTpwP\n\tQE1g==", "X-Gm-Message-State": "AOJu0YzIh5YaoD3JeqHn/Zd2qLe32JWxjU2/nBjj5DPj6en2rG6foJ6p\n\tvt+qZ6WkyrlXDVArV8pxqv8psJr76yvVOSa49OhzqfUHhhF76n/dVyhybH1O950IAcu6yj5lUio\n\tZ3SHa7R0=", "X-Gm-Gg": "ASbGnctB9ZdAtXCV+QHMf0vd/aKcbw+DVqChAzGcQa4saSrDalXYwZAQtFXNrv2n83s\n\tGxxin+JJxryBtVSTk2/0aHu6Hlrnh0UXWbAuZSu0Zlg6WOGQsWbX8JlqOrDiU9ADJk76ceRgC3I\n\tL64vUQPO9RnkahkFwZD+4IsJmyf4r8Uc5ICCKJS21HTiO5fRDQNXYsOlGmno1IuvjUCuH8utQHf\n\tr8dQ6bZA4ABL5o8eBZ82MHTcOKaredQWEOLpWod5wAmb3rqo2OD04fnc+5cbeWoYED8wYiRODjA\n\tdqNosGMtseuudh3jTXLULMEaFjWR2rxmarXBtPv1tXUPuf5JirzDYLvgrO4ErUrwrCMh+QCHx7p\n\ty4BZbHSrdjzmeZhhxvTO3omEQs7pW/+3btKgX/DP00w==", "X-Google-Smtp-Source": "AGHT+IFX33Ge+A79gy1L3x3sARL5/59K/DSecbNM4W/0WwlBDjTHvkWhoHdPaZHXe9qQWTrCSyknUg==", "X-Received": "by 2002:a05:600c:1d0a:b0:44a:b468:87b1 with SMTP id\n\t5b1f17b1804b1-453240bf6d3mr12061455e9.4.1749605615215; \n\tTue, 10 Jun 2025 18:33:35 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "Subject": "[PATCH 12/35] libcamera: software_isp: Start the ISP thread in\n\tconfigure", "Date": "Wed, 11 Jun 2025 02:32:22 +0100", "Message-ID": "<20250611013245.133785-13-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250611013245.133785-1-bryan.odonoghue@linaro.org>", "References": "<20250611013245.133785-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "OpenGL is not thread-safe and in fact associates invisible handles with the\nthreadid of the calling context.\n\nAs a result we need to make configure() and process() in SoftISP execute on\nthe same thread.\n\nMove start thread into configure() as a first step towards this.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/software_isp.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex 28e2a360..7bee8f06 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -159,8 +159,6 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t\t\t\t\t metadataReady.emit(frame, metadata);\n \t\t\t\t });\n \tipa_->setSensorControls.connect(this, &SoftwareIsp::setSensorCtrls);\n-\n-\tdebayer_->moveToThread(&ispWorkerThread_);\n }\n \n SoftwareIsp::~SoftwareIsp()\n@@ -262,6 +260,9 @@ int SoftwareIsp::configure(const StreamConfiguration &inputCfg,\n \tif (ret < 0)\n \t\treturn ret;\n \n+\tdebayer_->moveToThread(&ispWorkerThread_);\n+\tispWorkerThread_.start();\n+\n \treturn debayer_->configure(inputCfg, outputCfgs, ccmEnabled_);\n }\n \n@@ -343,7 +344,6 @@ int SoftwareIsp::start()\n \tif (ret)\n \t\treturn ret;\n \n-\tispWorkerThread_.start();\n \treturn 0;\n }\n \n", "prefixes": [ "12/35" ] }