Patch Detail
Show a patch.
GET /api/patches/23508/?format=api
{ "id": 23508, "url": "https://patchwork.libcamera.org/api/patches/23508/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23508/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250611013245.133785-3-bryan.odonoghue@linaro.org>", "date": "2025-06-11T01:32:12", "name": "[02/35] libcamera: swstats_cpu: Drop patternSize_ documentation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "59741e75c523b0031de9169f512623c1b3987ba1", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23508/mbox/", "series": [ { "id": 5212, "url": "https://patchwork.libcamera.org/api/series/5212/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5212", "date": "2025-06-11T01:32:10", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5212/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23508/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23508/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 79DD4BDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 11 Jun 2025 01:33:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E2D1568DC4;\n\tWed, 11 Jun 2025 03:33:04 +0200 (CEST)", "from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com\n\t[IPv6:2a00:1450:4864:20::32d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E002368DC1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 11 Jun 2025 03:33:03 +0200 (CEST)", "by mail-wm1-x32d.google.com with SMTP id\n\t5b1f17b1804b1-442f9043f56so35111155e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 Jun 2025 18:33:03 -0700 (PDT)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4532514138asm5680625e9.3.2025.06.10.18.32.58\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 10 Jun 2025 18:33:02 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"tiE1OPAx\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1749605583; x=1750210383;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=smZwtpbTz29j4hcPfA9P6oUHmTi9LVToPOlGCRTmB7Y=;\n\tb=tiE1OPAxuUH0PcJP+w6lNKSKzysS5pzNZ6zMftNgKoNwOUHGTWlXpsrhFGES6UKnPa\n\tJpIqv5hEj59NRN7I2caQJ23KeBq87VVuBHkGNE4qV1mFv7BhvJeXJEcXIdxbH6n/9e8P\n\te/Sc8J28v/2sJZwKGEUlUHhim/TzBymGsT3z///2V9AxBgEG7YikvZZTyFzCtn4kAXST\n\tmyIYt7See2XcDIHtiY8h5LhaGjdt669mgkebAo4qrA29YynepsPjc2Ta43iF1QfBtDfV\n\tZjIhLh4WqEQxxL00EI5bPNG3PfxandJx8viBoqSfv+nvyc5Tu0F6NOOMDXIfsMMhLepk\n\t2LQQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1749605583; x=1750210383;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=smZwtpbTz29j4hcPfA9P6oUHmTi9LVToPOlGCRTmB7Y=;\n\tb=AOtHL8CaL+X6t/Hh3hfYVWh2sxf8xOnFGeWUdnjC1KGbeFtBQIct7dmMq4sZoVPrDV\n\tncLsUFhrs2Q7MFdG4VKcI/288X4PNou+6h3yv+R6giy0XfMVJAsX7cnvEvcTKA5Oi7SP\n\t5rtecsE9f66GvQHPNzIkCIC6ypadyHWf0PuZu+Pb7hSasjKs1UJ7PnPi85vJJ80oYjaB\n\tEJxOUU2JVwHohed5BNVZn3Hkt52RBFuBZHZ8o2kctwSIsr53YsWPvwvuBZrc6bcKnQIQ\n\tP3CvAKBUWkbqpFuJiAm8hKO5/5e7PHSNvbMQaWSHlhfeVNwhYJVZ2UZpraEZ730wRx1I\n\twtng==", "X-Gm-Message-State": "AOJu0YxwNjB3dHeEVF0Da7do4XkKwLbtj2xRZsJYLahZE2U4S59vpljx\n\tw/Kzs07rFvIMdk8uOdlRBsGsnt3Y1foZaitmL16AxbGh3EMqlHylf1UXgzt9evQnAH+D0V18ZW2\n\tJcMGkQ5Y=", "X-Gm-Gg": "ASbGncshgeyTruTUbLg+xb0YuBxyj/L15BWhdAf/Bdw0kLYbxv+OKa/IhKTMtOkb+p0\n\t/RSYn1mjLOKnohEVrCZSHtQfu3uiwHxF1J3Oc+HhWCQhNSvVXrh1Qina39W8XSK79O8NvujySC8\n\tJmV4qY1YA0V3GK61DTnQltLlxLyaDpQHQBYjbHV+0WH2kI01HqYwe7p7/RYN5ets13fIgkg2gNv\n\tGMunrQvQIMnGhYcqfBPg0KV1nqfx+kHx89uSbwQKbLfNkeago5JP7GCyeUUfLHAq5y0CGCrbx4H\n\tfCP3IaeMxDROHEJY8PYjzmTgU3yFxs51rC209cJke10Cf8LL7F/juDP0jzNiX4yg07MMtNsAfWZ\n\t+26RVMLi+llmUUDqIH38gt1TPDp0DOr8vpSMBDai58Q==", "X-Google-Smtp-Source": "AGHT+IH+VgSDXGeT5oVvvQndVYrMYU3vpEC7jcxBca/+Y6iTCr5FVINIddpYAOHssZuYA28v/rFbbw==", "X-Received": "by 2002:a05:600c:a318:b0:44a:775d:b5e8 with SMTP id\n\t5b1f17b1804b1-45324abda5emr4300245e9.1.1749605583271; \n\tTue, 10 Jun 2025 18:33:03 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Hans de Goede <hdegoede@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tMilan Zamazal <mzamazal@redhat.com>,\n\tBryan O'Donoghue <bryan.odonoghue@linaro.org>", "Subject": "[PATCH 02/35] libcamera: swstats_cpu: Drop patternSize_\n\tdocumentation", "Date": "Wed, 11 Jun 2025 02:32:12 +0100", "Message-ID": "<20250611013245.133785-3-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250611013245.133785-1-bryan.odonoghue@linaro.org>", "References": "<20250611013245.133785-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Hans de Goede <hdegoede@redhat.com>\n\npatternSize_ is a private variable and its meaning is already documented\nin the patternSize() getter documentation.\n\nMove the list of valid sizes to the patternSize() getter documentation\nand drop the patternSize_ documentation.\n\nWhile at it also add 1x1 as valid size for use with future support\nof single plane non Bayer input data.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Hans de Goede <hdegoede@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/swstats_cpu.cpp | 9 ++-------\n 1 file changed, 2 insertions(+), 7 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\nindex a9a3e77a..5e4246a9 100644\n--- a/src/libcamera/software_isp/swstats_cpu.cpp\n+++ b/src/libcamera/software_isp/swstats_cpu.cpp\n@@ -58,6 +58,8 @@ namespace libcamera {\n * also indicates if processLine2() should be called or not.\n * This may only be called after a successful configure() call.\n *\n+ * Valid sizes are: 1x1, 2x2, 4x2 or 4x4.\n+ *\n * \\return The pattern size\n */\n \n@@ -112,13 +114,6 @@ namespace libcamera {\n * \\brief Statistics window, set by setWindow(), used every line\n */\n \n-/**\n- * \\var Size SwStatsCpu::patternSize_\n- * \\brief The size of the bayer pattern\n- *\n- * Valid sizes are: 2x2, 4x2 or 4x4.\n- */\n-\n /**\n * \\var unsigned int SwStatsCpu::xShift_\n * \\brief The offset of x, applied to window_.x for bayer variants\n", "prefixes": [ "02/35" ] }