Patch Detail
Show a patch.
GET /api/patches/23507/?format=api
{ "id": 23507, "url": "https://patchwork.libcamera.org/api/patches/23507/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23507/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250611013245.133785-2-bryan.odonoghue@linaro.org>", "date": "2025-06-11T01:32:11", "name": "[01/35] libcamera: swstats_cpu: Update statsProcessFn() / processLine0() documentation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "c0b0044db5a2947d522938c71bb1d10b3806dc1d", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23507/mbox/", "series": [ { "id": 5212, "url": "https://patchwork.libcamera.org/api/series/5212/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5212", "date": "2025-06-11T01:32:10", "name": "Add GLES 2.0 GPUISP to libcamera", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5212/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23507/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23507/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D563CC3240\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 11 Jun 2025 01:33:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 58D1268DB4;\n\tWed, 11 Jun 2025 03:33:01 +0200 (CEST)", "from mail-wr1-x42c.google.com (mail-wr1-x42c.google.com\n\t[IPv6:2a00:1450:4864:20::42c])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E4FF668DB2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 11 Jun 2025 03:32:58 +0200 (CEST)", "by mail-wr1-x42c.google.com with SMTP id\n\tffacd0b85a97d-3a507e88b0aso5459926f8f.1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 10 Jun 2025 18:32:58 -0700 (PDT)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-4532514138asm5680625e9.3.2025.06.10.18.32.54\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 10 Jun 2025 18:32:57 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"DxItX6e+\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1749605578; x=1750210378;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=81Ng/LIxFB09YHT8LrVidJKxmT29lxMXyQw7vM5fRDM=;\n\tb=DxItX6e+kr2d2hyJLwSE2C7xca5sR6dPTJpYzIobkwghYUx0UC1JA8XZx+X4GA8ekw\n\te6BvI3mRKa1aOMODepDSoa7wJY/Jx/guHSKDfHehlIzbx7ox5dbLmoR16+znyh0qbMcG\n\tfirtKu/gjnxn3UnerD7wG1Ed5ffJ1532o8Z3CqhrSPtTVr289Uwep8ZY/R2B4vc8ung1\n\tmH2N2XsXWnGZXpYrLMQkeXyBoIRqt/Ai8AcSYV4786OJCiAO7YYQcN1OeAqHDlG/XyFT\n\t6904+/xtnorf+l27d0OW9ST1LAGztePhH2lUr0HLfFpVqu2hAETam9wKqrhFSX5u805r\n\tKYVg==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1749605578; x=1750210378;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=81Ng/LIxFB09YHT8LrVidJKxmT29lxMXyQw7vM5fRDM=;\n\tb=n5SneyPus/9wDiGnFtX1ah+hU+08sz3cQY3peY2dQhZ0GEEpMo8VhT+j8gAtqkGrMU\n\tbxqkGqucMdCLKjj9swEoQriqGGjDcarO2bLHQGwk44J0HNp5BcMDQxUA88WNAEE9NaJd\n\ti0i8tPH6ZdQJW3EvESHBajzUkTa9EO3Xcosa/unMXj4gnbgeUXzEY4+TBQ5T/JLIOPwE\n\tbWDzxasNpMJSpLjW22ARzYpmxDrJ90cDmq7DjQ4WhMz8tKuXjwlxoXQfu7I88YSIRIcH\n\tB29jw9hBK2V2061wgtSbh5z5gxjeaKRyTmRHm7WwdbGOwtvf1yqBdFiKPWRhOMYV0p97\n\t5EVQ==", "X-Gm-Message-State": "AOJu0YxNb89dGdkz3eJZzvuG2bZMlIZS/f75VKfZ8l6OO8nSCLsNKF6+\n\tVypPWFNzpq6xWhpPraW6N88YBn2FKgOmnIABAscWKxqp4Ry5ID8sLmagtleQzcZr8i9MBIC8r0H\n\tDhgP31Ho=", "X-Gm-Gg": "ASbGncvVhqhIWyiMbqjNeyuLb1impkBNg1HNca17nNRN/c4irY/v0cEhMjvu5mqPcaR\n\tk9Qef8anHmO1lSINgmLAKd7v8Od2m1bDiNTGqg+7FzHH8i11HqPP1cvXCp83yJQewYwupvNO5L8\n\t3WkZMb+kmZMcUXODGDWHYyYlXleslQHi+/RBb7m4jQYqHaPGiTGQXM1b3E/yLLaIdsrTyxL+zOf\n\t9pJXgFuW8ZJNNf0QL9zy69gsqrDkOmF+jup4laBvcOYPVBkITePdpn4+dU7IThNJss6afkIMyza\n\t2Z3cP4+oZnRg+KIMDZtFXqYIS5+eyWVi86QaSKPRpfZ5CZ5U5fUAoOWHh7kBk5BKI+Rbe5enHKu\n\tNDWUWCy68kziowqA7aaM6l08jEcdscLcXFVANhi+XRQ==", "X-Google-Smtp-Source": "AGHT+IHhXOpdsjY3UkRy751yLw8C9SSSiEEGYuX280Z7091lif4Za7c5nj07iA/r6OQfXSoutZs9qw==", "X-Received": "by 2002:a05:6000:2411:b0:3a4:eed7:15f2 with SMTP id\n\tffacd0b85a97d-3a558aec634mr656421f8f.43.1749605578273; \n\tTue, 10 Jun 2025 18:32:58 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Hans de Goede <hdegoede@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>,\n\tMilan Zamazal <mzamazal@redhat.com>,\n\tBryan O'Donoghue <bryan.odonoghue@linaro.org>", "Subject": "[PATCH 01/35] libcamera: swstats_cpu: Update statsProcessFn() /\n\tprocessLine0() documentation", "Date": "Wed, 11 Jun 2025 02:32:11 +0100", "Message-ID": "<20250611013245.133785-2-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250611013245.133785-1-bryan.odonoghue@linaro.org>", "References": "<20250611013245.133785-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Hans de Goede <hdegoede@redhat.com>\n\nUpdate the documentation of the statsProcessFn() / processLine0() src[]\npointer argument to take into account that swstats_cpu may also be used\nwith planar input data or with non Bayer single plane input data.\n\nThe statsProcessFn typedef is private, so no documentation is generated\nfor it. Move the new updated src[] pointer argument documentation to\nprocessLine0() so that it gets included in the generated docs.\n\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Milan Zamazal <mzamazal@redhat.com>\nSigned-off-by: Hans de Goede <hdegoede@redhat.com>\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/swstats_cpu.cpp | 27 +++++++++++-----------\n 1 file changed, 13 insertions(+), 14 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/swstats_cpu.cpp b/src/libcamera/software_isp/swstats_cpu.cpp\nindex c520c806..a9a3e77a 100644\n--- a/src/libcamera/software_isp/swstats_cpu.cpp\n+++ b/src/libcamera/software_isp/swstats_cpu.cpp\n@@ -71,6 +71,19 @@ namespace libcamera {\n * patternSize height == 1.\n * It'll process line 0 and 1 for input formats with patternSize height >= 2.\n * This function may only be called after a successful setWindow() call.\n+ *\n+ * This function takes an array of src pointers each pointing to a line in\n+ * the source image.\n+ *\n+ * Bayer input data requires (patternSize_.height + 1) src pointers, with\n+ * the middle element of the array pointing to the actual line being processed.\n+ * Earlier element(s) will point to the previous line(s) and later element(s)\n+ * to the next line(s). See the DebayerCpu::debayerFn documentation for details.\n+ *\n+ * Planar input data requires a src pointer for each plane, with src[0] pointing\n+ * to the line in plane 0, etc.\n+ *\n+ * For non Bayer single plane input data only a single src pointer is required.\n */\n \n /**\n@@ -89,20 +102,6 @@ namespace libcamera {\n * \\brief Signals that the statistics are ready\n */\n \n-/**\n- * \\typedef SwStatsCpu::statsProcessFn\n- * \\brief Called when there is data to get statistics from\n- * \\param[in] src The input data\n- *\n- * These functions take an array of (patternSize_.height + 1) src\n- * pointers each pointing to a line in the source image. The middle\n- * element of the array will point to the actual line being processed.\n- * Earlier element(s) will point to the previous line(s) and later\n- * element(s) to the next line(s).\n- *\n- * See the documentation of DebayerCpu::debayerFn for more details.\n- */\n-\n /**\n * \\var unsigned int SwStatsCpu::ySkipMask_\n * \\brief Skip lines where this bitmask is set in y\n", "prefixes": [ "01/35" ] }