Patch Detail
Show a patch.
GET /api/patches/23498/?format=api
{ "id": 23498, "url": "https://patchwork.libcamera.org/api/patches/23498/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23498/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250606164156.1442682-18-barnabas.pocze@ideasonboard.com>", "date": "2025-06-06T16:41:50", "name": "[RFC,v1,17/23,DNI] apps: cam: Use Camera::metadataAvailable signal", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "5cd5109caf0fe74e0fd227262552348e6441471a", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23498/mbox/", "series": [ { "id": 5210, "url": "https://patchwork.libcamera.org/api/series/5210/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5210", "date": "2025-06-06T16:41:33", "name": "libcamera: Add `MetadataList`", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5210/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23498/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23498/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 79026C3325\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 6 Jun 2025 16:42:50 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F358068DDB;\n\tFri, 6 Jun 2025 18:42:49 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BAC2B68DD1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Jun 2025 18:42:19 +0200 (CEST)", "from pb-laptop.local (185.182.215.79.nat.pool.zt.hu\n\t[185.182.215.79])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3AE068DB;\n\tFri, 6 Jun 2025 18:42:15 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"epNGjGQm\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1749228135;\n\tbh=lvSUfnI63UmjzaOOoai8j6Ns3gn4AujTEvGIQVxbfUg=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=epNGjGQm7DGKFkzaGvHZPh7dGhZEdfMhYFzvk2F/lIiOZymn0WthoL/JhQxFtUJ4b\n\tvUuW/dkFViyxPUv3wg5gWlNOk1FdrRvZF8e8iwbQ4PjTqUGdYh2D7i5iT6OUaCXASa\n\tHVUH/6s+Y45Zdp3jTun9BudSrbnCMSzTKsYrRJos=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Subject": "[RFC PATCH v1 17/23] [DNI] apps: cam: Use Camera::metadataAvailable\n\tsignal", "Date": "Fri, 6 Jun 2025 18:41:50 +0200", "Message-ID": "<20250606164156.1442682-18-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250606164156.1442682-1-barnabas.pocze@ideasonboard.com>", "References": "<20250606164156.1442682-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n\nHandle the Camera::metadataAvailable signal and print the metadata\nlist.\n\nUse the --metadata option of cam to validate that the metadata list\nin Request::metadata() matches the accumulated results.\n---\nOriginal: https://patchwork.libcamera.org/patch/22234/\n---\n src/apps/cam/camera_session.cpp | 11 +++++++++++\n 1 file changed, 11 insertions(+)", "diff": "diff --git a/src/apps/cam/camera_session.cpp b/src/apps/cam/camera_session.cpp\nindex f6894340b..e50b26a5a 100644\n--- a/src/apps/cam/camera_session.cpp\n+++ b/src/apps/cam/camera_session.cpp\n@@ -285,6 +285,17 @@ int CameraSession::start()\n \n \tcamera_->requestCompleted.connect(this, &CameraSession::requestComplete);\n \n+\tif (printMetadata_) {\n+\t\tcamera_->metadataAvailable.connect(this, [](Request *r, MetadataList::Diff update) {\n+\t\t\tstd::cout << \">> early metadata for \" << r->sequence() << \" with \" << update.size() << \" entries {\\n\";\n+\t\t\tfor (auto &&[tag, v] : update) {\n+\t\t\t\tconst auto *id = controls::controls.at(tag);\n+\t\t\t\tstd::cout << '\\t' << id->name() << \" = \" << v << '\\n';\n+\t\t\t}\n+\t\t\tstd::cout << \"}\" << std::endl;\n+\t\t});\n+\t}\n+\n #ifdef HAVE_KMS\n \tif (options_.isSet(OptDisplay))\n \t\tsink_ = std::make_unique<KMSSink>(options_[OptDisplay].toString());\n", "prefixes": [ "RFC", "v1", "17/23", "DNI" ] }