Patch Detail
Show a patch.
GET /api/patches/23491/?format=api
{ "id": 23491, "url": "https://patchwork.libcamera.org/api/patches/23491/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23491/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250606164156.1442682-11-barnabas.pocze@ideasonboard.com>", "date": "2025-06-06T16:41:43", "name": "[RFC,v1,10/23] libcamera: camera: Store `MetadataListPlan` in `Camera::Private`", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "fcfd80604704c61b6e1649df03f2eb68c63a9fd7", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23491/mbox/", "series": [ { "id": 5210, "url": "https://patchwork.libcamera.org/api/series/5210/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5210", "date": "2025-06-06T16:41:33", "name": "libcamera: Add `MetadataList`", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5210/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23491/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23491/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A4E24C31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 6 Jun 2025 16:42:42 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1027368DCA;\n\tFri, 6 Jun 2025 18:42:42 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AE02668DC9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Jun 2025 18:42:17 +0200 (CEST)", "from pb-laptop.local (185.182.215.79.nat.pool.zt.hu\n\t[185.182.215.79])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 34F9B11DD\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 6 Jun 2025 18:42:13 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HalIKhkm\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1749228133;\n\tbh=M1CNsryuizApYzNyJSEgga9OUl+tNty6V9mro8Qlmb8=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=HalIKhkmAyhAiZsryUT2alG/N+9G3ymo1RISnYj7jRsODK5pIKszIOWzsuU1AjsRn\n\ts3kaVOLgcZImzxWCaBrkBXhnXoOyaLqiduQTAsbJICK6i1YD4GC++P34SJqd+SUdpu\n\tJJHoU1Vw2fSLd2mjwXOhyEHTaLmZV8itk0QLxh/I=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 10/23] libcamera: camera: Store `MetadataListPlan` in\n\t`Camera::Private`", "Date": "Fri, 6 Jun 2025 18:41:43 +0200", "Message-ID": "<20250606164156.1442682-11-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250606164156.1442682-1-barnabas.pocze@ideasonboard.com>", "References": "<20250606164156.1442682-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Just like `ControlInfoMap controlInfo_` is a public member of the private\ncamera data for pipeline handlers to populate, add a `MetadataListPlan` as\nwell for the pipeline handlers to fill. This will be used to initialize\nthe `MetadataList` of each request created by the camera.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n include/libcamera/internal/camera.h | 3 +++\n src/libcamera/camera.cpp | 8 ++++++++\n 2 files changed, 11 insertions(+)", "diff": "diff --git a/include/libcamera/internal/camera.h b/include/libcamera/internal/camera.h\nindex 18f5c32a1..d5d869887 100644\n--- a/include/libcamera/internal/camera.h\n+++ b/include/libcamera/internal/camera.h\n@@ -17,6 +17,7 @@\n #include <libcamera/base/class.h>\n \n #include <libcamera/camera.h>\n+#include <libcamera/metadata_list_plan.h>\n \n namespace libcamera {\n \n@@ -41,6 +42,8 @@ public:\n \n \tuint32_t requestSequence_;\n \n+\tMetadataListPlan metadataPlan_;\n+\n \tconst CameraControlValidator *validator() const { return validator_.get(); }\n \n private:\ndiff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex c180a5fdd..31f5ad94b 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -660,6 +660,14 @@ Camera::Private::~Private()\n * over a single capture session.\n */\n \n+/**\n+ * \\var Camera::Private::metadataPlan_\n+ * \\brief The set of metadata supported by the camera\n+ *\n+ * The metadata information shall be initialised by the pipeline handler when\n+ * creating the camera.\n+ */\n+\n static const char *const camera_state_names[] = {\n \t\"Available\",\n \t\"Acquired\",\n", "prefixes": [ "RFC", "v1", "10/23" ] }