Patch Detail
Show a patch.
GET /api/patches/23460/?format=api
{ "id": 23460, "url": "https://patchwork.libcamera.org/api/patches/23460/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23460/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250603134535.772886-1-barnabas.pocze@ideasonboard.com>", "date": "2025-06-03T13:45:35", "name": "[v1] android: camera_device: Do not pass `nullptr` to `Request::addBuffer()`", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2efff93250c4475a19d43212d048d6495962a978", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23460/mbox/", "series": [ { "id": 5203, "url": "https://patchwork.libcamera.org/api/series/5203/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5203", "date": "2025-06-03T13:45:35", "name": "[v1] android: camera_device: Do not pass `nullptr` to `Request::addBuffer()`", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5203/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23460/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23460/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 28F4BC31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 3 Jun 2025 13:45:43 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0F6B268D94;\n\tTue, 3 Jun 2025 15:45:41 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 13E7C614D5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 3 Jun 2025 15:45:39 +0200 (CEST)", "from pb-laptop.local (185.182.214.140.nat.pool.zt.hu\n\t[185.182.214.140])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B3DCC496\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 3 Jun 2025 15:45:37 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tyVV8taf\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1748958337;\n\tbh=bnHxDRCYY4WXaXb704lsUKTFMjof2pGalEO1dOUClw8=;\n\th=From:To:Subject:Date:From;\n\tb=tyVV8tafpgx0eC1Q4f+zzwHphD/d1SJON/riWuVn6FJ7chiUv9Pm0cGr2gkdQqhFm\n\tCxo7DU3QGwqMBx08qkNPEFWnibvp+5/C6aZ2HMghn0l5ivLlQT9PfXhxSOsdYmWBfG\n\tEc6wrLgTNpmlm5M9jotcSPdWdPEiEw7JSu5q/yPI=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1] android: camera_device: Do not pass `nullptr` to\n\t`Request::addBuffer()`", "Date": "Tue, 3 Jun 2025 15:45:35 +0200", "Message-ID": "<20250603134535.772886-1-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The default argument already takes care of passing no fence to\n`addBuffer()`, so there is no reason to specify `nullptr` explicitly.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/android/camera_device.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex a038131ae..5dfa1fe22 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1078,8 +1078,7 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n \t\tFrameBuffer *frameBuffer = cameraStream->getBuffer();\n \t\tbuffer.internalBuffer = frameBuffer;\n \n-\t\tdescriptor->request_->addBuffer(sourceStream->stream(),\n-\t\t\t\t\t\tframeBuffer, nullptr);\n+\t\tdescriptor->request_->addBuffer(sourceStream->stream(), frameBuffer);\n \n \t\trequestedStreams.insert(sourceStream);\n \t}\n", "prefixes": [ "v1" ] }