Patch Detail
Show a patch.
GET /api/patches/23455/?format=api
{ "id": 23455, "url": "https://patchwork.libcamera.org/api/patches/23455/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23455/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250528121827.87844-2-niklas.soderlund@ragnatech.se>", "date": "2025-05-28T12:18:26", "name": "[1/2] ipu3: cio2: Remove unused function definition", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "42e531993af62ee9ec81fb1a75fc828673c0c525", "submitter": { "id": 5, "url": "https://patchwork.libcamera.org/api/people/5/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@ragnatech.se" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23455/mbox/", "series": [ { "id": 5199, "url": "https://patchwork.libcamera.org/api/series/5199/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5199", "date": "2025-05-28T12:18:25", "name": "Small fixes to ipu3 and pipeline-handler guide", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5199/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23455/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23455/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B0B79C31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 28 May 2025 12:20:12 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4111D68DA5;\n\tWed, 28 May 2025 14:20:12 +0200 (CEST)", "from fhigh-a7-smtp.messagingengine.com\n\t(fhigh-a7-smtp.messagingengine.com [103.168.172.158])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DEEE768DA2\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 28 May 2025 14:20:07 +0200 (CEST)", "from phl-compute-04.internal (phl-compute-04.phl.internal\n\t[10.202.2.44])\n\tby mailfhigh.phl.internal (Postfix) with ESMTP id 01636114016F;\n\tWed, 28 May 2025 08:20:07 -0400 (EDT)", "from phl-mailfrontend-02 ([10.202.2.163])\n\tby phl-compute-04.internal (MEProxy); Wed, 28 May 2025 08:20:07 -0400", "by mail.messagingengine.com (Postfix) with ESMTPA; Wed,\n\t28 May 2025 08:20:06 -0400 (EDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=ragnatech.se header.i=@ragnatech.se\n\theader.b=\"CXsXuDem\"; dkim=pass (2048-bit key;\n\tunprotected) header.d=messagingengine.com\n\theader.i=@messagingengine.com header.b=\"ifjagmMW\"; \n\tdkim-atps=neutral", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ragnatech.se; h=\n\tcc:cc:content-transfer-encoding:content-type:content-type:date\n\t:date:from:from:in-reply-to:in-reply-to:message-id:mime-version\n\t:references:reply-to:subject:subject:to:to; s=fm3; t=1748434806;\n\tx=1748521206; bh=13ZhceQI1geFvCNAAnBaf5QqLwzOrDDXFnjsCmUHP6c=; b=\n\tCXsXuDemLB/3fzO6ZQ9K1lvmelT3g31t2+O2efswGk5bIUD/z2ZqMSctM2L8CTCp\n\trIP1JlZyh9DRohxvRXip8sc3TGhEXzxiHPpK5NqNOz7jvTH8xRDfObfhWYs1w71Q\n\tw6AxiN43sBekhLWq0l3EiiO8L87hcReTT1jZ8NHE09S+wqw1+zz/gmrVI2+QVE30\n\tkHx+1JPmlP1f3GS71YXRaLvmEnNOP0wug5c0ZlMH+X0yAGi4qXyjb3LXw+s7XryK\n\tG1uvoLIwh4VCsVz+3oRuXS7XbMOQgLNhoIPun21ERHakpIllxyOUtDwEu4jrxueJ\n\t9YcNbc7qKspBBB/9XRbJ2w==", "v=1; a=rsa-sha256; c=relaxed/relaxed; d=\n\tmessagingengine.com; h=cc:cc:content-transfer-encoding\n\t:content-type:content-type:date:date:feedback-id:feedback-id\n\t:from:from:in-reply-to:in-reply-to:message-id:mime-version\n\t:references:reply-to:subject:subject:to:to:x-me-proxy\n\t:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1748434806; x=\n\t1748521206; bh=13ZhceQI1geFvCNAAnBaf5QqLwzOrDDXFnjsCmUHP6c=; b=i\n\tfjagmMWvTP6zm/aDyCOi/RhnZ27bA1Qa6AG3r+mug0bRnRs8sHlaeQ5pqlyoHl9+\n\tlwx1/ynqAR5TLTOeL61ahNcUcoPwz/xWYbXc2nCbzkTgU8LSF04T0ayFfr+npOHq\n\t9TMGsVhKhj8lLm79s0qTE08dzrTMWVuUlgN0tBuN1i4Ld2cCoJvCteCbTYb0gnyX\n\tXPE5Mei/jED2MRwIQSEjsLWlxPAk6Xdi7ZBTCykKf1KUO8m+hf8w1GtmYixVQMIX\n\tGmURgY8lWhP008X7Dzm4wSfLILGdgIYyNHZHZad+BqaqGVslV3eaQPLytGAvSbnA\n\t6ymOhElorlW9npHDHiYHA==" ], "X-ME-Sender": "<xms:dv82aK15_1PXWox6o0KWIDFZhoD17IlzdgZNJH4CDhFjJYxWIkV8pw>\n\t<xme:dv82aNFYisQCAqnZUN_Cb6IaGroyUJi0qmYPFM9h0jKx2oiGU6Vi2mOFG3rYx411g\n\tPYsVWFD1b9YIF4xl-M>", "X-ME-Received": "<xmr:dv82aC7vvxB-5b2DH5qzERcp3Bq_HUviTymf50mYSnUWVBHdK7uMaE5ICbz_wHBUicROmcvxm0a3_gD08etZGqbu0g>", "X-ME-Proxy-Cause": "gggruggvucftvghtrhhoucdtuddrgeeffedrtddtgddvfedvheculddtuddrgeefvddrtd\n\tdtmdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpggft\n\tfghnshhusghstghrihgsvgdpuffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftd\n\tdtnecunecujfgurhephffvvefufffkofgjfhggtgfgsehtkeertdertdejnecuhfhrohhm\n\tpefpihhklhgrshcuufpnuggvrhhluhhnugcuoehnihhklhgrshdrshhouggvrhhluhhnug\n\tesrhgrghhnrghtvggthhdrshgvqeenucggtffrrghtthgvrhhnpedtjeegkeeiudffhefh\n\tgedugeefueekkeffgeeltdeifeekheejveeifeffheevueenucevlhhushhtvghrufhiii\n\tgvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehnihhklhgrshdrshhouggvrhhluhhn\n\tugesrhgrghhnrghtvggthhdrshgvpdhnsggprhgtphhtthhopedvpdhmohguvgepshhmth\n\thpohhuthdprhgtphhtthhopehlihgstggrmhgvrhgrqdguvghvvghlsehlihhsthhsrdhl\n\tihgstggrmhgvrhgrrdhorhhgpdhrtghpthhtohepnhhikhhlrghsrdhsohguvghrlhhunh\n\tgusehrrghgnhgrthgvtghhrdhsvg", "X-ME-Proxy": "<xmx:dv82aL2W5zmfj7WSsgh9tlF4QYqw8rkAH24GMx1X5CNvCHmo_akQJg>\n\t<xmx:dv82aNHAiNHZULxlosCbni6GAF_m9Gnklon_rS99imI8ekGc84ViUw>\n\t<xmx:dv82aE97CJSKGczZMNA4cWWWhWYSJvRKp4a9X8YHaQcANWxJW7Avmg>\n\t<xmx:dv82aCkM10fOB_gWWUcpeRKXThNYJHEfr1l6kNtlWh5kaisDu-xD3A>\n\t<xmx:dv82aImtTjgP_VNkGY1LEo2b8qLSqe5ZJgWrYQGOkrLiNwoeKMhXKqCV>", "Feedback-ID": "i80c9496c:Fastmail", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@ragnatech.se>", "Subject": "[PATCH 1/2] ipu3: cio2: Remove unused function definition", "Date": "Wed, 28 May 2025 14:18:26 +0200", "Message-ID": "<20250528121827.87844-2-niklas.soderlund@ragnatech.se>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250528121827.87844-1-niklas.soderlund@ragnatech.se>", "References": "<20250528121827.87844-1-niklas.soderlund@ragnatech.se>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The private function cio2BufferReady is defined but not implemented or\nused, remove it for the class definition.\n\nSigned-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>\n---\n src/libcamera/pipeline/ipu3/cio2.h | 2 --\n 1 file changed, 2 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/ipu3/cio2.h b/src/libcamera/pipeline/ipu3/cio2.h\nindex 963c2f6b93a4..3aa3a1ca8ef8 100644\n--- a/src/libcamera/pipeline/ipu3/cio2.h\n+++ b/src/libcamera/pipeline/ipu3/cio2.h\n@@ -66,8 +66,6 @@ public:\n private:\n \tvoid freeBuffers();\n \n-\tvoid cio2BufferReady(FrameBuffer *buffer);\n-\n \tstd::unique_ptr<CameraSensor> sensor_;\n \tstd::unique_ptr<V4L2Subdevice> csi2_;\n \tstd::unique_ptr<V4L2VideoDevice> output_;\n", "prefixes": [ "1/2" ] }