Patch Detail
Show a patch.
GET /api/patches/23452/?format=api
{ "id": 23452, "url": "https://patchwork.libcamera.org/api/patches/23452/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23452/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250527155615.560463-2-julien.vuillaumier@nxp.com>", "date": "2025-05-27T15:56:14", "name": "[v4,1/2] libcamera: process: Use _exit in child process", "commit_ref": "32905fdd0b63a10886dc43bd8d0a0b2e843de47b", "pull_url": null, "state": "accepted", "archived": false, "hash": "673006a23bb0ce00453a1f694ffebb3277220b85", "submitter": { "id": 190, "url": "https://patchwork.libcamera.org/api/people/190/?format=api", "name": "Julien Vuillaumier", "email": "julien.vuillaumier@nxp.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23452/mbox/", "series": [ { "id": 5198, "url": "https://patchwork.libcamera.org/api/series/5198/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5198", "date": "2025-05-27T15:56:13", "name": "libcamera: process: Pass stderr and reserve stdin and stdout fds", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5198/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23452/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23452/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8884AC3237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 27 May 2025 15:57:13 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 340AF68DA2;\n\tTue, 27 May 2025 17:57:13 +0200 (CEST)", "from DB3PR0202CU003.outbound.protection.outlook.com\n\t(mail-northeuropeazlp170100001.outbound.protection.outlook.com\n\t[IPv6:2a01:111:f403:c200::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9C7D868D94\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 27 May 2025 17:57:11 +0200 (CEST)", "from AM9PR04MB8147.eurprd04.prod.outlook.com\n\t(2603:10a6:20b:3e0::22)\n\tby AS8PR04MB8499.eurprd04.prod.outlook.com (2603:10a6:20b:342::15)\n\twith Microsoft SMTP Server (version=TLS1_2,\n\tcipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8769.29;\n\tTue, 27 May 2025 15:57:10 +0000", "from AM9PR04MB8147.eurprd04.prod.outlook.com\n\t([fe80::eace:e980:28a4:ef8a]) by\n\tAM9PR04MB8147.eurprd04.prod.outlook.com\n\t([fe80::eace:e980:28a4:ef8a%7]) with mapi id 15.20.8722.027;\n\tTue, 27 May 2025 15:57:10 +0000" ], "Authentication-Results": [ "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=nxp.com header.i=@nxp.com header.b=\"bD5wvNTQ\";\n\tdkim-atps=neutral", "dkim=none (message not signed)\n\theader.d=none;dmarc=none action=none header.from=nxp.com;" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;\n\tb=xtT29qD7DgvS6nl2gCKT41DvlVsm8q+LBDch3Qxlc7TwA6+mTzqJEZ+FYMcPNvfcNi/7EFieVHQWN/qngq1NEdOeORNI3oQYQk526coPtUE6C6Iu9LGBu2+9C0dBykVzu782ZzR7qAYzi0l4Isr5ioJ4rokw51vYf44m6LFOP0fd+ojwpaJRE6V8GGxC6xw9WUlc673lnS1+GnqVshY7CGrnqKGacPHHQVKiXCQHHWtQ5/VU8fJTHsMNHRIENX6340Sjv9GIr7VHQ6gHuG8w0GVYmmb3Y8eme7Nukwx+jaIfxkvO6yaBQm+75s0pR9I3H5hUw3mvwvdKkgGS7jcDdw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n\ts=arcselector10001;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n\tbh=uZSRQKP/Ia3SbtUqnAtDmFazqnTd61C/dJBZY+380Cg=;\n\tb=FwsOk/5BxdYWO18aTQQWIRwNRycizdVwOafTAPXlzqzvuGWP+ZqBVBvO2ILz7XZneT0+82Mt8x4Z/0PONCdy61SMs3X7u6cOujVHYvr1/CBfQWXBjNA57Ni/5RkeTRfiUMEvRy8Gl1GH5p7skQd9k6wNpGE18j055bHkawzXHKNHCrkCRdu78MTc1+SVBgY4HZAftQsG3HADkehbRVbTQnwWy5bFG0Tz/Gkw5k8CgbmtLn5rzyHANFXRfSi/3PDjPO4kKQGiV9iVcl4hZjTU3Iui8Fo2S8ROi/FtiGsLv9DvlOMt7gK14HyXPcxRGNNpuhnCP2J70YXV6VVJAZyUrg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n\tsmtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com;\n\tdkim=pass header.d=nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1;\n\th=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n\tbh=uZSRQKP/Ia3SbtUqnAtDmFazqnTd61C/dJBZY+380Cg=;\n\tb=bD5wvNTQQb0zWRb1Jg3qDN36SexKNkxoU2Ox+q1rCeT/7eP3SGq93FySeppbCAnt0R1k9cxpj2YwatPSmHheWnDz1tSU+Jy+uYdHgazap7Sjw8ujst31ajdfa2yNNa3uz0XyeoyH5CTmA2iHIjmndHvxILphWCUur+L5XVPtBvwSrunnvP/c+6r5CvonnuqG5cWysNyj/5+Wsvshg7DwduzreyZ/rl+brfybiOYMTdwE8PDQp92o5PSyktnsguRQIJfmLMJm4Ub4/5b2uIOAIrDNmEJ9ajzYT1ooNL7SlvbF4aNg6d73TL8BA4pYAUN73uX3Wnu6ZIFCFrCRShnhoA==", "From": "Julien Vuillaumier <julien.vuillaumier@nxp.com>", "To": "libcamera-devel@lists.libcamera.org, barnabas.pocze@ideasonboard.com,\n\tpaul.elder@ideasonboard.com", "Cc": "Julien Vuillaumier <julien.vuillaumier@nxp.com>", "Subject": "[PATCH v4 1/2] libcamera: process: Use _exit in child process", "Date": "Tue, 27 May 2025 17:56:14 +0200", "Message-Id": "<20250527155615.560463-2-julien.vuillaumier@nxp.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20250527155615.560463-1-julien.vuillaumier@nxp.com>", "References": "<20250527155615.560463-1-julien.vuillaumier@nxp.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "AS4PR09CA0017.eurprd09.prod.outlook.com\n\t(2603:10a6:20b:5d4::11) To AM9PR04MB8147.eurprd04.prod.outlook.com\n\t(2603:10a6:20b:3e0::22)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "AM9PR04MB8147:EE_|AS8PR04MB8499:EE_", "X-MS-Office365-Filtering-Correlation-Id": "c1e9a4df-ea6c-4eab-3503-08dd9d3723b6", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;\n\tARA:13230040|1800799024|366016|376014|52116014|38350700014; ", "X-Microsoft-Antispam-Message-Info": "L/D+fCMGEz8nlXuqLY6Q1URa3Cjp0Xz9snaBGEJDRZRY3jiJ7rzHbdpOw5GkVcXdwSnOyD3o/t1FH4ijPMAu+WnStxFuESuw7SUXRdbTNzPJssc7Yn1e5vuL6PWUJ+Te7vr8qyAesc0lGjRH3xyYVElsZe0hAfBEW7j0KbLSoxB3ajaMyAcvv5qW9UL/cv1qH4pIq7wohEda65tBQnrkkhZUf3WSyq9PboC6Z4zVBU+0cG4QvT07ZB9rUb92KBNS6ICN/hf8eMqbt4S9pepxlj2HjIFAHs7N0+EE4mM72LCviYmMD92a3NVEh2SsRCo6uWK6l8FmIji8xKdqN3GR5+WYHTDv/0zWYdWkKHX+lUydKP/EO2uXQ0k8IuYlAOASY/BTqx6lerAXkSssfAvw7DbGdjumnqMWEmaCcMpBNWw0zj79T/cNTPCbybcqx2S8CH3Fnth56/a3IvAQXiF11Kxw1lh1clGUaUuEd7ppT8U6lW9JZGF1mA8959Zn9U04X/5NHgwpleutjRfJjccHGB/XAd6jkZb1Lo0qMQz/iIryxpbJGW955ZcEs84a0IEtEGsPbEGg1MhDvbwOKoWmE45dufhat5HqNiNAVvzYnA6SIBjNAs2BqroC7muNQ2r53CwStaJgSRSci2nXdByKbdJV6VR07sAwHptk/v2SQCYbpAmhOX6fQkC/xpAq30vCpV302+K6liEldfW4iZBMTBMV364p7AMt6y8T9kG1BHgPNkq/l12+q7rP19ZLWXSEfEIZ5+FIv6rO3E/Jh5XmX95XysDRc9AyBdA6rMdJ8SxRCTQh+erTwUuZb+S1I4jGdHhaYECoQ+u2z08rlsBDHmdUDA8BDPrcK9Nigx6wJU0/ZNXS3rW+3ay08dGP6ThxK/2YhsKV8QcH1bQX3FfkGgKFQjzgQGtXwpY+xOfsQIwcF+arX0d9q61RHsLcKVWXPvUOb4+ie0+qCn3flRmCgfbw87yV6gkbiKLyJmmWf58B3iJGO859ybOdXKMTA7pebOOJ+gBPdx+lrp00xd42927kBhZSLB1XCtv+SqXGGdjHTJX8HES5Domj6hTblG1bF1xRkPlT/8F2vOhC6F+AHkjqx7IdnNBkiFNEtnMVL7wN0CrNd/rrvIAHiFwDYUI3sJiire5t2L6dg/X3yIhKfMVgLtKfzNkLjFeCpU+DrTO5rOWg+MBlsa8aZS+RsSqcVbFwodaBumf/Tvevw74dz7/Rn9zqaAJkXVgui3h98bj1NLEgT7qi93Uot6GNeYh99eCmZnQmiwwfBSNZVlVgiRfwtgdIbyGa5+1QkLH6FSlXyDti/wGLRg0ckglWfzPElt19eQitgpgiIO1Lixb9qKxqNdusRn4i1x9wHDRIzIF3uT8bLZNJKdWeKS3cWye9pDdCZU6wEpLkU88vmKcCcuqdX1UswvvrMDi00fOX2Y0Ahm8YVC3AHN/yrkpIqnRIo/2UpFrS5B9rdaSMJhn85cByTxVemOZm5AuexUKj2Ag=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n\tIPV:NLI; SFV:NSPM; H:AM9PR04MB8147.eurprd04.prod.outlook.com; PTR:;\n\tCAT:NONE; \n\tSFS:(13230040)(1800799024)(366016)(376014)(52116014)(38350700014);\n\tDIR:OUT; SFP:1101; ", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "4fg5Q/z0Ifz5vmXmTcrkWH1UdZ/Qh2RXMhWPuDFj7k6V51GGwNVOjA7UUNVqCKE+Is7RPHvL5f2mej+bczT/MFzyN6INzPd/10dfDWKw82JFyFWWQ0m9imcYsBqWAqsDTGTXwL1vU5qY3NrZ4xtmDfr3Ft+hlAJIM0AbpqebFXn2UVXhHV12VYxTpnAuzN7ld1wy2OfybNl9yhAYrsj43PwLPHU3TfhayCOf7Fk8GRFj8ggWqe/+dh7LO6se7ifAkacpB2eNDYqMCLbqkCWXdXoXkLoXjeqEdkOBhH2URXVQVGKLg52SwcPNO0O+Rq+jHgkK6SplPx8QiGMcejlwKU5H2a7DzhK5XTiSWYLWzvNSrXIvMpN+JiyyoAOobUt8TG/vkPX0DTjBGtEEgqvAs68GEfSLtHmhdNIXxrTv5uhaHjB+KIE6K+kh0ljg25KjyI0uO3npVaeUbt5jy/qosm4fQNwVkBtBaCKaEnmg58fWTtFDGudHTPo5QHXKMauTjls85ulCQdOqQDM1BcYpOR68kq8JMbsf8PYk5gXR5V4usjjel3wSxvKLmIMPPhqQVuaDsaSco2kKl8VG8rkD6Epl65vh/mi35jrTu+tspRWbFYrX6F+1ofBQ2r/AN1H1EqZhGGqay1QLbEMa16g8rXKVwsH8gUPbX3GM1P6cqd14/OaGC8bKdFdbHbTNpZs0tKhH3zDzwsx2oB/V24Z2IuOSaKhLIUwh9jD6SszQ6dgN47o2B7EMDmOyJyJLdRrJGxOzX6ncT+4pjjEpEATwTkTYBvL6jxu0siIGvDI9N3hUPc+68vRB0+K/Rxvea44wZr77Tp4qijV0YIUMNAwD1GZy+tyICZgncCwZJXtsokK+fnrQkzWemfzvwtCrSwV/tHi0FUYEGwiP6A8Po5ZbimASp0/9UK7Qs/EK5zvCOPveSQ9rshq2fRJZl/WxEV2/L4G4HN5GgHDMvXJ5XM0if252iPinxkcTW1pSM6yHVRTX0LKh6BibxNq6YIxWNLusMXo0FyjstoemhtqKILwFz8fkJIbutp49I0EzWDx2tOydFQ40+m/g3D9MNP4nTliL7viyL0dniJ4UGk1we3jj/s2fhv8R4dqUeJGoPDDp6g+Ww14fIzVKa/UPGCJX0auQ34qaw9/Qh2SWQI6yT17b32jd9mwNfK07eywyhZGglDDrQUYOmsJYJ9D8EkbaQEClwa9RMXk/zn7QxpA5aKLiB9WEm49jlmRHVVG0n5Wq24zq/RFoFO6Xfd1Yy9Ai8Bm+r+ttQsP+vRme92Sg73fcobJ2MWRC+1bmZ01/oH0phmtX5uE3308XS5syncYgN0ZROmhyxcAAFI9jlCaYW0AJNCtaG87DQqDoomMg/7a+gRC8Uhukk9LgWJafDN/G+60vh0LGNTLvaHcer8OfeyicDZMyKHzKSknRebqBezL4/Ol0P3Il+qUCwbrvtQw/SfHg639AzfI2kEB/gnOHJQ+ynZ6OEzx/ldyD3VRCcyWuUEKRGHdxyF0t1oiKX6BreWM104rjhMFgGOyCS0/PgZ9HhbB97RuIEKsiaonnTIqD5NPLygP+zMRljQvLw/bqjSDZZfdDXeHwqAgMuadAvZokkQ==", "X-OriginatorOrg": "nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "c1e9a4df-ea6c-4eab-3503-08dd9d3723b6", "X-MS-Exchange-CrossTenant-AuthSource": "AM9PR04MB8147.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "27 May 2025 15:57:10.6300\n\t(UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "GEXZgS9w2X445e1V/ykbswNsDbPq4I71urZifSfPoU5Wk7j7heFFedYV7Cj936W8NKNJRAcpeJUjPNBKnFuIOzC0sPItY372ichBfzvZSqQ=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AS8PR04MB8499", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Use _exit() in child process in case of execv() error. That is to\navoid interfering with the parent process as exit() may call its\natexit() handlers and flush its io buffers.\n\nSigned-off-by: Julien Vuillaumier <julien.vuillaumier@nxp.com>\n---\n src/libcamera/process.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\nindex 68fad327..7f3a6518 100644\n--- a/src/libcamera/process.cpp\n+++ b/src/libcamera/process.cpp\n@@ -274,7 +274,7 @@ int Process::start(const std::string &path,\n \n \t\texecv(path.c_str(), (char **)argv);\n \n-\t\texit(EXIT_FAILURE);\n+\t\t_exit(EXIT_FAILURE);\n \t}\n }\n \n", "prefixes": [ "v4", "1/2" ] }