Patch Detail
Show a patch.
GET /api/patches/2345/?format=api
{ "id": 2345, "url": "https://patchwork.libcamera.org/api/patches/2345/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2345/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20191123083651.6944-1-laurent.pinchart@ideasonboard.com>", "date": "2019-11-23T08:36:51", "name": "[libcamera-devel] cam: options: Fix unitialized variable warning", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "2e5e483f91942f9effd25595e9284fa94ab6658f", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2345/mbox/", "series": [ { "id": 576, "url": "https://patchwork.libcamera.org/api/series/576/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=576", "date": "2019-11-23T08:36:51", "name": "[libcamera-devel] cam: options: Fix unitialized variable warning", "version": 1, "mbox": "https://patchwork.libcamera.org/series/576/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2345/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2345/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2CD036136B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 23 Nov 2019 09:37:15 +0100 (CET)", "from pendragon.ideasonboard.com (85-76-114-182-nat.elisa-mobile.fi\n\t[85.76.114.182])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7C7B1440\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat, 23 Nov 2019 09:37:11 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1574498234;\n\tbh=KEy3FO7jFnPElfCjogA9BOne/uHWiu5SZalWxbgzAIs=;\n\th=From:To:Subject:Date:From;\n\tb=iphVvYAeSBIY+kTqdw3feYigMo6yuFCzlykgXfEgiCXav5fh5e2lVhZQS+5+yvPNk\n\tstTxJ/X9Nsau344VMXTERD0L2zuQxhtVrOXP28nmIigyneCNFhcXe6ZC7qA1VIQvLP\n\tzWoZN9wJTVwoeJFjYwyE3jn9TglRRhzKq2q5K42o=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Sat, 23 Nov 2019 10:36:51 +0200", "Message-Id": "<20191123083651.6944-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.23.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] cam: options: Fix unitialized variable\n\twarning", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Sat, 23 Nov 2019 08:37:15 -0000" }, "content": "gcc 8 and 9 complain about the OptionValue::integer_ member being\npossibly used initialized when compiled in release mode. I haven't been\nable to find where this could be the case, and the compiler error\nmessage isn't helpful:\n\nIn file included from ../../src/cam/options.cpp:14:\n../../src/cam/options.h: In member function ‘bool OptionsBase<T>::parseValue(const T&, const Option&, const char*) [with T = std::__cxx11::basic_string<char>]’:\n../../src/cam/options.h:84:7: error: ‘<anonymous>.OptionValue::integer_’ may be used uninitialized in this function [-Werror=maybe-uninitialized]\n class OptionValue\n ^~~~~~~~~~~\n../../src/cam/options.h: In member function ‘bool OptionsBase<T>::parseValue(const T&, const Option&, const char*) [with T = int]’:\n../../src/cam/options.h:84:7: error: ‘<anonymous>.OptionValue::integer_’ may be used uninitialized in this function [-Werror=maybe-uninitialized]\n class OptionValue\n ^~~~~~~~~~~\n\nFurthermore valgrind doesn't report any issue. This is likely a false\npositive, but fix it nonetheless as the fix is cheap.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/cam/options.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/cam/options.cpp b/src/cam/options.cpp\nindex 7e2dfa636ccf..186e853c8294 100644\n--- a/src/cam/options.cpp\n+++ b/src/cam/options.cpp\n@@ -260,17 +260,17 @@ OptionValue::OptionValue(int value)\n }\n \n OptionValue::OptionValue(const char *value)\n-\t: type_(ValueString), string_(value)\n+\t: type_(ValueString), integer_(0), string_(value)\n {\n }\n \n OptionValue::OptionValue(const std::string &value)\n-\t: type_(ValueString), string_(value)\n+\t: type_(ValueString), integer_(0), string_(value)\n {\n }\n \n OptionValue::OptionValue(const KeyValueParser::Options &value)\n-\t: type_(ValueKeyValue), keyValues_(value)\n+\t: type_(ValueKeyValue), integer_(0), keyValues_(value)\n {\n }\n \n", "prefixes": [ "libcamera-devel" ] }