Patch Detail
Show a patch.
GET /api/patches/23448/?format=api
{ "id": 23448, "url": "https://patchwork.libcamera.org/api/patches/23448/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23448/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250526214224.13631-4-stefan.klug@ideasonboard.com>", "date": "2025-05-26T21:42:17", "name": "[RFC,3/4] pipeline: rkisp1: Limit the maximum number of buffers queued in", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "f7940f0594bb8fae2f53360170f3b7d621128567", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23448/mbox/", "series": [ { "id": 5196, "url": "https://patchwork.libcamera.org/api/series/5196/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5196", "date": "2025-05-26T21:42:14", "name": "rkisp1: Allow usage of more than 4 buffers", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5196/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23448/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23448/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 23BE6C31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 26 May 2025 21:42:49 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BAEF468DA7;\n\tMon, 26 May 2025 23:42:48 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0172468D93\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 26 May 2025 23:42:46 +0200 (CEST)", "from ideasonboard.com (tmo-070-11.customers.d1-online.com\n\t[80.187.70.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C6477581;\n\tMon, 26 May 2025 23:42:20 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"jElVEutD\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1748295741;\n\tbh=cad+Sh35Ee0cV8HU6tfRJab4K/W3dgBgRbeIF0D6n3g=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=jElVEutDN5luF+NsN16Ox03gIZPNJAN0lkVAJ3o0bWjLQ/ZfjJzQ7qB2pu3VU/CBe\n\tANyd2GY31UGatpJxNgyqAWOfflfmuip+0dZ32X3wwuuUjS1WPaMMTdMIV0sWvAcBIG\n\tyiC+jzqf8U0UDlkw1hcjrtVIDu+3OhGo4xy1nMNo=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[RFC PATCH 3/4] pipeline: rkisp1: Limit the maximum number of\n\tbuffers queued in", "Date": "Mon, 26 May 2025 23:42:17 +0200", "Message-ID": "<20250526214224.13631-4-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250526214224.13631-1-stefan.klug@ideasonboard.com>", "References": "<20250526214224.13631-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "To keep the regulation of the algorithms as short as possible and to\nallow more buffers to be created than the v4l2 device allows to be queued,\nlimit the amount of buffers that get queued into the device to the pipeline depth.\n\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 675f0a7490a6..af9117c83630 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -155,6 +155,12 @@ private:\n \tTransform combinedTransform_;\n };\n \n+namespace {\n+\n+const unsigned int kPipelineDepth = 4;\n+\n+};\n+\n class PipelineHandlerRkISP1 : public PipelineHandler\n {\n public:\n@@ -171,6 +177,7 @@ public:\n \tvoid stopDevice(Camera *camera) override;\n \n \tint queueRequestDevice(Camera *camera, Request *request) override;\n+\tunsigned int maxQueuedRequestsDevice() const override { return kPipelineDepth; }\n \n \tbool match(DeviceEnumerator *enumerator) override;\n \n", "prefixes": [ "RFC", "3/4" ] }