Patch Detail
Show a patch.
GET /api/patches/23444/?format=api
{ "id": 23444, "url": "https://patchwork.libcamera.org/api/patches/23444/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23444/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250526120355.2023227-1-barnabas.pocze@ideasonboard.com>", "date": "2025-05-26T12:03:55", "name": "[v1] Documentation: Fix `INCLUDE_PATH` doxygen configuration option", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "a77d0fad6f497df58531255da62b98ac7e16ad6c", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23444/mbox/", "series": [ { "id": 5195, "url": "https://patchwork.libcamera.org/api/series/5195/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5195", "date": "2025-05-26T12:03:55", "name": "[v1] Documentation: Fix `INCLUDE_PATH` doxygen configuration option", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5195/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23444/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23444/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 79C6DC3237\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 26 May 2025 12:04:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DA81168D9D;\n\tMon, 26 May 2025 14:03:59 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F556627DA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 26 May 2025 14:03:58 +0200 (CEST)", "from pb-laptop.local (185.221.141.78.nat.pool.zt.hu\n\t[185.221.141.78])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AA9A37E6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 26 May 2025 14:03:33 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Fdv41Wj2\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1748261013;\n\tbh=if7GbMLmKP73KFgIPUhCEHDOgt61VikEGK/byO92NsE=;\n\th=From:To:Subject:Date:From;\n\tb=Fdv41Wj2Ik9vCU6kbhVbnqqk2Jk4AciQq1s4hQbQCMARiF+bp9pkYixcYM8wm0uNs\n\t5pdP2YHrdZ2GZ9cx/h1CSU7JhcSExqIP8VmZxbqMuQT2JCFOPYlt6bmUV/Ywy7OTb7\n\tWbZmSi4YP4MXeknXSXEfz5i4runAeo1eSTunU/v4=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1] Documentation: Fix `INCLUDE_PATH` doxygen configuration\n\toption", "Date": "Mon, 26 May 2025 14:03:55 +0200", "Message-ID": "<20250526120355.2023227-1-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "libcamera header files should be included using the `libcamera/...` prefix.\nHowever, `INCLUDE_PATH` is currently set to `@TOP_SRCDIR@/include/libcamera`\nmeaning that doxygen, when encountering `libcamera/x.h`, will try to open\n`@TOP_SRCDIR@/include/libcamera/libcamera/x.h`, which is not the correct\npath.\n\nFix that by using `@TOP_{BUILD,SRC}DIR@/include`. This removes the extra\n`libcamera` component from the path and adds the corresponding directory\nfrom the build directory as well since that is an implicit include\ndirectory added by meson.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n Documentation/Doxyfile-common.in | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)", "diff": "diff --git a/Documentation/Doxyfile-common.in b/Documentation/Doxyfile-common.in\nindex 045c19dd6..58afea1cd 100644\n--- a/Documentation/Doxyfile-common.in\n+++ b/Documentation/Doxyfile-common.in\n@@ -57,7 +57,8 @@ GENERATE_LATEX = NO\n MACRO_EXPANSION = YES\n EXPAND_ONLY_PREDEF = YES\n \n-INCLUDE_PATH = \"@TOP_SRCDIR@/include/libcamera\"\n+INCLUDE_PATH = \"@TOP_BUILDDIR@/include\" \\\n+ \"@TOP_SRCDIR@/include\"\n INCLUDE_FILE_PATTERNS = *.h\n \n IMAGE_PATH = \"@TOP_SRCDIR@/Documentation/images\"\n", "prefixes": [ "v1" ] }