Patch Detail
Show a patch.
GET /api/patches/2343/?format=api
{ "id": 2343, "url": "https://patchwork.libcamera.org/api/patches/2343/?format=api", "web_url": "https://patchwork.libcamera.org/patch/2343/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20191121041913.16202-1-laurent.pinchart@ideasonboard.com>", "date": "2019-11-21T04:19:13", "name": "[libcamera-devel] meson: Really define _FORTIFY_SOURCE for optimised builds", "commit_ref": "a8d03129033080c4c42a3f44792b9f7db206e300", "pull_url": null, "state": "accepted", "archived": false, "hash": "738374348874b85fc901d38892f8687f44f16bca", "submitter": { "id": 2, "url": "https://patchwork.libcamera.org/api/people/2/?format=api", "name": "Laurent Pinchart", "email": "laurent.pinchart@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/2343/mbox/", "series": [ { "id": 574, "url": "https://patchwork.libcamera.org/api/series/574/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=574", "date": "2019-11-21T04:19:13", "name": "[libcamera-devel] meson: Really define _FORTIFY_SOURCE for optimised builds", "version": 1, "mbox": "https://patchwork.libcamera.org/series/574/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/2343/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/2343/checks/", "tags": {}, "headers": { "Return-Path": "<laurent.pinchart@ideasonboard.com>", "Received": [ "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 089436136C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 Nov 2019 05:19:27 +0100 (CET)", "from pendragon.mediatek.inc (unknown [124.219.31.93])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 69CFD97D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 21 Nov 2019 05:19:25 +0100 (CET)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1574309966;\n\tbh=hBOSNQUW7pzwMaYstQQM/a0gKQ2pSrY2tgCpDPaJCDg=;\n\th=From:To:Subject:Date:From;\n\tb=quXVCDMq964xNMpx74Hi5Zv2auq3uzgYUIR7nor6TW4otlJL7pdGpHgct4lqVRW7S\n\taEu0W7e8JEtKqKAeqQ+lvMLFtxeR2DG0NfBkSwZL3+Vc7FnBtlt0Ayk9klzJ/VuhBU\n\thevRTK0psaVKlAcDd+fo9bwFPTKrgena+fsmQsWM=", "From": "Laurent Pinchart <laurent.pinchart@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Date": "Thu, 21 Nov 2019 06:19:13 +0200", "Message-Id": "<20191121041913.16202-1-laurent.pinchart@ideasonboard.com>", "X-Mailer": "git-send-email 2.23.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[libcamera-devel] [PATCH] meson: Really define _FORTIFY_SOURCE for\n\toptimised builds", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "X-List-Received-Date": "Thu, 21 Nov 2019 04:19:27 -0000" }, "content": "Commit 965c5bf7fbf5 (\"meson: Define _FORTIFY_SOURCE for optimised\nbuilds\") tried to define _FORTIFY_SOURCE for optimised builds with\nclang, but updated the common_arguments after it was used. This resulted\nin the _FORTIFY_SOURCE option not being applied. Fix it.\n\nFixes: 965c5bf7fbf5 (\"meson: Define _FORTIFY_SOURCE for optimised builds\")\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n meson.build | 7 +++++--\n 1 file changed, 5 insertions(+), 2 deletions(-)", "diff": "diff --git a/meson.build b/meson.build\nindex 72ad7c8b493b..0a222ba96dcb 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -35,8 +35,8 @@ common_arguments = [\n '-include', 'config.h',\n ]\n \n-c_arguments = common_arguments\n-cpp_arguments = common_arguments\n+c_arguments = []\n+cpp_arguments = []\n \n if cc.get_id() == 'clang'\n # Turn _FORTIFY_SOURCE by default on optimised builds (as it requires -O1\n@@ -56,6 +56,9 @@ if cc.get_id() == 'clang'\n endif\n endif\n \n+c_arguments += common_arguments\n+cpp_arguments += common_arguments\n+\n add_project_arguments(c_arguments, language : 'c')\n add_project_arguments(cpp_arguments, language : 'cpp')\n add_project_link_arguments(cpp_arguments, language : 'cpp')\n", "prefixes": [ "libcamera-devel" ] }