Patch Detail
Show a patch.
GET /api/patches/23413/?format=api
{ "id": 23413, "url": "https://patchwork.libcamera.org/api/patches/23413/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23413/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250521-djrscally-c55-cleanup-v1-1-aa171b2aed38@ideasonboard.com>", "date": "2025-05-21T13:21:01", "name": "[1/2] libcamera/mali-c55: Remove tpgCodes_", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "011dd22689eeb17b9deefe93336af18df7986dfb", "submitter": { "id": 156, "url": "https://patchwork.libcamera.org/api/people/156/?format=api", "name": "Dan Scally", "email": "dan.scally@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23413/mbox/", "series": [ { "id": 5187, "url": "https://patchwork.libcamera.org/api/series/5187/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5187", "date": "2025-05-21T13:21:00", "name": "Mali-C55 Cleanup Patches", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5187/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23413/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23413/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8A961BD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 21 May 2025 13:21:36 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6C3E168D97;\n\tWed, 21 May 2025 15:21:34 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BCE0168D85\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 21 May 2025 15:21:30 +0200 (CEST)", "from [127.0.1.1]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3960F9E5;\n\tWed, 21 May 2025 15:21:09 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CNd0M4TK\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747833669;\n\tbh=iTMoWhQ1HTY+rynjybrVk6/R4TSeYAmMTbJcHmzyT2w=;\n\th=From:Date:Subject:References:In-Reply-To:To:Cc:From;\n\tb=CNd0M4TKfvEToZ3JQuIGsEDONU1Yra/dCht2+UAQZBQYk9SLlRm+vo3EyoclMuT5x\n\tlpmJpmOHZmshB/fIpgf2Z5gxPL4Zs4XiHSZthGfOyp0ROiO9hhII5xPJUyxM3igxL7\n\tK8YRFlX+DVkDrfkA0g45SsGJZdyYb5ee/4DcoWyA=", "From": "Daniel Scally <dan.scally@ideasonboard.com>", "Date": "Wed, 21 May 2025 14:21:01 +0100", "Subject": "[PATCH 1/2] libcamera/mali-c55: Remove tpgCodes_", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"utf-8\"", "Content-Transfer-Encoding": "7bit", "Message-Id": "<20250521-djrscally-c55-cleanup-v1-1-aa171b2aed38@ideasonboard.com>", "References": "<20250521-djrscally-c55-cleanup-v1-0-aa171b2aed38@ideasonboard.com>", "In-Reply-To": "<20250521-djrscally-c55-cleanup-v1-0-aa171b2aed38@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Daniel Scally <dan.scally@ideasonboard.com>", "X-Mailer": "b4 0.14.2", "X-Developer-Signature": "v=1; a=openpgp-sha256; l=1196;\n\ti=dan.scally@ideasonboard.com; h=from:subject:message-id;\n\tbh=iTMoWhQ1HTY+rynjybrVk6/R4TSeYAmMTbJcHmzyT2w=;\n\tb=owEBbQKS/ZANAwAKAchJV3psRXUyAcsmYgBoLdNYpQOybcc+uEh64PH0S0ZEofixS7kCoRdNp\n\tzWu/nZX4PKJAjMEAAEKAB0WIQQqyuwyDnZdb+mxmm/ISVd6bEV1MgUCaC3TWAAKCRDISVd6bEV1\n\tMsghEACj7GPYGVyH7ZivlRXb1ghKHRaEtydGg1nFPMe9fF9qVygHTzfXR0kkivpLmAwM7OOm1bS\n\tqMannCuXxPNBBGiM6u1FGLB7ZyKmDK8Fh3RRS3YVNM/fi8G122xDBhAmEkaIqzS7tajdLa0baoT\n\t4TJ5k3uVGSJhf1bKD05MCKh3AGGVvpRZ9Pq4uxGEzrMOjb9ceRWISIKQg3q3cESa1i1NTJWxh2F\n\tA77mWttLKROG2LxM8UQCCfJ38xRMKXH1rc9kr5fJ80JNd3bD70upFvWwlRBptwWF4JlWVX3z+Xy\n\tf6eC3duBFaQTse+T9fUSs2cAPtxY8GaSp45iQYh2ED0LsGPCstixQXDr1QXSoymoy0rWASow9hQ\n\tv4GQP60GajfpPg1H+sn+g6YJkH4W3xrLRm4iREfYpK7A0EubtpHYd7fM5VKTfYjZXDseqjnsUXR\n\tUhq5nwDj8jMMlyjaV6VeRF6HeglMwKloqGTRji9QgwFe/mYLfVG8WuWeEascn+Zx2+TSlh3ejsc\n\tkwehOVp6/GwPvq1MhC7RVW/bx8M+CSoqePCA8kMbcscu7MzsjW6STDwSeSLstyYYkNbJIJEZNSp\n\t+TjWmUWVBee/9LvF8DNt3KbVTGxdXsiiPh6d9bFenZH8kJ5rVkVmCBGxBzn66DOaVx7HyB3LaDG\n\t8UrioQSgNc7mRvQ==", "X-Developer-Key": "i=dan.scally@ideasonboard.com; a=openpgp;\n\tfpr=EEC699ACA1B7CB5D31330C0BBD501C2A3546CCF6", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "MaliC55CameraData stores a vector of the TPG's mbus codes (if the\ncamera in question is a TPG). This is never used - remove it.\n\nSigned-off-by: Daniel Scally <dan.scally@ideasonboard.com>\n---\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 4 ----\n 1 file changed, 4 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex a05e11fccf8dfde1a0eeda994afe2d78d884c530..35372ee1ed6f694166c395088c65509d32b9d1f2 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -131,7 +131,6 @@ private:\n \tvoid setSensorControls(const ControlList &sensorControls);\n \n \tstd::string id_;\n-\tstd::vector<unsigned int> tpgCodes_;\n \tstd::vector<Size> tpgSizes_;\n \tSize tpgResolution_;\n };\n@@ -180,9 +179,6 @@ void MaliC55CameraData::initTPGData()\n \tif (formats.empty())\n \t\treturn;\n \n-\ttpgCodes_ = utils::map_keys(formats);\n-\tstd::sort(tpgCodes_.begin(), tpgCodes_.end());\n-\n \tfor (const auto &format : formats) {\n \t\tconst std::vector<SizeRange> &ranges = format.second;\n \t\tstd::transform(ranges.begin(), ranges.end(), std::back_inserter(tpgSizes_),\n", "prefixes": [ "1/2" ] }