Patch Detail
Show a patch.
GET /api/patches/23404/?format=api
{ "id": 23404, "url": "https://patchwork.libcamera.org/api/patches/23404/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23404/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250520123158.44237-11-mzamazal@redhat.com>", "date": "2025-05-20T12:31:55", "name": "[v5,10/12] libcamera: simple: Don't enforce conversion with an added raw stream", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "0a1970ef8d32c38241a22eec1e0890f4b57db5ed", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23404/mbox/", "series": [ { "id": 5184, "url": "https://patchwork.libcamera.org/api/series/5184/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5184", "date": "2025-05-20T12:31:45", "name": "Enable raw streams with software ISP", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5184/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23404/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23404/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C5C23C31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 May 2025 12:32:54 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0FDC068D98;\n\tTue, 20 May 2025 14:32:54 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F53768D9C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 May 2025 14:32:38 +0200 (CEST)", "from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-445-XbZZgrHuNOaBDyilCnS_Ew-1;\n\tTue, 20 May 2025 08:32:35 -0400", "from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.40])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 43FC7195608D; Tue, 20 May 2025 12:32:34 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.226.214])\n\tby mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id E45F519560A3; Tue, 20 May 2025 12:32:31 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"WEDsqXa2\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1747744357;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=7IDyYK1udg1DTmOMNgVI1hdWqOhvstwmWv6kYgzgStQ=;\n\tb=WEDsqXa2IdpR7TCIBDC7n52+qT23e/UVQKkMZ9/J3L+7m4ni+rp+2O0nJVzX5PTmTRs6mR\n\tZ0wzQmEHjSgsF1gZZrHux9xtMB3o/tyfhw41J7Q9ypguDkoOpxbuSziIQxO/ZmkPbMvH2z\n\trNhQ5bvvCEPsWJ4oMuFNg+vkFnfUuLE=", "X-MC-Unique": "XbZZgrHuNOaBDyilCnS_Ew-1", "X-Mimecast-MFC-AGG-ID": "XbZZgrHuNOaBDyilCnS_Ew_1747744354", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Laurent Pinchart\n\t<laurent.pinchart@ideasonboard.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>, Paul Elder\n\t<paul.elder@ideasonboard.com>", "Subject": "[PATCH v5 10/12] libcamera: simple: Don't enforce conversion with an\n\tadded raw stream", "Date": "Tue, 20 May 2025 14:31:55 +0200", "Message-ID": "<20250520123158.44237-11-mzamazal@redhat.com>", "In-Reply-To": "<20250520123158.44237-1-mzamazal@redhat.com>", "References": "<20250520123158.44237-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.40", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "2E5x7uHaue9eFiJe_1hdNiuniEbdF58zbig7d-ZKubU_1747744354", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When a raw stream is requested, either alone or together with a\nprocessed stream, it can be produced without conversion. Let's amend\nthe corresponding check on the number of configurations, so that the\nmere presence of a raw stream doesn't enforce conversion.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 322a2276..5b778a0e 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1207,7 +1207,7 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate()\n \t * require any conversion, similar to raw capture use cases). This is\n \t * left as a future improvement.\n \t */\n-\tneedConversion_ = config_.size() > 1;\n+\tneedConversion_ = config_.size() > 1 + (rawRequested_ ? 1 : 0);\n \n \tfor (unsigned int i = 0; i < config_.size(); ++i) {\n \t\tStreamConfiguration &cfg = config_[i];\n", "prefixes": [ "v5", "10/12" ] }