Patch Detail
Show a patch.
GET /api/patches/23397/?format=api
{ "id": 23397, "url": "https://patchwork.libcamera.org/api/patches/23397/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23397/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250520123158.44237-4-mzamazal@redhat.com>", "date": "2025-05-20T12:31:48", "name": "[v5,03/12] libcamera: formats: Add a helper to check for a raw pixel format", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "94f97cee66949d45869e7969913c4a30a2aba7ad", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23397/mbox/", "series": [ { "id": 5184, "url": "https://patchwork.libcamera.org/api/series/5184/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5184", "date": "2025-05-20T12:31:45", "name": "Enable raw streams with software ISP", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5184/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23397/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23397/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4102DC31E9\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 20 May 2025 12:32:39 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D0F7F68D8A;\n\tTue, 20 May 2025 14:32:35 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4209668B67\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 20 May 2025 14:32:20 +0200 (CEST)", "from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-325-JYfgSxnmMhyp3j8ShhD4Lg-1;\n\tTue, 20 May 2025 08:32:16 -0400", "from mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.40])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id E221F180036E; Tue, 20 May 2025 12:32:14 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.226.214])\n\tby mx-prod-int-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 8E23619560A3; Tue, 20 May 2025 12:32:12 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"WLWtFON1\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1747744339;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=xMk7T2RusEbmIFB1FjNKAktj71iU3saVzBQSwegbQL8=;\n\tb=WLWtFON1CKwu9lHBtT7t5uFgm5b1p9ndUCipeTTj+TX+7tKYp+IQLhkvHKNAqJND2JDw/M\n\tE9Qggb8m0HCYB2iR/Ya6RlEGuMiptv7+9e7ZnQFU5mBnknyl8F38p1mzqmLn5Lf2/bXLke\n\tl+xdw6hSvQAcMoN6GTq7/4IGBEUCWU4=", "X-MC-Unique": "JYfgSxnmMhyp3j8ShhD4Lg-1", "X-Mimecast-MFC-AGG-ID": "JYfgSxnmMhyp3j8ShhD4Lg_1747744335", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>, Laurent Pinchart\n\t<laurent.pinchart@ideasonboard.com>, Kieran Bingham\n\t<kieran.bingham@ideasonboard.com>, =?utf-8?q?Barnab=C3=A1s_P=C5=91cze?=\n\t<barnabas.pocze@ideasonboard.com>, Paul Elder\n\t<paul.elder@ideasonboard.com>", "Subject": "[PATCH v5 03/12] libcamera: formats: Add a helper to check for a raw\n\tpixel format", "Date": "Tue, 20 May 2025 14:31:48 +0200", "Message-ID": "<20250520123158.44237-4-mzamazal@redhat.com>", "In-Reply-To": "<20250520123158.44237-1-mzamazal@redhat.com>", "References": "<20250520123158.44237-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.0 on 10.30.177.40", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "tMODMiFdBqDn07Or-SDPVdW1Oa5FeDEcUP0nF_0DuQE_1747744335", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "There are several places with the same pattern to check whether a given\npixel format is a raw format:\n\n return libcamera::PixelFormatInfo::info(pixFmt).colourEncoding ==\n libcamera::PixelFormatInfo::ColourEncodingRAW;\n\nLet's move the corresponding isFormatRaw helper from mali-c55.cpp to\nformats.cpp and use it where applicable. This also avoids a need to\nintroduce the same helper (or the same pattern) in the followup patches.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n include/libcamera/internal/formats.h | 2 ++\n src/libcamera/formats.cpp | 11 +++++++++++\n src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 4 ++--\n src/libcamera/pipeline/mali-c55/mali-c55.cpp | 10 ----------\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 7 ++-----\n 5 files changed, 17 insertions(+), 17 deletions(-)", "diff": "diff --git a/include/libcamera/internal/formats.h b/include/libcamera/internal/formats.h\nindex 6a3e9c16..bc4417d0 100644\n--- a/include/libcamera/internal/formats.h\n+++ b/include/libcamera/internal/formats.h\n@@ -62,4 +62,6 @@ public:\n \tstd::array<Plane, 3> planes;\n };\n \n+bool isFormatRaw(const libcamera::PixelFormat &pixFmt);\n+\n } /* namespace libcamera */\ndiff --git a/src/libcamera/formats.cpp b/src/libcamera/formats.cpp\nindex bfcdfc08..c6e0a262 100644\n--- a/src/libcamera/formats.cpp\n+++ b/src/libcamera/formats.cpp\n@@ -1215,4 +1215,15 @@ unsigned int PixelFormatInfo::numPlanes() const\n \treturn count;\n }\n \n+/**\n+ * \\brief Return whether the given pixel format is a raw format\n+ * \\param[in] pixFmt The pixel format to examine\n+ * \\return True iff the given format is a raw format\n+ */\n+bool isFormatRaw(const libcamera::PixelFormat &pixFmt)\n+{\n+\treturn libcamera::PixelFormatInfo::info(pixFmt).colourEncoding ==\n+\t libcamera::PixelFormatInfo::ColourEncodingRAW;\n+}\n+\n } /* namespace libcamera */\ndiff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\nindex ecda426a..ad36ebea 100644\n--- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n+++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n@@ -24,6 +24,7 @@\n #include \"libcamera/internal/camera.h\"\n #include \"libcamera/internal/camera_sensor.h\"\n #include \"libcamera/internal/device_enumerator.h\"\n+#include \"libcamera/internal/formats.h\"\n #include \"libcamera/internal/media_device.h\"\n #include \"libcamera/internal/pipeline_handler.h\"\n #include \"libcamera/internal/v4l2_subdevice.h\"\n@@ -312,8 +313,7 @@ unsigned int ISICameraData::getYuvMediaBusFormat(const PixelFormat &pixelFormat)\n \n unsigned int ISICameraData::getMediaBusFormat(PixelFormat *pixelFormat) const\n {\n-\tif (PixelFormatInfo::info(*pixelFormat).colourEncoding ==\n-\t PixelFormatInfo::ColourEncodingRAW)\n+\tif (isFormatRaw(*pixelFormat))\n \t\treturn getRawMediaBusFormat(pixelFormat);\n \n \treturn getYuvMediaBusFormat(*pixelFormat);\ndiff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\nindex a05e11fc..3721fb30 100644\n--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp\n@@ -42,16 +42,6 @@\n #include \"libcamera/internal/v4l2_subdevice.h\"\n #include \"libcamera/internal/v4l2_videodevice.h\"\n \n-namespace {\n-\n-bool isFormatRaw(const libcamera::PixelFormat &pixFmt)\n-{\n-\treturn libcamera::PixelFormatInfo::info(pixFmt).colourEncoding ==\n-\t libcamera::PixelFormatInfo::ColourEncodingRAW;\n-}\n-\n-} /* namespace */\n-\n namespace libcamera {\n \n LOG_DEFINE_CATEGORY(MaliC55)\ndiff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 675f0a74..50c83fb7 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -538,8 +538,7 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()\n \t */\n \tif (config_.size() > 1) {\n \t\tfor (const auto &cfg : config_) {\n-\t\t\tif (PixelFormatInfo::info(cfg.pixelFormat).colourEncoding ==\n-\t\t\t PixelFormatInfo::ColourEncodingRAW) {\n+\t\t\tif (isFormatRaw(cfg.pixelFormat)) {\n \t\t\t\tconfig_.resize(1);\n \t\t\t\tstatus = Adjusted;\n \t\t\t\tbreak;\n@@ -553,9 +552,7 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate()\n \t\t * Platforms with dewarper support, such as i.MX8MP, support\n \t\t * only a single stream. We can inspect config_[0] only here.\n \t\t */\n-\t\tbool isRaw = PixelFormatInfo::info(config_[0].pixelFormat).colourEncoding ==\n-\t\t\t PixelFormatInfo::ColourEncodingRAW;\n-\t\tif (!isRaw)\n+\t\tif (!isFormatRaw(config_[0].pixelFormat))\n \t\t\tuseDewarper = true;\n \t}\n \n", "prefixes": [ "v5", "03/12" ] }