Patch Detail
Show a patch.
GET /api/patches/23389/?format=api
{ "id": 23389, "url": "https://patchwork.libcamera.org/api/patches/23389/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23389/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250519092245.269048-5-naush@raspberrypi.com>", "date": "2025-05-19T09:20:52", "name": "[v1,4/6] pipeline: rpi: Remove disable_startup_frame_drops config option", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "5bfa51e86f786b03c6d9f9f0b91a2345638e31d9", "submitter": { "id": 34, "url": "https://patchwork.libcamera.org/api/people/34/?format=api", "name": "Naushir Patuck", "email": "naush@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23389/mbox/", "series": [ { "id": 5182, "url": "https://patchwork.libcamera.org/api/series/5182/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5182", "date": "2025-05-19T09:20:48", "name": "Eliminating startup frames", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5182/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23389/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23389/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7AE68BD78E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 19 May 2025 09:23:03 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9173D68D7C;\n\tMon, 19 May 2025 11:23:02 +0200 (CEST)", "from mail-wr1-x432.google.com (mail-wr1-x432.google.com\n\t[IPv6:2a00:1450:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ED80B68D82\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 19 May 2025 11:22:53 +0200 (CEST)", "by mail-wr1-x432.google.com with SMTP id\n\tffacd0b85a97d-3a361c8a830so413028f8f.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 19 May 2025 02:22:53 -0700 (PDT)", "from NAUSH-P-DELL.pitowers.org ([93.93.133.154])\n\tby smtp.gmail.com with ESMTPSA id\n\tffacd0b85a97d-3a366e08747sm8645961f8f.95.2025.05.19.02.22.52\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 19 May 2025 02:22:52 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"cGBBtjuR\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1747646573; x=1748251373;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=TDFSDhxsWtnuegD2eNp0so8bkMmcVepBWj9qp8gGI+4=;\n\tb=cGBBtjuRCD5MwpEsu+RNJkvvDvGVDUG3HgAUdXt89YtlAMgw2pjvuGcvfkRYVmGTIf\n\tFOzLOK8wWo4OPetB7Dzn8vRlWXCPEaMhUZxDhgoIFn/Un31VoJJ/mtSJSXa/1+5vKuUG\n\tJGZvc/n14m0xfKgjzzwPnlYJsplZq4nQZrRqnoPPt8cHVIteavEHZjmPsetkMSyXC3GH\n\tvzQMa8FsjcM/MSmHQYq50CuuL3FXPI47yftSv7eFZ40sQ8MfdZ/jai0a4ptCk4zjKc05\n\tNbPRmW4UlhnzLWGj1oy4Ir0mITS6/xOA9/YzDVCMu0eonIEeR0mZfLUXxe8mogSjOMDh\n\tPBIQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1747646573; x=1748251373;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=TDFSDhxsWtnuegD2eNp0so8bkMmcVepBWj9qp8gGI+4=;\n\tb=nMeZ6nluGqQGSzty4+eW4vzCMjbr0stDcO8RIAbVOIUa7Py8mYHJnKBPpaxV7i1/qJ\n\t0Z7ITmx8n12qj1ZM0rVYIkBSRRm1C1+rPaiD5WNH1J0LsxgEFlPj6l7udeAgsG9u9fco\n\t93UwxyiLcNb0wDmIvnWwiil5XeWZ608aWAh/zXSJiiL0VOjAgAVvT3FoxprEnxsClheh\n\tM47gaZtxqd8KMhe5iSk0hicpap0BerGP4PU4NIsgjgxCcbCPfUImfEQRvsBnOjKZ0IqX\n\tvPCam/4xftDQeIBHMURC+YHN2B8ql/IeYdnIDEqPuDOuQxT80iRsjyDju5JJQGg4xmVc\n\tM9rQ==", "X-Gm-Message-State": "AOJu0YwQG57MqqpmLSfRM/sKhVBKr35UXOoYX8N8fv4oDHv86OF8ktPu\n\tlXz7597CTYTydUiZJMPYD0ohP7dNjHrUPDOs1N4OMT8kgGBXvezA1PeFoBJtPlwwg4M/tOzHGKp\n\tfuFQK", "X-Gm-Gg": "ASbGncsozmqAuquM/uZEc9eQw9j5uiP3Cqr2VOBuL2EVwU7TBXhyMxt3JPGnV/goUAS\n\tQYGsxWxdQV8Tql59Gqd//ncwovRbzDcRmtbsZmPiVQbZ/v2OzNDSvw1VFLiXfYvcXsDR9qAwXZU\n\tbV6uljfgYGF639fSeEAHcEZQ9D4upQkjST3LjV1xndpoOABQJYBN9d2vWzSSDyxNkPN5GcaPNlb\n\tI9teY9g1uVpNq8t2CK0hNdx1KJzfXo5eUFoxGGFMGbGnOYbzsXw7Gz5K84JDHPaXYJv6Nkgm47o\n\tN0EVtc+onF16GpmGv4upUjE0lO3/lMOLg6P21KPcVnlwPq2FQ+wkWAH5vxWgdXMuQG0YbIg=", "X-Google-Smtp-Source": "AGHT+IF2tysLNeEBGECrTG+UjzZ3WrZk7mSIXTGYp3ZjmlsJXuaBKtg+zKMHsEswEqmLr/kkbEfJNQ==", "X-Received": "by 2002:a05:6000:438a:b0:3a3:75ea:f9d3 with SMTP id\n\tffacd0b85a97d-3a375eafce5mr315084f8f.11.1747646573249; \n\tMon, 19 May 2025 02:22:53 -0700 (PDT)", "From": "Naushir Patuck <naush@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Naushir Patuck <naush@raspberrypi.com>", "Subject": "[PATCH v1 4/6] pipeline: rpi: Remove disable_startup_frame_drops\n\tconfig option", "Date": "Mon, 19 May 2025 10:20:52 +0100", "Message-ID": "<20250519092245.269048-5-naush@raspberrypi.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250519092245.269048-1-naush@raspberrypi.com>", "References": "<20250519092245.269048-1-naush@raspberrypi.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "With the previous change to not drop frames in the pipeline handler,\nthe \"disable_startup_frame_drops\" pipeline config option is not used.\nRemove it, and throw a warning if the option is present in the YAML\nconfig file.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\n---\n src/libcamera/pipeline/rpi/common/pipeline_base.cpp | 7 ++++---\n src/libcamera/pipeline/rpi/common/pipeline_base.h | 5 -----\n src/libcamera/pipeline/rpi/pisp/data/example.yaml | 5 -----\n src/libcamera/pipeline/rpi/vc4/data/example.yaml | 5 -----\n 4 files changed, 4 insertions(+), 18 deletions(-)", "diff": "diff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\nindex 21f2daf5bab5..4afdaed5935d 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.cpp\n@@ -1077,7 +1077,6 @@ void CameraData::enumerateVideoDevices(MediaLink *link, const std::string &front\n int CameraData::loadPipelineConfiguration()\n {\n \tconfig_ = {\n-\t\t.disableStartupFrameDrops = false,\n \t\t.cameraTimeoutValue = 0,\n \t};\n \n@@ -1114,8 +1113,10 @@ int CameraData::loadPipelineConfiguration()\n \n \tconst YamlObject &phConfig = (*root)[\"pipeline_handler\"];\n \n-\tconfig_.disableStartupFrameDrops =\n-\t\tphConfig[\"disable_startup_frame_drops\"].get<bool>(config_.disableStartupFrameDrops);\n+\tif (phConfig.contains(\"disable_startup_frame_drops\"))\n+\t\tLOG(RPI, Warning)\n+\t\t\t<< \"The disable_startup_frame_drops key is now deprecated, \"\n+\t\t\t<< \"please use FrameMetadata::Status::FrameStartup instead.\";\n \n \tconfig_.cameraTimeoutValue =\n \t\tphConfig[\"camera_timeout_value_ms\"].get<unsigned int>(config_.cameraTimeoutValue);\ndiff --git a/src/libcamera/pipeline/rpi/common/pipeline_base.h b/src/libcamera/pipeline/rpi/common/pipeline_base.h\nindex 6023f9f9d6b3..e27c4f860d1a 100644\n--- a/src/libcamera/pipeline/rpi/common/pipeline_base.h\n+++ b/src/libcamera/pipeline/rpi/common/pipeline_base.h\n@@ -164,11 +164,6 @@ public:\n \tbool buffersAllocated_;\n \n \tstruct Config {\n-\t\t/*\n-\t\t * Override any request from the IPA to drop a number of startup\n-\t\t * frames.\n-\t\t */\n-\t\tbool disableStartupFrameDrops;\n \t\t/*\n \t\t * Override the camera timeout value calculated by the IPA based\n \t\t * on frame durations.\ndiff --git a/src/libcamera/pipeline/rpi/pisp/data/example.yaml b/src/libcamera/pipeline/rpi/pisp/data/example.yaml\nindex d67e654a8b9e..baf03be79bb3 100644\n--- a/src/libcamera/pipeline/rpi/pisp/data/example.yaml\n+++ b/src/libcamera/pipeline/rpi/pisp/data/example.yaml\n@@ -16,11 +16,6 @@\n #\n # \"num_cfe_config_queue\": 2,\n \n- # Override any request from the IPA to drop a number of startup\n- # frames.\n- #\n- # \"disable_startup_frame_drops\": false,\n-\n # Custom timeout value (in ms) for camera to use. This overrides\n # the value computed by the pipeline handler based on frame\n # durations.\ndiff --git a/src/libcamera/pipeline/rpi/vc4/data/example.yaml b/src/libcamera/pipeline/rpi/vc4/data/example.yaml\nindex b8e01adeaf40..27e543488d48 100644\n--- a/src/libcamera/pipeline/rpi/vc4/data/example.yaml\n+++ b/src/libcamera/pipeline/rpi/vc4/data/example.yaml\n@@ -29,11 +29,6 @@\n #\n # \"min_total_unicam_buffers\": 4,\n \n- # Override any request from the IPA to drop a number of startup\n- # frames.\n- #\n- # \"disable_startup_frame_drops\": false,\n-\n # Custom timeout value (in ms) for camera to use. This overrides\n # the value computed by the pipeline handler based on frame\n # durations.\n", "prefixes": [ "v1", "4/6" ] }