Patch Detail
Show a patch.
GET /api/patches/23370/?format=api
{ "id": 23370, "url": "https://patchwork.libcamera.org/api/patches/23370/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23370/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250515120012.3127231-6-barnabas.pocze@ideasonboard.com>", "date": "2025-05-15T12:00:09", "name": "[RFC,v1,5/8] utils: codegen: ipc: Simplify `return` statements", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "20db6edbec9983bdb73c7e275177197cc27f03af", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23370/mbox/", "series": [ { "id": 5173, "url": "https://patchwork.libcamera.org/api/series/5173/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5173", "date": "2025-05-15T12:00:04", "name": "utils: codegen: ipc: Simplify deserialization", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5173/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23370/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23370/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 68AEFC3220\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 15 May 2025 12:00:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B18DD68D70;\n\tThu, 15 May 2025 14:00:26 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4352368B5D\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 May 2025 14:00:18 +0200 (CEST)", "from pb-laptop.local (185.221.142.248.nat.pool.zt.hu\n\t[185.221.142.248])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3539A89A;\n\tThu, 15 May 2025 14:00:01 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"iikk8OBB\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747310401;\n\tbh=iV3AqVrrv/QwfftjgOAa+8a6ln7NaCNcA+pIvxHxPHc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=iikk8OBBTpbFQR8Ik57v0MGV8ygYGpivv412Q0Hw9eKwDc5n0koWDEGvPXWJsRHNA\n\tVmhbMvA0COjrerlk9WeNyWWJ2nZrp8+LKRjiQik1/22hSXJaTq7x4hl3hvG7Un7NFy\n\tTT1fsBLZVbvWAXDqx+eMwfhekwIGhzMrjsT/b1j0=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Paul Elder <paul.elder@ideasonboard.com>", "Subject": "[RFC PATCH v1 5/8] utils: codegen: ipc: Simplify `return` statements", "Date": "Thu, 15 May 2025 14:00:09 +0200", "Message-ID": "<20250515120012.3127231-6-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250515120012.3127231-1-barnabas.pocze@ideasonboard.com>", "References": "<20250515120012.3127231-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Returning an expression of type `void` from a function returning `void`\nis legal, so do not handle those cases specially.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n .../libcamera_templates/module_ipa_proxy.cpp.tmpl | 10 ++++------\n 1 file changed, 4 insertions(+), 6 deletions(-)", "diff": "diff --git a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\nindex effc8f7dd..9a3aadbd2 100644\n--- a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n+++ b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n@@ -127,13 +127,13 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n {{proxy_funcs.func_sig(proxy_name, method)}}\n {\n \tif (isolate_)\n-\t\t{{\"return \" if method|method_return_value != \"void\"}}{{method.mojom_name}}IPC(\n+\t\treturn {{method.mojom_name}}IPC(\n {%- for param in method|method_param_names -%}\n \t\t{{param}}{{- \", \" if not loop.last}}\n {%- endfor -%}\n );\n \telse\n-\t\t{{\"return \" if method|method_return_value != \"void\"}}{{method.mojom_name}}Thread(\n+\t\treturn {{method.mojom_name}}Thread(\n {%- for param in method|method_param_names -%}\n \t\t{{param}}{{- \", \" if not loop.last}}\n {%- endfor -%}\n@@ -159,16 +159,14 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n \tstate_ = ProxyRunning;\n \tthread_.start();\n \n-\t{{ \"return \" if method|method_return_value != \"void\" -}}\n-\tproxy_.invokeMethod(&ThreadProxy::start, ConnectionTypeBlocking\n+\treturn proxy_.invokeMethod(&ThreadProxy::start, ConnectionTypeBlocking\n \t{{- \", \" if method|method_param_names}}\n \t{%- for param in method|method_param_names -%}\n \t\t{{param}}{{- \", \" if not loop.last}}\n \t{%- endfor -%}\n );\n {%- elif not method|is_async %}\n-\t{{ \"return \" if method|method_return_value != \"void\" -}}\n-\tipa_->{{method.mojom_name}}(\n+\treturn ipa_->{{method.mojom_name}}(\n \t{%- for param in method|method_param_names -%}\n \t\t{{param}}{{- \", \" if not loop.last}}\n \t{%- endfor -%}\n", "prefixes": [ "RFC", "v1", "5/8" ] }