Patch Detail
Show a patch.
GET /api/patches/23369/?format=api
{ "id": 23369, "url": "https://patchwork.libcamera.org/api/patches/23369/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23369/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250515120012.3127231-5-barnabas.pocze@ideasonboard.com>", "date": "2025-05-15T12:00:08", "name": "[RFC,v1,4/8] utils: codegen: ipc: Log error code when remote call fails", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "6fc52f9cc97cbda25fe3a6f9c38d2d82fcdeadf2", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23369/mbox/", "series": [ { "id": 5173, "url": "https://patchwork.libcamera.org/api/series/5173/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5173", "date": "2025-05-15T12:00:04", "name": "utils: codegen: ipc: Simplify deserialization", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5173/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23369/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23369/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9526FC328D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 15 May 2025 12:00:30 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EA84A68D6B;\n\tThu, 15 May 2025 14:00:25 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F9CC68B70\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 15 May 2025 14:00:17 +0200 (CEST)", "from pb-laptop.local (185.221.142.248.nat.pool.zt.hu\n\t[185.221.142.248])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7FD13886;\n\tThu, 15 May 2025 14:00:00 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"T+2F5etH\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1747310400;\n\tbh=O/0GBjFh9O7FN9IdFr4qs/b/FCsajvZOuZVKvXKVcwQ=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=T+2F5etHll52Ud9QoUVz1+qxkAptid12bAbqQDFB9d4M/1IL4S15IsNWeMgdyxH/P\n\tZlKU+veJ3onnwdaLmFuTzXo2km8efmBTlpNCeW9vF6qzX70+7P4Y8cQCvHca4wRJoN\n\t1iQXZ2b58mA42JMLbsgik5RO1l+U/P9F3Va6H5AA=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Paul Elder <paul.elder@ideasonboard.com>", "Subject": "[RFC PATCH v1 4/8] utils: codegen: ipc: Log error code when remote\n\tcall fails", "Date": "Thu, 15 May 2025 14:00:08 +0200", "Message-ID": "<20250515120012.3127231-5-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250515120012.3127231-1-barnabas.pocze@ideasonboard.com>", "References": "<20250515120012.3127231-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The error code can be useful in diagnosing the underlying issue,\nso log that as well, not just the existence of the issue.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n .../generators/libcamera_templates/module_ipa_proxy.cpp.tmpl | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\nindex 07165821e..effc8f7dd 100644\n--- a/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n+++ b/utils/codegen/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n@@ -206,7 +206,7 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n );\n {%- endif %}\n \tif (_ret < 0) {\n-\t\tLOG(IPAProxy, Error) << \"Failed to call {{method.mojom_name}}\";\n+\t\tLOG(IPAProxy, Error) << \"Failed to call {{method.mojom_name}}: \" << _ret;\n {%- if method|method_return_value != \"void\" %}\n \t\treturn static_cast<{{method|method_return_value}}>(_ret);\n {%- else %}\n", "prefixes": [ "RFC", "v1", "4/8" ] }