Patch Detail
Show a patch.
GET /api/patches/23348/?format=api
{ "id": 23348, "url": "https://patchwork.libcamera.org/api/patches/23348/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23348/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250507153103.253107-1-david.plowman@raspberrypi.com>", "date": "2025-05-07T15:31:03", "name": "utils: raspberrypi: ctt: Fix integer division error calculating LSC cell size", "commit_ref": "e0405b171e928651ed7be5d7ae47b426c07125ff", "pull_url": null, "state": "accepted", "archived": false, "hash": "b4a9b05f0116797bd48f44659464a3f14b1ea3c3", "submitter": { "id": 42, "url": "https://patchwork.libcamera.org/api/people/42/?format=api", "name": "David Plowman", "email": "david.plowman@raspberrypi.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23348/mbox/", "series": [ { "id": 5165, "url": "https://patchwork.libcamera.org/api/series/5165/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5165", "date": "2025-05-07T15:31:03", "name": "utils: raspberrypi: ctt: Fix integer division error calculating LSC cell size", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5165/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23348/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23348/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03C6DC3226\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 7 May 2025 15:31:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2765F68B31;\n\tWed, 7 May 2025 17:31:09 +0200 (CEST)", "from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com\n\t[IPv6:2a00:1450:4864:20::32b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 38E8368AD8\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 7 May 2025 17:31:07 +0200 (CEST)", "by mail-wm1-x32b.google.com with SMTP id\n\t5b1f17b1804b1-441ab63a415so71346955e9.3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 07 May 2025 08:31:07 -0700 (PDT)", "from davidp-xps-13.pitowers.org\n\t([2a00:1098:3142:1f:625b:4a21:8e09:bbdd])\n\tby smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-442cd3b7dd5sm4324455e9.35.2025.05.07.08.31.05\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 07 May 2025 08:31:05 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"ft8dtGxM\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1746631866; x=1747236666;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:from:to:cc:subject:date:message-id:reply-to;\n\tbh=s8TbdxR/8uN193SXKRQF+AG6xd8auv5BiVoyK+ZJIFQ=;\n\tb=ft8dtGxMPs6pQXGwvH1ANmQkfZQwfWERPToPVzdDBGcQlk6ErSDZrjuiifKsNAHOUl\n\tRbzF6saBoXC1t5JwOOD7LSAlwFJ3bTFmHBJVmM2YiVTXCD2RNLzjykt8PxCLD3Zu0EEa\n\t/ir2DsDzM0TyVIZX+E9MxdjDZhoUkwcTMOQQDHtzddWK9Z3qLM7eKhy7eOrCmIWiKgTm\n\tHUovme++iVdXwY55dSeKkR37CC/wE/hwxq8JvDLGYZWX2pop7h+NtWlSXmP+TdxvxBJG\n\tA7MqEIi4yKUuiVDS0ZPfxeEw78vCtzjsoNkTkjjkPNpIzsaOUlyWnuzwcH4cJQRr0f4T\n\thhGw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1746631866; x=1747236666;\n\th=content-transfer-encoding:mime-version:message-id:date:subject:cc\n\t:to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=s8TbdxR/8uN193SXKRQF+AG6xd8auv5BiVoyK+ZJIFQ=;\n\tb=FUAsN+hWLjZvFrzHCyP9pGW5HupmjAlfhnLigHIplxH+Iw/6pW/dEl36JX+7R+HO9X\n\t9e0J54999gakAId7TDoHIyI1Zs2uz60LjFg3xfXkEINE0okoNmXwXQxxKuyzOiwGDNK5\n\tdxVCpo6I3uu+rL/o5EY5/U9UeRArW+HONA2TsNuNCDe7GpSdW9XKpbkte0lOKoEPww09\n\tQMoPMJfho7XE+nauhTXIVDyDlstD5wNBFTbVLULV/MFnHk3hKONDeWwmio02K85gPeUu\n\tZGZqTUYpp0ARuenr9etbGLpW6+MhBsbOvkra44eXD5eIszEA6vXX8x/Int3bREIwMjor\n\t1M7w==", "X-Gm-Message-State": "AOJu0Yx0YcluoQ87EM33mu5Vv8DdPicp/5JKGwW+x9SW89kH9/oKCRcX\n\tQrX+XxmbcXhUDPjMko3o7Ku/Q0dayfOZcTNjel3GCIkf7zColJxMUNNdfZlfkzMdPGjXdEeB3Gl\n\t6jM0=", "X-Gm-Gg": "ASbGncuTVHAoOQPtNcE5SAieu4cFWGHJwXkR6yE4+SjDuw8C8GMfdehDaDvaZuNnhLe\n\tEK8TzaKixBaUXDPzoYUJKrabTcwuNR2QK0eZ3Svrz7DvhCdF1PiumP64kpZCO0nTT7cQAEB/Nzu\n\t5S97WY085pnXSXBf+tPSBVVSmidH/9io9KNOyOWJH2DvGdoyZPow8pLm7Wptlkh37VHqyVMXsmU\n\tLBAqcJxxi1E5CYDoqQY281KhhP18xUz6KeGIv9XXX6cOKcnJjyziWIIH66zVKiX2tMXfWPqR8CN\n\tReeEjsoScIuzwJ/OiofPLe8DB5UfvbBrfNiHesm/mWhpwep8EjO7rduFFJpklDqmq/HtVbxfJVk\n\t=", "X-Google-Smtp-Source": "AGHT+IEn2Zs4hxbof2feLBrHbwe+f0U+0J7CLK9cTcmmOJLX0V8najTGVuPOVXcUeh+nrPaC2F2aMg==", "X-Received": "by 2002:a05:600c:4eca:b0:441:a715:664a with SMTP id\n\t5b1f17b1804b1-441d44dd0c6mr25356225e9.20.1746631866162; \n\tWed, 07 May 2025 08:31:06 -0700 (PDT)", "From": "David Plowman <david.plowman@raspberrypi.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "David Plowman <david.plowman@raspberrypi.com>", "Subject": "[PATCH] utils: raspberrypi: ctt: Fix integer division error\n\tcalculating LSC cell size", "Date": "Wed, 7 May 2025 16:31:03 +0100", "Message-Id": "<20250507153103.253107-1-david.plowman@raspberrypi.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The cell sizes must be cast to integers as the parameters that\nwere passed in may be floats.\n\nBug: https://github.com/raspberrypi/libcamera/issues/260\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\nFixes: 36ba0e551507 (\"utils: raspberrypi: ctt: Fix NaNs in lens shading tables\")\n---\n utils/raspberrypi/ctt/ctt_alsc.py | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/utils/raspberrypi/ctt/ctt_alsc.py b/utils/raspberrypi/ctt/ctt_alsc.py\nindex f4fd09e3..5d8b2ced 100644\n--- a/utils/raspberrypi/ctt/ctt_alsc.py\n+++ b/utils/raspberrypi/ctt/ctt_alsc.py\n@@ -131,7 +131,7 @@ def alsc(Cam, Img, do_alsc_colour, plot=False, grid_size=(16, 12), max_gain=8.0)\n pixels.\n \"\"\"\n w, h = Img.w/2, Img.h/2\n- dx, dy = (w - 1) // (grid_w - 1), (h - 1) // (grid_h - 1)\n+ dx, dy = int((w - 1) // (grid_w - 1)), int((h - 1) // (grid_h - 1))\n \n \"\"\"\n average the green channels into one\n", "prefixes": [] }