Patch Detail
Show a patch.
GET /api/patches/23331/?format=api
{ "id": 23331, "url": "https://patchwork.libcamera.org/api/patches/23331/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23331/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250501141609.717148-3-kieran.bingham@ideasonboard.com>", "date": "2025-05-01T14:16:08", "name": "[2/3] libcamera: camera_sensor: Extend reporting in getFormat()", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "1c0f60ba0874765da54effe3150c643d517c0f23", "submitter": { "id": 4, "url": "https://patchwork.libcamera.org/api/people/4/?format=api", "name": "Kieran Bingham", "email": "kieran.bingham@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23331/mbox/", "series": [ { "id": 5159, "url": "https://patchwork.libcamera.org/api/series/5159/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5159", "date": "2025-05-01T14:16:06", "name": "libcamera: rkisp1: Camera Sensor Mode Validation", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5159/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23331/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23331/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9E472C327D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 1 May 2025 14:16:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4E26268AD9;\n\tThu, 1 May 2025 16:16:16 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CDBC368AD5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 1 May 2025 16:16:13 +0200 (CEST)", "from Monstersaurus.lgs-net.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ABA2F82A;\n\tThu, 1 May 2025 16:16:06 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Sk80Z774\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1746108966;\n\tbh=D0/2zUQlvXuJedoYsqSiOkKRCiWN0FZ3b1bx8rieaYY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Sk80Z7744lSrPHuliUmxZ6VTWamRty16ePWMlvFI4Gjyao2d3uslZdDJ3d+Y6Nyys\n\tV+jlG0f/didqNhPWi65aJTWc8npV8hjkLua9nNy+73nDUQnicwuhpsR+ZWhc+nAG32\n\tRYPhSJ+R80PO17JoEq60YJxsnG+OB19noysItcNQ=", "From": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "To": "libcamera devel <libcamera-devel@lists.libcamera.org>", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH 2/3] libcamera: camera_sensor: Extend reporting in\n\tgetFormat()", "Date": "Thu, 1 May 2025 15:16:08 +0100", "Message-ID": "<20250501141609.717148-3-kieran.bingham@ideasonboard.com>", "X-Mailer": "git-send-email 2.48.1", "In-Reply-To": "<20250501141609.717148-1-kieran.bingham@ideasonboard.com>", "References": "<20250501141609.717148-1-kieran.bingham@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "When a pipeline handler asks the CameraSensor for a format, which is not\nachievable, it can be very helpful to the user to identify what size was\nrequested and why it could not be provided within any constrained\nmaximum size.\n\nThis can make otherwise difficult to diagnose user errors visible and\nquickly correctable.\n\nBoth of the CameraSensorRaw and CameraSensorLegacy are updated\naccordingly but that likely means these two classes could soon benefit\nfrom a more common base class to share otherwise identical code.\n\nSigned-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n---\n src/libcamera/sensor/camera_sensor_legacy.cpp | 4 +++-\n src/libcamera/sensor/camera_sensor_raw.cpp | 4 +++-\n 2 files changed, 6 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/libcamera/sensor/camera_sensor_legacy.cpp b/src/libcamera/sensor/camera_sensor_legacy.cpp\nindex 32989c19c019..20275f3bb1b2 100644\n--- a/src/libcamera/sensor/camera_sensor_legacy.cpp\n+++ b/src/libcamera/sensor/camera_sensor_legacy.cpp\n@@ -742,7 +742,9 @@ CameraSensorLegacy::getFormat(const std::vector<unsigned int> &mbusCodes,\n \t}\n \n \tif (!bestSize) {\n-\t\tLOG(CameraSensor, Debug) << \"No supported format or size found\";\n+\t\tLOG(CameraSensor, Warning)\n+\t\t\t<< \"No supported format or size found. Requested \"\n+\t\t\t<< size << \" with a maximum size \" << maxSize;\n \t\treturn {};\n \t}\n \ndiff --git a/src/libcamera/sensor/camera_sensor_raw.cpp b/src/libcamera/sensor/camera_sensor_raw.cpp\nindex ab75b1f8204c..07d1e2bfa600 100644\n--- a/src/libcamera/sensor/camera_sensor_raw.cpp\n+++ b/src/libcamera/sensor/camera_sensor_raw.cpp\n@@ -800,7 +800,9 @@ CameraSensorRaw::getFormat(const std::vector<unsigned int> &mbusCodes,\n \t}\n \n \tif (!bestSize) {\n-\t\tLOG(CameraSensor, Debug) << \"No supported format or size found\";\n+\t\tLOG(CameraSensor, Warning)\n+\t\t\t<< \"No supported format or size found. Requested \"\n+\t\t\t<< size << \" with a maximum size \" << maxSize;\n \t\treturn {};\n \t}\n \n", "prefixes": [ "2/3" ] }