Patch Detail
Show a patch.
GET /api/patches/23269/?format=api
{ "id": 23269, "url": "https://patchwork.libcamera.org/api/patches/23269/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23269/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250428084418.1251085-3-barnabas.pocze@ideasonboard.com>", "date": "2025-04-28T08:44:16", "name": "[v3,2/4] apps: cam: sdl_texture: Drop `&rect_` from `SDL_Update{NV, }Texture()` call", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "afb8b0f6e3e83e23b92a98603b2eff5b6fbcd795", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23269/mbox/", "series": [ { "id": 5147, "url": "https://patchwork.libcamera.org/api/series/5147/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5147", "date": "2025-04-28T08:44:14", "name": "apps: cam: sdl_sink: Support more RGB and YUV formats", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5147/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23269/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23269/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 07DD6C32A2\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 28 Apr 2025 08:44:34 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 077F268ADA;\n\tMon, 28 Apr 2025 10:44:30 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 93E9668ACF\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 28 Apr 2025 10:44:22 +0200 (CEST)", "from pb-laptop.local (185.221.141.190.nat.pool.zt.hu\n\t[185.221.141.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9A8798FA;\n\tMon, 28 Apr 2025 10:44:17 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"q9N2/Bm3\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745829857;\n\tbh=7bTcM2mriVp85165ZMVr91wnqeD7M//VtRJQROS3rok=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=q9N2/Bm33/hKdXyruVMDevDKi8O+BxXWvTAWEnROcdX6gWIcPReeH/xlaOxfmPfNL\n\tyV0gmmReGmKZyqFXbmJwbJU0xTwd1y0Hgg0Kx2U5ds8JVvdnr7mFzzReldWNTozxf9\n\tko5mXskoXQXRVbetzxngw/kL/xKU+WmJvUKCk0iA=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[PATCH v3 2/4] apps: cam: sdl_texture: Drop `&rect_` from\n\t`SDL_Update{NV, }Texture()` call", "Date": "Mon, 28 Apr 2025 10:44:16 +0200", "Message-ID": "<20250428084418.1251085-3-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250428084418.1251085-1-barnabas.pocze@ideasonboard.com>", "References": "<20250428084418.1251085-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "If the entire texture is to be updated, there is no need to specify\nthe target area explicitly.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/apps/cam/sdl_texture_yuv.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/src/apps/cam/sdl_texture_yuv.cpp b/src/apps/cam/sdl_texture_yuv.cpp\nindex 80a5ec05d..7e2ce3f49 100644\n--- a/src/apps/cam/sdl_texture_yuv.cpp\n+++ b/src/apps/cam/sdl_texture_yuv.cpp\n@@ -17,7 +17,7 @@ SDLTextureNV12::SDLTextureNV12(const SDL_Rect &rect, unsigned int stride)\n \n void SDLTextureNV12::update(libcamera::Span<const libcamera::Span<const uint8_t>> data)\n {\n-\tSDL_UpdateNVTexture(ptr_, &rect_, data[0].data(), stride_,\n+\tSDL_UpdateNVTexture(ptr_, nullptr, data[0].data(), stride_,\n \t\t\t data[1].data(), stride_);\n }\n #endif\n@@ -29,5 +29,5 @@ SDLTextureYUYV::SDLTextureYUYV(const SDL_Rect &rect, unsigned int stride)\n \n void SDLTextureYUYV::update(libcamera::Span<const libcamera::Span<const uint8_t>> data)\n {\n-\tSDL_UpdateTexture(ptr_, &rect_, data[0].data(), stride_);\n+\tSDL_UpdateTexture(ptr_, nullptr, data[0].data(), stride_);\n }\n", "prefixes": [ "v3", "2/4" ] }