Patch Detail
Show a patch.
GET /api/patches/23254/?format=api
{ "id": 23254, "url": "https://patchwork.libcamera.org/api/patches/23254/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23254/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250424114103.451395-3-barnabas.pocze@ideasonboard.com>", "date": "2025-04-24T11:40:56", "name": "[RFC,v5,2/9] libcamera: process: Misc. cleanup around `execv()`", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "604e08be1be333d1f00624fe8858d373f4b96aaa", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23254/mbox/", "series": [ { "id": 5145, "url": "https://patchwork.libcamera.org/api/series/5145/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5145", "date": "2025-04-24T11:40:54", "name": "libcamera: process: Remove `ProcessManager` singleton", "version": 5, "mbox": "https://patchwork.libcamera.org/series/5145/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23254/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23254/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B0CE4C32A2\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 24 Apr 2025 11:41:16 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8EFCD68ACE;\n\tThu, 24 Apr 2025 13:41:12 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C25B668ACE\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 24 Apr 2025 13:41:07 +0200 (CEST)", "from pb-laptop.local (185.221.143.16.nat.pool.zt.hu\n\t[185.221.143.16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 811B91440;\n\tThu, 24 Apr 2025 13:41:05 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"j2HMYSBX\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745494865;\n\tbh=v+d5do+BDii4mzQmG2m0z5d+XRpJdYj73QV9LWHAWRs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=j2HMYSBXkK7GhMPUKx9j1VOGpJepOgnR6rYFkJhP+OJgeI/MLvUXgZEuQRT1PyT2R\n\tC7GFty4VapFcPdkz/rE4vFSqpfEIcOVswd9ptPSVtMRREJH44AxQbbzW5iBF7/QWwK\n\tazcWWaE43J2zNp7Dz1XK+mSqD+odQmDnwBKYFMGs=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[RFC PATCH v5 2/9] libcamera: process: Misc. cleanup around\n\t`execv()`", "Date": "Thu, 24 Apr 2025 13:40:56 +0200", "Message-ID": "<20250424114103.451395-3-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250424114103.451395-1-barnabas.pocze@ideasonboard.com>", "References": "<20250424114103.451395-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Firstly, get the number of arguments first, and use that to determine the\nsize of the allocation instead of retrieving it twice.\n\nSecondly, use `const_cast` instead of a C-style cast when calling `execv()`.\n\nThird, use `size_t` to match the type of `args.size()`.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/process.cpp | 9 +++++----\n 1 file changed, 5 insertions(+), 4 deletions(-)", "diff": "diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\nindex 68fad3270..0990b4bdd 100644\n--- a/src/libcamera/process.cpp\n+++ b/src/libcamera/process.cpp\n@@ -265,14 +265,15 @@ int Process::start(const std::string &path,\n \t\tif (file && strcmp(file, \"syslog\"))\n \t\t\tunsetenv(\"LIBCAMERA_LOG_FILE\");\n \n-\t\tconst char **argv = new const char *[args.size() + 2];\n-\t\tunsigned int len = args.size();\n+\t\tconst size_t len = args.size();\n+\t\tauto argv = std::make_unique<const char *[]>(len + 2);\n+\n \t\targv[0] = path.c_str();\n-\t\tfor (unsigned int i = 0; i < len; i++)\n+\t\tfor (size_t i = 0; i < len; i++)\n \t\t\targv[i + 1] = args[i].c_str();\n \t\targv[len + 1] = nullptr;\n \n-\t\texecv(path.c_str(), (char **)argv);\n+\t\texecv(path.c_str(), const_cast<char **>(argv.get()));\n \n \t\texit(EXIT_FAILURE);\n \t}\n", "prefixes": [ "RFC", "v5", "2/9" ] }