Patch Detail
Show a patch.
GET /api/patches/23247/?format=api
{ "id": 23247, "url": "https://patchwork.libcamera.org/api/patches/23247/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23247/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250424112203.445351-6-barnabas.pocze@ideasonboard.com>", "date": "2025-04-24T11:21:58", "name": "[RFC,v4,5/9] libcamera: process: Ensure that file descriptors are nonnegative", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e24aba5bb5514612e4e953700b0fed705a35b990", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23247/mbox/", "series": [ { "id": 5144, "url": "https://patchwork.libcamera.org/api/series/5144/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5144", "date": "2025-04-24T11:21:53", "name": "libcamera: process: Remove `ProcessManager` singleton", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5144/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23247/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23247/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 06CBDC3320\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 24 Apr 2025 11:22:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 97BE368B27;\n\tThu, 24 Apr 2025 13:22:17 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 537C668AC7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 24 Apr 2025 13:22:08 +0200 (CEST)", "from pb-laptop.local (185.221.143.16.nat.pool.zt.hu\n\t[185.221.143.16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 3F3C91666;\n\tThu, 24 Apr 2025 13:22:06 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"r48uVZU/\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745493726;\n\tbh=6SAo2VztWOdl3IaEm7dGNgRt6EEEbGm3QhaZW53aXf4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=r48uVZU/R5j2T6SsKnmnc9g3tiICHHqYkGHGcl5agl6rP54oZUE8+43zc6+LYTyl8\n\t7LMIQxpS7tdEMA6pMXDqaJUFQ63SBkhx2B0ZlTbP/uC6md8eH7tlS85mLmbl/yTZio\n\t/6Sl1afO7d3mt1YRoTlOQfER2MtETx7EiRSAqWWY=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Kieran Bingham <kieran.bingham@ideasonboard.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>", "Subject": "[RFC PATCH v4 5/9] libcamera: process: Ensure that file descriptors\n\tare nonnegative", "Date": "Thu, 24 Apr 2025 13:21:58 +0200", "Message-ID": "<20250424112203.445351-6-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250424112203.445351-1-barnabas.pocze@ideasonboard.com>", "References": "<20250424112203.445351-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Return `-EINVAL` from `Process::start()` if any of the file descriptors\nare negative as those most likely signal some kind of issue such as\nmissed error checking.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/process.cpp | 7 +++++++\n 1 file changed, 7 insertions(+)", "diff": "diff --git a/src/libcamera/process.cpp b/src/libcamera/process.cpp\nindex ca9733d77..1bc7a7f9a 100644\n--- a/src/libcamera/process.cpp\n+++ b/src/libcamera/process.cpp\n@@ -243,6 +243,11 @@ int Process::start(const std::string &path,\n \tif (pid_ > 0)\n \t\treturn -EBUSY;\n \n+\tfor (int fd : fds) {\n+\t\tif (fd < 0)\n+\t\t\treturn -EINVAL;\n+\t}\n+\n \tint childPid = fork();\n \tif (childPid == -1) {\n \t\tret = -errno;\n@@ -282,6 +287,8 @@ void Process::closeAllFdsExcept(const std::vector<int> &fds)\n \tstd::vector<int> v(fds);\n \tsort(v.begin(), v.end());\n \n+\tASSERT(v.empty() || v.front() >= 0);\n+\n \tDIR *dir = opendir(\"/proc/self/fd\");\n \tif (!dir)\n \t\treturn;\n", "prefixes": [ "RFC", "v4", "5/9" ] }