Patch Detail
Show a patch.
GET /api/patches/23235/?format=api
{ "id": 23235, "url": "https://patchwork.libcamera.org/api/patches/23235/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23235/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250422215920.4297-23-bryan.odonoghue@linaro.org>", "date": "2025-04-22T21:59:15", "name": "[22/27] libcamera: software_isp: egl: Bind each eglImage to its own texture unit", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": false, "hash": "5125b2d748405167bd2301ad7be46ea0d2bb3669", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23235/mbox/", "series": [ { "id": 5142, "url": "https://patchwork.libcamera.org/api/series/5142/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5142", "date": "2025-04-22T21:58:53", "name": "RFC: Add in a eGL based GPUISP in libcamera", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5142/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23235/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23235/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8D011C3322\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 22 Apr 2025 22:00:05 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CC76768B3B;\n\tWed, 23 Apr 2025 00:00:03 +0200 (CEST)", "from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com\n\t[IPv6:2a00:1450:4864:20::32e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E565C68B3C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Apr 2025 23:59:44 +0200 (CEST)", "by mail-wm1-x32e.google.com with SMTP id\n\t5b1f17b1804b1-43d0782d787so40757395e9.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Apr 2025 14:59:44 -0700 (PDT)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-44092d2eccesm2726615e9.20.2025.04.22.14.59.43\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 22 Apr 2025 14:59:43 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"gzaVBkQD\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1745359184; x=1745963984;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=iEIy8k+5TThGQoOX04wnJpO98XLgjGigWGAQBmfK/uY=;\n\tb=gzaVBkQDwsgj4uLoViMyC1syuDStEyqsYZtSQo1WE82nasaA+p/A1JmU4CNy530V7Y\n\tSp8LmxP07rb023hficnNUjmiccK0sYtJ6b3Zos1aQOOoY0DXBOyw5qwMigSBtkR6SRHi\n\t48LZy5zOunNolnERC07cvP197KebvWUF58rTIZ4PLMQ524WUAeMXZxkzdJMFJrghkws1\n\tZe3lIaw9S0C88Q6zwC/NYx3LQEkudx8v9ypKYLxuHnf2T9MIxA7/ppxVHZrl/RXct6fD\n\tixp53vtJXNGfSNHSS42iUYDH9BgWGLyJxPKolkLKhrHLg6OSE9suEzOz2T8/LgSMtaF+\n\teH2Q==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1745359184; x=1745963984;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=iEIy8k+5TThGQoOX04wnJpO98XLgjGigWGAQBmfK/uY=;\n\tb=UGR9fzuxLKvRoRnNGd0HJEHPsandt7Rpa648KsSP5NJgIRBaqPEsL8ShKR+74Y8/mO\n\tIl9IzEycKhsdMDGGiWV+Ve6vZbXKzU+H0x9zSUXQDLGw9l/BBnNOrqUIk1eIS7tEVYpw\n\tycZV2qGTHlfOwlpicrMqovK7K37c4dnrTwXmJScZyftcDbCEHKV31SyXNzKS3vNj7R6/\n\tqjUyVAGRXQazhF9c5CANq5bqedZDqJsU6wJ2AfGtISNqRmXPSDbW0ACwatEIIznn5088\n\tJApdbUV1V9RDL/QOoVB7heCTVK6Nx8QFDFW6Pvri7Qj5ACPmUvmXbv1tkLHj1+D/psZT\n\tAE2A==", "X-Gm-Message-State": "AOJu0YzmbB3j82GWDyl+LaZoB/+/vxC9CN/vwOAy8Ic2LjDEIynVVIrl\n\tWfAzEFVIynOspx6Z7830gIoYiq9+ovThmcbOXdKu3Ss7OmIQq2jBQzzNXrnX0zFcnJ6p9xBkLbB\n\ta7/c=", "X-Gm-Gg": "ASbGncvKgAZoKyVkHLfrSU+pgspMwzZXFr1kVfMCsSMaMAve5Li2zYWXZdZODK+Ed2w\n\tJf3+V1U/QosZrkVvp9EGj/kv9MwU7z4vj5Lo6D9DnXU42FY1TFzVlhbrTJj2vwQALW9RRWCAzgI\n\tn0W0l+2hP8GPTezO8rR8TMMJrXwIp9s8RbiqGy1nLHo4PV1kvpfeMJoc/OSq9E2iFtOde31BvOb\n\tRycsNbqpq+IsWGG2wJRFA3HeZZUaS6Qxl34CIkmqusMvhwUVNpcFe6m91rtp1iQk7/5Ck57QN2h\n\tMVDvmCH+M/o6BvSPMnwnSQgvoV96WD+xJevmvD21Rtt2pXQosikWNveRiWpImrhpcyLF4YA8YSo\n\tuNQP7UbO309jjV6ake88r", "X-Google-Smtp-Source": "AGHT+IHpsghOASku6uGLoJ3eU5orWbyf1WRAKi5yC6xNAAbGhjvbp8b/bSxAguL3ir2MxR35noNF1g==", "X-Received": "by 2002:a05:600c:3107:b0:43c:f64c:447f with SMTP id\n\t5b1f17b1804b1-4406ac163bemr115608335e9.29.1745359184323; \n\tTue, 22 Apr 2025 14:59:44 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie", "Subject": "[PATCH 22/27] libcamera: software_isp: egl: Bind each eglImage to\n\tits own texture unit", "Date": "Tue, 22 Apr 2025 22:59:15 +0100", "Message-ID": "<20250422215920.4297-23-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250422215920.4297-1-bryan.odonoghue@linaro.org>", "References": "<20250422215920.4297-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/egl.cpp | 1 +\n src/libcamera/software_isp/egl.h | 10 +++++++---\n 2 files changed, 8 insertions(+), 3 deletions(-)", "diff": "diff --git a/src/libcamera/software_isp/egl.cpp b/src/libcamera/software_isp/egl.cpp\nindex c3eb8290..885eaa84 100644\n--- a/src/libcamera/software_isp/egl.cpp\n+++ b/src/libcamera/software_isp/egl.cpp\n@@ -85,6 +85,7 @@ void eGL::destroyDMABufTexture(eGLImage *eglImage)\n // Generate a 2D texture from an input buffer directly\n void eGL::createTexture2D(eGLImage *eglImage, uint32_t width, uint32_t height, void *data)\n {\n+\tglActiveTexture(eglImage->texture_unit_);\n \tglBindTexture(GL_TEXTURE_2D, eglImage->texture_);\n \n \t// Generate texture, bind, associate image to texture, configure, unbind\ndiff --git a/src/libcamera/software_isp/egl.h b/src/libcamera/software_isp/egl.h\nindex f3c5d50f..64cf2a87 100644\n--- a/src/libcamera/software_isp/egl.h\n+++ b/src/libcamera/software_isp/egl.h\n@@ -29,13 +29,15 @@ LOG_DECLARE_CATEGORY(eGL)\n \n class eGLImage {\n public:\n-\teGLImage(uint32_t width, uint32_t height, uint32_t bpp) {\n+\teGLImage(uint32_t width, uint32_t height, uint32_t bpp, GLenum texture_unit, uint32_t texture_unit_uniform_id) {\n \t\timage_ = EGL_NO_IMAGE_KHR;\n \t\twidth_ = width;\n \t\theight_ = height;\n \t\tbpp_ = bpp;\n \t\tstride_ = width_ * bpp_ / 4;\n \t\tframesize_ = stride_ * height_;\n+\t\ttexture_unit_ = texture_unit;\n+\t\ttexture_unit_uniform_id_ = texture_unit_uniform_id;\n \n \t\tglGenTextures(1, &texture_);\n \t}\n@@ -44,14 +46,16 @@ public:\n \t\tglDeleteTextures(1, &texture_);\n \t};\n \n-\tGLuint texture_;\n-\tEGLImageKHR image_;\n \tuint32_t width_;\n \tuint32_t height_;\n \tuint32_t stride_;\n \tuint32_t offset_;\n \tuint32_t framesize_;\n \tuint32_t bpp_;\n+\tuint32_t texture_unit_uniform_id_;\n+\tGLenum texture_unit_;\n+\tGLuint texture_;\n+\tEGLImageKHR image_;\n };\n \n class eGL\n", "prefixes": [ "22/27" ] }