Patch Detail
Show a patch.
GET /api/patches/23234/?format=api
{ "id": 23234, "url": "https://patchwork.libcamera.org/api/patches/23234/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23234/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250422215920.4297-22-bryan.odonoghue@linaro.org>", "date": "2025-04-22T21:59:14", "name": "[21/27] libcamera: software_isp: debayer_egl: Make DebayerEGL the default debayer method", "commit_ref": null, "pull_url": null, "state": "rfc", "archived": false, "hash": "ca5dc81f0c10f490ba776b49d21a0a2bce3c9d19", "submitter": { "id": 175, "url": "https://patchwork.libcamera.org/api/people/175/?format=api", "name": "Bryan O'Donoghue", "email": "bryan.odonoghue@linaro.org" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23234/mbox/", "series": [ { "id": 5142, "url": "https://patchwork.libcamera.org/api/series/5142/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5142", "date": "2025-04-22T21:58:53", "name": "RFC: Add in a eGL based GPUISP in libcamera", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5142/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23234/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23234/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C36F8C3320\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 22 Apr 2025 22:00:01 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 17F2968B37;\n\tWed, 23 Apr 2025 00:00:01 +0200 (CEST)", "from mail-wr1-x431.google.com (mail-wr1-x431.google.com\n\t[IPv6:2a00:1450:4864:20::431])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0F18068B3B\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Apr 2025 23:59:44 +0200 (CEST)", "by mail-wr1-x431.google.com with SMTP id\n\tffacd0b85a97d-39c1ef4acf2so3680252f8f.0\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Apr 2025 14:59:44 -0700 (PDT)", "from inspiron14p-linux.ht.home (188-141-3-146.dynamic.upc.ie.\n\t[188.141.3.146]) by smtp.gmail.com with ESMTPSA id\n\t5b1f17b1804b1-44092d2eccesm2726615e9.20.2025.04.22.14.59.42\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 22 Apr 2025 14:59:42 -0700 (PDT)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=linaro.org header.i=@linaro.org\n\theader.b=\"pUjlyZN3\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=linaro.org; s=google; t=1745359183; x=1745963983;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=dfrf9NfeIzeHZUKoKR6Xey4sb9Odqh4LqL16fz3Aurk=;\n\tb=pUjlyZN3wzoXbNf4yeD5wqSUVCD/jaW0n74YNEppTDl42ATDezvfisq63Oj6I+OR8X\n\tMhvA7vCtQB/pjxv/QF2NSK7qOMJoyA6jPvMaWiSWnvSP3Nx7PybDSLGGsKsWr2+RjEez\n\tgZCneI4spWIMGfSjnOVCCxJoKUffHdZ3+4KyGvlrExu0AO7AOLSJ9czW+EycwJMxw4Kx\n\tkbBBIwihvahppeWPFRIuD0jdMuxc/A/D5/owKLqG6pvrgbA6/T/FVzg3G/q5U5ixVXhN\n\t8akgO98igLmvvM0NbHqOXquANcJk+rbk5CxKD0vjlNoM/7GM1RA1fe8coH6lGkW//Kp3\n\tzxXw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1745359183; x=1745963983;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=dfrf9NfeIzeHZUKoKR6Xey4sb9Odqh4LqL16fz3Aurk=;\n\tb=sv+unWVtMctRW1On3tF7xT/pYSX5xKCdMAGWI+kbjRrCCbcaCFE4ncZkk5ZClUlE0R\n\tQSa2UFqk0JtJdxqFeyLvRWITzC6xuU1HE3WWARSaU3abJ7v+KHUMlUATsqjCUtDhcFkn\n\tAenmrITwVhA33Sr0RKERHQvTiWUNvGTT9ATefQAlAsAEf6yZ+Be5UkCL3ad5RX+xNGke\n\tPAG8U/+9FJnPeErZ3qmeLd5V7JGehk5Xn4wbOq1fc3wteATuGmmE3SLoXyeN8Mj3jytU\n\tFiMLcfzCzzLfihnp1qrdOS0sKOHR0pFOPHn4CtFDk/x0p2iIVKTafY30kqBLZFV3Odjp\n\twEuw==", "X-Gm-Message-State": "AOJu0YybsZoUw0LhK3GQgTHdU3lvmdsH0WdgzLcPOvy7/RTvo2lfOk4E\n\tleYN6XwG12p/9ch0dYGFGrsep1ehNuIm0+w27WziFfamHri21wbRDfEoyTGksgRKLT8Za8hfSha\n\ttX2Y=", "X-Gm-Gg": "ASbGncuz7wEnTdqxlJfunbC0HiWc0Jw/60XoDojhtM64x3wI5SLm0HvytYNP9ku9ZAN\n\tNnVLDeDuWNsAn6vHPldMTNxssR3yzZMChGHGVEFpnD/PYbHuXD22WQhhF7x5DEa2iWboDJLmzwe\n\tYrfv0uJJxXIjX71GU8LSdIii426eylawRaaddoCFFLZfJgunK+IIUrTyElxOGuZn8m4J69ONhl6\n\tXmaEGL6EkgJ3Szd9GRaJLLnmryx85PSrK1JIZe0kHvcXlvZWJAIFiGTvnM0RdBgOz5UDGhEph3z\n\tJ3/5VC9RWIBBKfS/MZdFAZ+Vwk2cG3HKreZqafVULH3cXlgnGgSBsMEexXuK5eSkmouqw63aPj9\n\t4CJiMgd1ckq5CH1zjtVN6", "X-Google-Smtp-Source": "AGHT+IFq3iNq33PAXIwtpC5e1ualOsqGlxo7UJzEBasQHsQAg1Dcovnyc4/zHwxboOs+sqziSjHTYA==", "X-Received": "by 2002:a05:6000:40ce:b0:39c:1257:dba8 with SMTP id\n\tffacd0b85a97d-39efbaf201amr12617212f8f.56.1745359183430; \n\tTue, 22 Apr 2025 14:59:43 -0700 (PDT)", "From": "Bryan O'Donoghue <bryan.odonoghue@linaro.org>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "hdegoede@redhat.com, mzamazal@redhat.com, bryan.odonoghue@linaro.org,\n\tbod.linux@nxsw.ie", "Subject": "[PATCH 21/27] libcamera: software_isp: debayer_egl: Make DebayerEGL\n\tthe default debayer method", "Date": "Tue, 22 Apr 2025 22:59:14 +0100", "Message-ID": "<20250422215920.4297-22-bryan.odonoghue@linaro.org>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250422215920.4297-1-bryan.odonoghue@linaro.org>", "References": "<20250422215920.4297-1-bryan.odonoghue@linaro.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Try the EGL debayer method, if that fails then try the CPU version\nbefore bailing out entirely.\n\nSigned-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>\n---\n src/libcamera/software_isp/software_isp.cpp | 13 ++++++++++++-\n 1 file changed, 12 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp\nindex c3dc21de..e4c7fda1 100644\n--- a/src/libcamera/software_isp/software_isp.cpp\n+++ b/src/libcamera/software_isp/software_isp.cpp\n@@ -25,6 +25,7 @@\n #include \"libcamera/internal/software_isp/debayer_params.h\"\n \n #include \"debayer_cpu.h\"\n+#include \"debayer_egl.h\"\n \n /**\n * \\file software_isp.cpp\n@@ -114,7 +115,17 @@ SoftwareIsp::SoftwareIsp(PipelineHandler *pipe, const CameraSensor *sensor,\n \t}\n \tstats->statsReady.connect(this, &SoftwareIsp::statsReady);\n \n-\tdebayer_ = std::make_unique<DebayerCpu>(std::move(stats));\n+\t//TODO: derive the selection from file/environment variable\n+\tdebayer_ = std::make_unique<DebayerEGL>(std::move(stats));\n+\tif (!debayer_) {\n+\t\tLOG(SoftwareIsp, Error) << \"Failed to create DebayerEGL object\";\n+\t\tdebayer_ = std::make_unique<DebayerCpu>(std::move(stats));\n+\t\tif (!debayer_) {\n+\t\t\tLOG(SoftwareIsp, Error) << \"Failed to create DebayerCPUGL object\";\n+\t\t\treturn;\n+\t\t}\n+\t}\n+\n \tdebayer_->inputBufferReady.connect(this, &SoftwareIsp::inputReady);\n \tdebayer_->outputBufferReady.connect(this, &SoftwareIsp::outputReady);\n \n", "prefixes": [ "21/27" ] }