Patch Detail
Show a patch.
GET /api/patches/23211/?format=api
{ "id": 23211, "url": "https://patchwork.libcamera.org/api/patches/23211/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23211/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250422142903.14742-3-jaslo@ziska.de>", "date": "2025-04-22T14:25:20", "name": "[2/3] gstreamer: Add support for read- and write-only controls", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ff4db5ca1bb5b2f343bce22bb1f0e6bb3f555d53", "submitter": { "id": 173, "url": "https://patchwork.libcamera.org/api/people/173/?format=api", "name": "Jaslo Ziska", "email": "jaslo@ziska.de" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23211/mbox/", "series": [ { "id": 5141, "url": "https://patchwork.libcamera.org/api/series/5141/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5141", "date": "2025-04-22T14:25:18", "name": "gstreamer: Add support for read- and write-only controls", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5141/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23211/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23211/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 67293BE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tTue, 22 Apr 2025 14:29:53 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1AA4E68AD4;\n\tTue, 22 Apr 2025 16:29:53 +0200 (CEST)", "from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de\n\t[85.215.255.52])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AF9BD68AC5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tTue, 22 Apr 2025 16:29:51 +0200 (CEST)", "from archlinux.fritz.box by smtp.strato.de (RZmta 51.3.0 AUTH)\n\twith ESMTPSA id z34f8113METpRL7\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits))\n\t(Client did not present a certificate);\n\tTue, 22 Apr 2025 16:29:51 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=ziska.de header.i=@ziska.de header.b=\"VpE5fTvJ\";\n\tdkim=permerror (0-bit key) header.d=ziska.de header.i=@ziska.de\n\theader.b=\"HvnBPelj\"; dkim-atps=neutral", "ARC-Seal": "i=1; a=rsa-sha256; t=1745332191; cv=none;\n\td=strato.com; s=strato-dkim-0002;\n\tb=NlO09xhz+GXmXvF3ZHBBv291QfOv64T9QcXZoQGEjfz3UiTgqVIONmbs4CyXfYOxX4\n\twjf3GsfiYfUJrPqE3EzDlVk1f7th9lC+cDb0Bt5ojAweeVHErZ2qeq61fcS+/4qsafs9\n\tl7bLtIMDmtnp0a5P4t99m6yXkuTnbskTdBFsUpJkLSduvwrI1h3g9OEUiEePXOztXK2N\n\tBccYVtgYBN48KCi8vHGCZIp9aM5+Dni7k8fSlpbNAoYb1R/OY+ilZyjCdijtiNJrI9h5\n\tIprfLMdt6NuaMOvsMGzSUxVIajWXQRrGTdzI0jPT6cOmiiV8PlpaTfjzPNI1hKkVCnDT\n\tSyuw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; t=1745332191;\n\ts=strato-dkim-0002; d=strato.com;\n\th=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date:\n\tFrom:Subject:Sender;\n\tbh=bCx+M9liS08t/HlUYTJneJLrs8KpfLTurtw4+e4asyU=;\n\tb=OcptjT0LZPnMHjSifrp4am1pdvDHQpfsFfTNcRcQRLyPyF0NH1honXh6/yg3tkBnuZ\n\tF9QVpW35mrnFM0SvbILecVUjL9SCHAGVmp9RsSXG5k2KvOD/4yHqHkdZVoLqt9jtC/OK\n\thPbhUu+1slmYKkI4LSbmgy6uZvHdOSZh5SuPwA30PG/4bihQzEHQOsFOYXkJlEg5wAgz\n\thQNQ8Dlczwyb6ozWp+O/8VPfeYWMmNYTsu1nwfvBiIi1iP3CsuN9Trx//fphwp0yvQHX\n\t2q6Jv7P3Lr+dAmR2i1GZ+Zsh1Q4jcRoJ3t8/swaGn47ZhbkZAhSTYZxuAGLLFbwYa8e9\n\tjoaA==", "ARC-Authentication-Results": "i=1; strato.com;\n arc=none;\n dkim=none", "X-RZG-CLASS-ID": "mo01", "DKIM-Signature": [ "v=1; a=rsa-sha256; c=relaxed/relaxed; t=1745332191;\n\ts=strato-dkim-0002; d=ziska.de;\n\th=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date:\n\tFrom:Subject:Sender;\n\tbh=bCx+M9liS08t/HlUYTJneJLrs8KpfLTurtw4+e4asyU=;\n\tb=VpE5fTvJGX7qpKQ6VCE1hpIvBj+9RUfZEREjr0BWkdhG0PuJqiBCxDRhJSXdjEFeIh\n\tAUDE8qx4/FnnN4VMLRH5Jv6LI6vS3jXVqJhBxx3WpIfXgav4T4S0kIdFI8JV8cUpFlpV\n\tPEKjLnbMY83shZZSGH88d3CcyCioDcueTg8sNc3TFgvZm2MtdcFCHVahnXwYVfy3Br3r\n\tuvf7Y2U+XggdE93GU1qgXJuApCWJ/JD47nNLqOsQ1owV3YmPgO2R643X5pvBMoD2xqRP\n\tJN2p+f13bbJNsmf5H4d/3VedYPYZVE9VeTMKMyAj8viaYx8dpusVVHeXEwzFvfpMRQit\n\tHrCA==", "v=1; a=ed25519-sha256; c=relaxed/relaxed; t=1745332191;\n\ts=strato-dkim-0003; d=ziska.de;\n\th=References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Cc:Date:\n\tFrom:Subject:Sender;\n\tbh=bCx+M9liS08t/HlUYTJneJLrs8KpfLTurtw4+e4asyU=;\n\tb=HvnBPeljPBXRhje7B5j6lb3hH2XCezsfok12C8Q0etJINyrcus2ew0diJEKIVSLRAa\n\tnbCmA8ZKWzTQlsPLLjAA==" ], "X-RZG-AUTH": "\":Jm0XeU+IYfb0x77LHmrjN5Wlb7TBwusDqIM6Hizy8VdfzvKi4yoFC9cCgYrrBvJaIR9ymoISrfhsHWODCRPggeTRCTeK\"", "From": "Jaslo Ziska <jaslo@ziska.de>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jaslo Ziska <jaslo@ziska.de>", "Subject": "[PATCH 2/3] gstreamer: Add support for read- and write-only controls", "Date": "Tue, 22 Apr 2025 16:25:20 +0200", "Message-ID": "<20250422142903.14742-3-jaslo@ziska.de>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250422142903.14742-1-jaslo@ziska.de>", "References": "<20250422142903.14742-1-jaslo@ziska.de>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"us-ascii\"", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "Signed-off-by: Jaslo Ziska <jaslo@ziska.de>\n---\n src/gstreamer/gstlibcamera-controls.cpp.in | 12 ++++++++++++\n 1 file changed, 12 insertions(+)", "diff": "diff --git a/src/gstreamer/gstlibcamera-controls.cpp.in b/src/gstreamer/gstlibcamera-controls.cpp.in\nindex 28604a3c..b38038ca 100644\n--- a/src/gstreamer/gstlibcamera-controls.cpp.in\n+++ b/src/gstreamer/gstlibcamera-controls.cpp.in\n@@ -126,7 +126,13 @@ g_param_spec_{{ ctrl.gtype }}(\n {%- endif %}\n \t(GParamFlags) (GST_PARAM_CONDITIONALLY_AVAILABLE |\n \t\t GST_PARAM_CONTROLLABLE |\n+{%- if ctrl.direction == 'ControlId::Direction::In' %}\n+\t\t G_PARAM_WRITABLE |\n+{%- elif ctrl.direction == 'ControlId::Direction::Out' %}\n+\t\t G_PARAM_READABLE |\n+{%- else %}\n \t\t G_PARAM_READWRITE |\n+{%- endif %}\n \t\t G_PARAM_STATIC_STRINGS)\n )\n {%- endset %}\n@@ -142,7 +148,13 @@ g_param_spec_{{ ctrl.gtype }}(\n \t\t\t{{ spec|indent_str('\\t\\t\\t') }},\n \t\t\t(GParamFlags) (GST_PARAM_CONDITIONALLY_AVAILABLE |\n \t\t\t\t GST_PARAM_CONTROLLABLE |\n+{%- if ctrl.direction == 'ControlId::Direction::In' %}\n+\t\t\t\t G_PARAM_WRITABLE |\n+{%- elif ctrl.direction == 'ControlId::Direction::Out' %}\n+\t\t\t\t G_PARAM_READABLE |\n+{%- else %}\n \t\t\t\t G_PARAM_READWRITE |\n+{%- endif %}\n \t\t\t\t G_PARAM_STATIC_STRINGS)\n \t\t)\n {%- else %}\n", "prefixes": [ "2/3" ] }