Patch Detail
Show a patch.
GET /api/patches/23200/?format=api
{ "id": 23200, "url": "https://patchwork.libcamera.org/api/patches/23200/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23200/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250421155109.175930-5-barnabas.pocze@ideasonboard.com>", "date": "2025-04-21T15:51:08", "name": "[RFC,v1,4/5] apps: cam: sdl_texture: Remove `SDLTextureYUYV`", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "e29cd61108fbef2ac8f96d29fe5e5a0e281e2767", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23200/mbox/", "series": [ { "id": 5136, "url": "https://patchwork.libcamera.org/api/series/5136/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5136", "date": "2025-04-21T15:51:04", "name": "apps: cam: Support {RGB,BGR}888 format", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5136/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23200/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23200/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8D226BE08B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 21 Apr 2025 15:51:23 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5EF2C68AD3;\n\tMon, 21 Apr 2025 17:51:22 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6141468ACA\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Apr 2025 17:51:14 +0200 (CEST)", "from pb-laptop.local (185.221.143.16.nat.pool.zt.hu\n\t[185.221.143.16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C45EC6D6\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Apr 2025 17:49:07 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lM3WDAmn\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745250547;\n\tbh=QQN+H6cpr47i93cbHUB51sQg105xgwrgaEUaS5YrBKQ=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=lM3WDAmnFatm5C8TD4Jnb+yuWffuSyyBCSsrSqLY71tjaDbWByghGvfikcUrPJBKO\n\tEStyj7dR3erNk2gMBvKV3M3IA4l3F/rNfunqSzOe4LAFEho9CdFtBZp+65HVkLHX9H\n\tPq5hnig4xxl76OrpfPOgrO3x9hIi5Xi+vnHlv4kg=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[RFC PATCH v1 4/5] apps: cam: sdl_texture: Remove `SDLTextureYUYV`", "Date": "Mon, 21 Apr 2025 17:51:08 +0200", "Message-ID": "<20250421155109.175930-5-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250421155109.175930-1-barnabas.pocze@ideasonboard.com>", "References": "<20250421155109.175930-1-barnabas.pocze@ideasonboard.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "It became unused, so remove it.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/apps/cam/sdl_texture_yuv.cpp | 10 ----------\n src/apps/cam/sdl_texture_yuv.h | 7 -------\n 2 files changed, 17 deletions(-)", "diff": "diff --git a/src/apps/cam/sdl_texture_yuv.cpp b/src/apps/cam/sdl_texture_yuv.cpp\nindex 80a5ec05d..ba7bd57f8 100644\n--- a/src/apps/cam/sdl_texture_yuv.cpp\n+++ b/src/apps/cam/sdl_texture_yuv.cpp\n@@ -21,13 +21,3 @@ void SDLTextureNV12::update(libcamera::Span<const libcamera::Span<const uint8_t>\n \t\t\t data[1].data(), stride_);\n }\n #endif\n-\n-SDLTextureYUYV::SDLTextureYUYV(const SDL_Rect &rect, unsigned int stride)\n-\t: SDLTexture(rect, SDL_PIXELFORMAT_YUY2, stride)\n-{\n-}\n-\n-void SDLTextureYUYV::update(libcamera::Span<const libcamera::Span<const uint8_t>> data)\n-{\n-\tSDL_UpdateTexture(ptr_, &rect_, data[0].data(), stride_);\n-}\ndiff --git a/src/apps/cam/sdl_texture_yuv.h b/src/apps/cam/sdl_texture_yuv.h\nindex db877f503..c271f901b 100644\n--- a/src/apps/cam/sdl_texture_yuv.h\n+++ b/src/apps/cam/sdl_texture_yuv.h\n@@ -17,10 +17,3 @@ public:\n \tvoid update(libcamera::Span<const libcamera::Span<const uint8_t>> data) override;\n };\n #endif\n-\n-class SDLTextureYUYV : public SDLTexture\n-{\n-public:\n-\tSDLTextureYUYV(const SDL_Rect &rect, unsigned int stride);\n-\tvoid update(libcamera::Span<const libcamera::Span<const uint8_t>> data) override;\n-};\n", "prefixes": [ "RFC", "v1", "4/5" ] }