Patch Detail
Show a patch.
GET /api/patches/23189/?format=api
{ "id": 23189, "url": "https://patchwork.libcamera.org/api/patches/23189/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23189/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250421064959.1239069-1-paul.elder@ideasonboard.com>", "date": "2025-04-21T06:49:59", "name": "pipeline: rkisp1: Fix vblank delay", "commit_ref": "86c45c8fdf36b6983ad0d585184218f541bb4fd5", "pull_url": null, "state": "accepted", "archived": false, "hash": "c1c89fed1ab832ca9fb64623a08abae230f71b0e", "submitter": { "id": 17, "url": "https://patchwork.libcamera.org/api/people/17/?format=api", "name": "Paul Elder", "email": "paul.elder@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23189/mbox/", "series": [ { "id": 5134, "url": "https://patchwork.libcamera.org/api/series/5134/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5134", "date": "2025-04-21T06:49:59", "name": "pipeline: rkisp1: Fix vblank delay", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5134/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23189/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23189/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2C75BC327D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 21 Apr 2025 06:50:29 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3A8BF68AC7;\n\tMon, 21 Apr 2025 08:50:28 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5F542617E3\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 21 Apr 2025 08:50:25 +0200 (CEST)", "from neptunite.hamster-moth.ts.net (unknown\n\t[IPv6:2404:7a81:160:2100:5315:cd50:88f8:c480])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ED5DA3DA;\n\tMon, 21 Apr 2025 08:48:17 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lKevHGhA\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1745218098;\n\tbh=lKaZ4We4Gj0Vho/O7s/74SFIgHFUXHIQkSfutHXdyYE=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=lKevHGhAwRNCfbwEH38ZZjxbtaK8nr6SzBzEZedUbxxMa+t7wQXiMC/Pe4lqlJsjx\n\tVhryl17Ws20MbYExetOG8jdfCDOKfvzv5o9sUOavsbOPnQqKImAKgsuv1bGjXHZMDD\n\tN6OHy7a6uZ8PwapH2FwmxRpXBumtsCdvzTaifn98=", "From": "Paul Elder <paul.elder@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Paul Elder <paul.elder@ideasonboard.com>", "Subject": "[PATCH] pipeline: rkisp1: Fix vblank delay", "Date": "Mon, 21 Apr 2025 15:49:59 +0900", "Message-ID": "<20250421064959.1239069-1-paul.elder@ideasonboard.com>", "X-Mailer": "git-send-email 2.47.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The vblank delay for delayed controls was incorrectly hardcoded to 1.\nGet it from the camera sensor properties instead.\n\nFixes: f72c76eb6e06 (\"rkisp1: Honor the FrameDurationLimits control\")\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\n---\n src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\nindex 52633fe3cb85..194dfce7ee5d 100644\n--- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n+++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp\n@@ -1325,7 +1325,7 @@ int PipelineHandlerRkISP1::createCamera(MediaEntity *sensor)\n \tstd::unordered_map<uint32_t, DelayedControls::ControlParams> params = {\n \t\t{ V4L2_CID_ANALOGUE_GAIN, { delays.gainDelay, false } },\n \t\t{ V4L2_CID_EXPOSURE, { delays.exposureDelay, false } },\n-\t\t{ V4L2_CID_VBLANK, { 1, false } },\n+\t\t{ V4L2_CID_VBLANK, { delays.vblankDelay, false } },\n \t};\n \n \tdata->delayedCtrls_ =\n", "prefixes": [] }