Patch Detail
Show a patch.
GET /api/patches/23188/?format=api
{ "id": 23188, "url": "https://patchwork.libcamera.org/api/patches/23188/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23188/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250418162405.1339989-1-barnabas.pocze@ideasonboard.com>", "date": "2025-04-18T16:24:05", "name": "[v1] libcamera: pipeline: imx8-isi: Remove unused variable", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "d6e60404c3a20b64895bf19ef31700baf667be65", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23188/mbox/", "series": [ { "id": 5133, "url": "https://patchwork.libcamera.org/api/series/5133/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5133", "date": "2025-04-18T16:24:05", "name": "[v1] libcamera: pipeline: imx8-isi: Remove unused variable", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5133/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23188/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23188/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 53AE6C327D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 18 Apr 2025 16:24:10 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CDAAE68ACA;\n\tFri, 18 Apr 2025 18:24:09 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C1AE2617E7\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Apr 2025 18:24:07 +0200 (CEST)", "from pb-laptop.local (185.221.143.16.nat.pool.zt.hu\n\t[185.221.143.16])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 50343ED4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 18 Apr 2025 18:22:03 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"LpHQi7xw\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1744993323;\n\tbh=wr0ygtCGR1MJpRnzdO+8SVIAPtme8NDAv9NGDQ2um0Q=;\n\th=From:To:Subject:Date:From;\n\tb=LpHQi7xw1VhdasChCbrtr7zeavfU+8PWTl6fosnX0K/ro2vCorkceN+OKYaazlUOR\n\tAwQsDX6BIjHTMMf8m6RWgCGuOpQpb+uTjYzrXq+xUcdm3GUq2bIB4ULvH6vhWaKIE4\n\tCAOc3C8RB9luX94q96DDC8bbejxF02yCwKb8qd/c=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Subject": "[PATCH v1] libcamera: pipeline: imx8-isi: Remove unused variable", "Date": "Fri, 18 Apr 2025 18:24:05 +0200", "Message-ID": "<20250418162405.1339989-1-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The `mbusCodes` variable in `ISICameraConfiguration::validateRaw()`\nhas been unused since\n\n 87fed432533a (\"libcamera: imx8-isi: Break out RAW format selection\"),\n\nso remove it.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\n---\n src/libcamera/pipeline/imx8-isi/imx8-isi.cpp | 1 -\n 1 file changed, 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\nindex 4e66b3368..ecda426a6 100644\n--- a/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n+++ b/src/libcamera/pipeline/imx8-isi/imx8-isi.cpp\n@@ -366,7 +366,6 @@ ISICameraConfiguration::validateRaw(std::set<Stream *> &availableStreams,\n \t * Make sure the requested RAW format is supported by the\n \t * pipeline, otherwise adjust it.\n \t */\n-\tstd::vector<unsigned int> mbusCodes = data_->sensor_->mbusCodes();\n \tStreamConfiguration &rawConfig = config_[0];\n \tPixelFormat rawFormat = rawConfig.pixelFormat;\n \n", "prefixes": [ "v1" ] }