Patch Detail
Show a patch.
GET /api/patches/23152/?format=api
{ "id": 23152, "url": "https://patchwork.libcamera.org/api/patches/23152/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23152/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250407085639.16180-11-mzamazal@redhat.com>", "date": "2025-04-07T08:56:36", "name": "[v4,10/11] libcamera: simple: Require metadata only when software ISP is used", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "adf57768443f08befa8495a3913c97b599410b7f", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23152/mbox/", "series": [ { "id": 5117, "url": "https://patchwork.libcamera.org/api/series/5117/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5117", "date": "2025-04-07T08:56:26", "name": "Enable raw streams with software ISP", "version": 4, "mbox": "https://patchwork.libcamera.org/series/5117/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23152/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23152/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BCEA9C327D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 7 Apr 2025 08:57:31 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 747C268A9F;\n\tMon, 7 Apr 2025 10:57:31 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6421868A99\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 7 Apr 2025 10:57:25 +0200 (CEST)", "from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-586-a3abDm-FO9WXl-3lnIFbgg-1;\n\tMon, 07 Apr 2025 04:57:21 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id 061521956087; Mon, 7 Apr 2025 08:57:20 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.45.224.129])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 5FF5A1801A6D; Mon, 7 Apr 2025 08:57:18 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"f2fbHZ0w\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1744016244;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=fCVfrwjZK03ZhYsAj2Ty034zDPh4Z3FThXQlUTfE8zs=;\n\tb=f2fbHZ0wFubfv+ry1yvyw9wJ7bQb8WnghzmpnnvhZ5w7dl0Hy7uly6VYtI/4ywe8EkdJIl\n\toNjL1VA3mBQMJYda0l6f075H3LpkdnuVnWeNYKNLGMmAVed9yEZhNs2hKN+R4fEWFJ8BVK\n\tELzE0x5gW4IUgAdFSmNJU2hH/pvj4oQ=", "X-MC-Unique": "a3abDm-FO9WXl-3lnIFbgg-1", "X-Mimecast-MFC-AGG-ID": "a3abDm-FO9WXl-3lnIFbgg_1744016240", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tLaurent Pinchart <laurent.pinchart@ideasonboard.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH v4 10/11] libcamera: simple: Require metadata only when\n\tsoftware ISP is used", "Date": "Mon, 7 Apr 2025 10:56:36 +0200", "Message-ID": "<20250407085639.16180-11-mzamazal@redhat.com>", "In-Reply-To": "<20250407085639.16180-1-mzamazal@redhat.com>", "References": "<20250407085639.16180-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "5z0vN0EtlKQct_eu_43DFWNU_7BOMoSIFSjR9zpXh6k_1744016240", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "If software ISP is enabled then metadata is required in the simple\npipeline. But this doesn't apply if the software ISP is not actually\nused, for example when only a raw stream is produced. Then the pipeline\nwaits for metadata that never comes.\n\nThis patch fixes the problem by requiring metadata only when software\nISP is used.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/libcamera/pipeline/simple/simple.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp\nindex 2932fb45..ff41e772 100644\n--- a/src/libcamera/pipeline/simple/simple.cpp\n+++ b/src/libcamera/pipeline/simple/simple.cpp\n@@ -1652,6 +1652,7 @@ int SimplePipelineHandler::queueRequestDevice(Camera *camera, Request *request)\n \tint ret;\n \n \tstd::map<const Stream *, FrameBuffer *> buffers;\n+\tbool metadataRequired = false;\n \n \tfor (auto &[stream, buffer] : request->buffers()) {\n \t\t/*\n@@ -1661,6 +1662,7 @@ int SimplePipelineHandler::queueRequestDevice(Camera *camera, Request *request)\n \t\t */\n \t\tif (data->useConversion_) {\n \t\t\tbuffers.emplace(stream, buffer);\n+\t\t\tmetadataRequired = !!data->swIsp_;\n \t\t} else {\n \t\t\tret = data->video_->queueBuffer(buffer);\n \t\t\tif (ret < 0)\n@@ -1668,7 +1670,7 @@ int SimplePipelineHandler::queueRequestDevice(Camera *camera, Request *request)\n \t\t}\n \t}\n \n-\tdata->frameInfo_.create(request, !!data->swIsp_);\n+\tdata->frameInfo_.create(request, metadataRequired);\n \tif (data->useConversion_) {\n \t\tdata->conversionQueue_.push({ request, std::move(buffers) });\n \t\tif (data->swIsp_)\n", "prefixes": [ "v4", "10/11" ] }