Patch Detail
Show a patch.
GET /api/patches/23139/?format=api
{ "id": 23139, "url": "https://patchwork.libcamera.org/api/patches/23139/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23139/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250404161237.1298653-2-foss+libcamera@0leil.net>", "date": "2025-04-04T16:12:35", "name": "[2/2] meson: do not automatically build documentation if sphinx-build-3 is found", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": false, "hash": "82fd08937dd2661117383fb7c2a35d3a18f564cc", "submitter": { "id": 120, "url": "https://patchwork.libcamera.org/api/people/120/?format=api", "name": "Quentin Schulz", "email": "foss+libcamera@0leil.net" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23139/mbox/", "series": [ { "id": 5114, "url": "https://patchwork.libcamera.org/api/series/5114/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5114", "date": "2025-04-04T16:12:34", "name": "[1/2] meson: make the default value of \"documentation\" feature explicit", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5114/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23139/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23139/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 52459C3284\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 4 Apr 2025 16:12:59 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B5C67689AA;\n\tFri, 4 Apr 2025 18:12:57 +0200 (CEST)", "from smtp-1908.mail.infomaniak.ch (smtp-1908.mail.infomaniak.ch\n\t[185.125.25.8])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 49A296899E\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 4 Apr 2025 18:12:56 +0200 (CEST)", "from smtp-3-0000.mail.infomaniak.ch (smtp-3-0000.mail.infomaniak.ch\n\t[10.4.36.107])\n\tby smtp-3-3000.mail.infomaniak.ch (Postfix) with ESMTPS id\n\t4ZTkCr19N1zKVD; Fri, 4 Apr 2025 18:12:56 +0200 (CEST)", "from unknown by smtp-3-0000.mail.infomaniak.ch (Postfix) with\n\tESMTPA id 4ZTkCq5M7dzYLM; Fri, 4 Apr 2025 18:12:55 +0200 (CEST)" ], "From": "Quentin Schulz <foss+libcamera@0leil.net>", "To": "", "Cc": "libcamera-devel@lists.libcamera.org,\n\tQuentin Schulz <quentin.schulz@cherry.de>", "Subject": "[PATCH 2/2] meson: do not automatically build documentation if\n\tsphinx-build-3 is found", "Date": "Fri, 4 Apr 2025 18:12:35 +0200", "Message-ID": "<20250404161237.1298653-2-foss+libcamera@0leil.net>", "X-Mailer": "git-send-email 2.49.0", "In-Reply-To": "<20250404161237.1298653-1-foss+libcamera@0leil.net>", "References": "<20250404161237.1298653-1-foss+libcamera@0leil.net>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Infomaniak-Routing": "alpha", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "From: Quentin Schulz <quentin.schulz@cherry.de>\n\nCommit aba567338b25 (\"Documentation: Move all dependencies into\nfeatures\") did an incomplete migration of the documentation boolean\noption into a documentation feature.\n\nIf sphinx-build-3 binary is found on the host system, the documentation\nis built, regardless of the value of the feature option.\n\nThis makes sure that sphinx-build-3 presence is only checked if the\ndocumentation feature is not disabled (which is the default, as it's\n\"auto\" by default).\n\nThis is essential for reproducibility for build systems where\nsphinx-build-3 may or may not be present when libcamera is built, and\nalso to declutter the generated package if documentation isn't desired.\n\nFixes: aba567338b25 (\"Documentation: Move all dependencies into features\")\nSigned-off-by: Quentin Schulz <quentin.schulz@cherry.de>\n---\n Documentation/meson.build | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/Documentation/meson.build b/Documentation/meson.build\nindex 6158320e..c59849f6 100644\n--- a/Documentation/meson.build\n+++ b/Documentation/meson.build\n@@ -116,7 +116,7 @@ endif\n # Sphinx\n #\n \n-sphinx = find_program('sphinx-build-3', required : false)\n+sphinx = find_program('sphinx-build-3', required : get_option('documentation'))\n if not sphinx.found()\n sphinx = find_program('sphinx-build', required : get_option('documentation'))\n endif\n", "prefixes": [ "2/2" ] }