Patch Detail
Show a patch.
GET /api/patches/23126/?format=api
{ "id": 23126, "url": "https://patchwork.libcamera.org/api/patches/23126/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23126/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250403154925.382973-11-stefan.klug@ideasonboard.com>", "date": "2025-04-03T15:49:15", "name": "[v3,10/16] ipa: rkisp1: algorithms: awb: Fix wrong colour temperature reporting", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "e916e08f387bf76a972c88d2bdae28923bc6b7d8", "submitter": { "id": 184, "url": "https://patchwork.libcamera.org/api/people/184/?format=api", "name": "Stefan Klug", "email": "stefan.klug@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23126/mbox/", "series": [ { "id": 5111, "url": "https://patchwork.libcamera.org/api/series/5111/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5111", "date": "2025-04-03T15:49:05", "name": "Some rkisp1 awb improvements", "version": 3, "mbox": "https://patchwork.libcamera.org/series/5111/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23126/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23126/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 33A7FC327D\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 3 Apr 2025 15:50:07 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E8A8668AA4;\n\tThu, 3 Apr 2025 17:50:06 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5245768A99\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 3 Apr 2025 17:50:05 +0200 (CEST)", "from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:6d9d:9854:3fc1:4bb2])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A895B11E9;\n\tThu, 3 Apr 2025 17:48:11 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mPaj8Wmy\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743695291;\n\tbh=m6PCB6BkuTeM5Q0Jw/DmKkQLqGea+CVDblqFGnecTOo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=mPaj8WmyQF7iZy/7Fr7Gyca8I6kaY6rj8L+F66p5h8UhO6imvqgB3TeqO/5Zl/57c\n\tPDrPKCX7ru/856IRJ0xz2/vkAVExu0EjJI2WfvCQK8R/YtKbrwrU7gRHjyR76Wos4b\n\tJUs2JlheLPSA5gO8RUGY6ZPS139kkKnmcAi0W9UA=", "From": "Stefan Klug <stefan.klug@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Stefan Klug <stefan.klug@ideasonboard.com>", "Subject": "[PATCH v3 10/16] ipa: rkisp1: algorithms: awb: Fix wrong colour\n\ttemperature reporting", "Date": "Thu, 3 Apr 2025 17:49:15 +0200", "Message-ID": "<20250403154925.382973-11-stefan.klug@ideasonboard.com>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20250403154925.382973-1-stefan.klug@ideasonboard.com>", "References": "<20250403154925.382973-1-stefan.klug@ideasonboard.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "In commit b60bd37b1a49 (\"ipa: rkisp1: Move calculation of RGB means into\nown function\") the output of the current measured colour temperature as\nmetadata was incorrectly added. Remove it.\n\nFixes: b60bd37b1a49 (\"ipa: rkisp1: Move calculation of RGB means into own function\")\nSigned-off-by: Stefan Klug <stefan.klug@ideasonboard.com>\n\n---\n\nChanges in v3:\n- Added this patch\n---\n src/ipa/rkisp1/algorithms/awb.cpp | 3 ---\n 1 file changed, 3 deletions(-)", "diff": "diff --git a/src/ipa/rkisp1/algorithms/awb.cpp b/src/ipa/rkisp1/algorithms/awb.cpp\nindex a9759e53f593..79c4c658406d 100644\n--- a/src/ipa/rkisp1/algorithms/awb.cpp\n+++ b/src/ipa/rkisp1/algorithms/awb.cpp\n@@ -311,9 +311,6 @@ void Awb::process(IPAContext &context,\n \n \tactiveState.awb.temperatureK = awbResult.colourTemperature;\n \n-\t/* Metadata shall contain the up to date measurement */\n-\tmetadata.set(controls::ColourTemperature, activeState.awb.temperatureK);\n-\n \t/*\n \t * Clamp the gain values to the hardware, which expresses gains as Q2.8\n \t * unsigned integer values. Set the minimum just above zero to avoid\n", "prefixes": [ "v3", "10/16" ] }