Patch Detail
Show a patch.
GET /api/patches/23115/?format=api
{ "id": 23115, "url": "https://patchwork.libcamera.org/api/patches/23115/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23115/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250403125355.76062-1-mzamazal@redhat.com>", "date": "2025-04-03T12:53:55", "name": "libcamera: software_isp: Add a clarification comment to AWB", "commit_ref": "21088e605c08c3615ed54f234e0333c6d1c8c0e5", "pull_url": null, "state": "accepted", "archived": false, "hash": "9b41d4d3d62f718c8ccd9413a2a3ad455c6c63bc", "submitter": { "id": 177, "url": "https://patchwork.libcamera.org/api/people/177/?format=api", "name": "Milan Zamazal", "email": "mzamazal@redhat.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23115/mbox/", "series": [ { "id": 5110, "url": "https://patchwork.libcamera.org/api/series/5110/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5110", "date": "2025-04-03T12:53:55", "name": "libcamera: software_isp: Add a clarification comment to AWB", "version": 1, "mbox": "https://patchwork.libcamera.org/series/5110/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23115/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23115/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 95E9DC3213\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 3 Apr 2025 12:54:18 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A886B68994;\n\tThu, 3 Apr 2025 14:54:17 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4A6E268980\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 3 Apr 2025 14:54:15 +0200 (CEST)", "from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com\n\t(ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97])\n\tby relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3,\n\tcipher=TLS_AES_256_GCM_SHA384) id us-mta-107-F_CyfFOhNHmgV9KARm9JhQ-1;\n\tThu, 03 Apr 2025 08:54:10 -0400", "from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t(mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com\n\t[10.30.177.111])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTPS id D41471800257; Thu, 3 Apr 2025 12:54:09 +0000 (UTC)", "from mzamazal-thinkpadp1gen7.tpbc.com (unknown [10.43.17.4])\n\tby mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix)\n\twith ESMTP id 02FAE180094A; Thu, 3 Apr 2025 12:54:07 +0000 (UTC)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"c1MFNVdg\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1743684854;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding;\n\tbh=0Z2BBfN/lVVsS501oIZ+SXhqQoZvduk+q6+/GHGxO4k=;\n\tb=c1MFNVdgEeUq/0l5Roz40D2sj0yP3uih2SqJqYlLjEER7m63aOZEv6gNDfvLhk41+9IfQo\n\t5q7O8BMD0ZkAV3qJWJ+honxaYZAYprAd5+g8fVCW/vVsnQ5l2Tti/82fy/rGyW5Kaj/+xW\n\tYe/N1A0DuQODJvxwIsIqT5EbdnvoaUs=", "X-MC-Unique": "F_CyfFOhNHmgV9KARm9JhQ-1", "X-Mimecast-MFC-AGG-ID": "F_CyfFOhNHmgV9KARm9JhQ_1743684850", "From": "Milan Zamazal <mzamazal@redhat.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Milan Zamazal <mzamazal@redhat.com>,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>", "Subject": "[PATCH] libcamera: software_isp: Add a clarification comment to AWB", "Date": "Thu, 3 Apr 2025 14:53:55 +0200", "Message-ID": "<20250403125355.76062-1-mzamazal@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.4.1 on 10.30.177.111", "X-Mimecast-Spam-Score": "0", "X-Mimecast-MFC-PROC-ID": "PyxzNKeNYIWxDLmYyq8vh-jgHcftnZNzccw0K1G1Iv4_1743684850", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "content-type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The computed AWB gains are applied when constructing LUT tables rather\nthan in awb.cpp itself. This can look confusing when reading awb.cpp,\nlet's add a clarifying comment.\n\nSigned-off-by: Milan Zamazal <mzamazal@redhat.com>\n---\n src/ipa/simple/algorithms/awb.cpp | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/src/ipa/simple/algorithms/awb.cpp b/src/ipa/simple/algorithms/awb.cpp\nindex 55719059..cf567e89 100644\n--- a/src/ipa/simple/algorithms/awb.cpp\n+++ b/src/ipa/simple/algorithms/awb.cpp\n@@ -40,6 +40,7 @@ void Awb::prepare(IPAContext &context,\n \t\t [[maybe_unused]] DebayerParams *params)\n {\n \tauto &gains = context.activeState.awb.gains;\n+\t/* Just report, the gains are applied in LUT algorithm. */\n \tframeContext.gains.red = gains.r();\n \tframeContext.gains.blue = gains.b();\n }\n", "prefixes": [] }