Patch Detail
Show a patch.
GET /api/patches/23108/?format=api
{ "id": 23108, "url": "https://patchwork.libcamera.org/api/patches/23108/?format=api", "web_url": "https://patchwork.libcamera.org/patch/23108/", "project": { "id": 1, "url": "https://patchwork.libcamera.org/api/projects/1/?format=api", "name": "libcamera", "link_name": "libcamera", "list_id": "libcamera_core", "list_email": "libcamera-devel@lists.libcamera.org", "web_url": "", "scm_url": "", "webscm_url": "" }, "msgid": "<20250402151158.968707-1-barnabas.pocze@ideasonboard.com>", "date": "2025-04-02T15:11:58", "name": "[v2] libcamera: pipeline: uvcvideo: Report new AeEnable control as available", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": false, "hash": "115c33f0bfedd041275260c9e2219ef4e0602ce9", "submitter": { "id": 216, "url": "https://patchwork.libcamera.org/api/people/216/?format=api", "name": "Barnabás Pőcze", "email": "barnabas.pocze@ideasonboard.com" }, "delegate": null, "mbox": "https://patchwork.libcamera.org/patch/23108/mbox/", "series": [ { "id": 5108, "url": "https://patchwork.libcamera.org/api/series/5108/?format=api", "web_url": "https://patchwork.libcamera.org/project/libcamera/list/?series=5108", "date": "2025-04-02T15:11:58", "name": "[v2] libcamera: pipeline: uvcvideo: Report new AeEnable control as available", "version": 2, "mbox": "https://patchwork.libcamera.org/series/5108/mbox/" } ], "comments": "https://patchwork.libcamera.org/api/patches/23108/comments/", "check": "pending", "checks": "https://patchwork.libcamera.org/api/patches/23108/checks/", "tags": {}, "headers": { "Return-Path": "<libcamera-devel-bounces@lists.libcamera.org>", "X-Original-To": "parsemail@patchwork.libcamera.org", "Delivered-To": "parsemail@patchwork.libcamera.org", "Received": [ "from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BBB94C323E\n\tfor <parsemail@patchwork.libcamera.org>;\n\tWed, 2 Apr 2025 15:12:09 +0000 (UTC)", "from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7A0BB6897E;\n\tWed, 2 Apr 2025 17:12:08 +0200 (CEST)", "from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 66AD368979\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tWed, 2 Apr 2025 17:12:06 +0200 (CEST)", "from pb-laptop.local (185.221.143.221.nat.pool.zt.hu\n\t[185.221.143.221])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4E533415;\n\tWed, 2 Apr 2025 17:10:13 +0200 (CEST)" ], "Authentication-Results": "lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ZLHvMShM\"; dkim-atps=neutral", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1743606613;\n\tbh=mbx8WffDmmCBbsC61lI/P9WmgQsIeOpg0hL0daO3/Oc=;\n\th=From:To:Cc:Subject:Date:From;\n\tb=ZLHvMShMJutOm7Te0GaalSlZfaBG/6esZMJ/xh+9/lBfI7z8VL1MD0JtW6y7LUSAz\n\tYIMJYCWPjwhh9dksmK1SeO5g7B63nxgBpi2zAxMOnpeAJykatsuzpi27ccOwB6aONG\n\tR2AIh3OH4ptMo9F8HapMwSlX7tJD0quFtedOTuEs=", "From": "=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= <barnabas.pocze@ideasonboard.com>", "To": "libcamera-devel@lists.libcamera.org", "Cc": "Jacopo Mondi <jacopo.mondi@ideasonboard.com>", "Subject": "[PATCH v2] libcamera: pipeline: uvcvideo: Report new AeEnable\n\tcontrol as available", "Date": "Wed, 2 Apr 2025 17:11:58 +0200", "Message-ID": "<20250402151158.968707-1-barnabas.pocze@ideasonboard.com>", "X-Mailer": "git-send-email 2.49.0", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "libcamera-devel@lists.libcamera.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "<libcamera-devel.lists.libcamera.org>", "List-Unsubscribe": "<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>", "List-Archive": "<https://lists.libcamera.org/pipermail/libcamera-devel/>", "List-Post": "<mailto:libcamera-devel@lists.libcamera.org>", "List-Help": "<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>", "List-Subscribe": "<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>", "Errors-To": "libcamera-devel-bounces@lists.libcamera.org", "Sender": "\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>" }, "content": "The `AeEnable` control is handled by the `Camera` class directly, but it\nstill has to be added because `ControlInfoMap`s are not easily modifiable.\n\nSee 338ba00e7abfe8 (\"ipa: rkisp1: agc: Report new AeEnable control as available\")\nfor more details and a similar change in rkisp1.\n\nSigned-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n---\nchanges in v2:\n * only report control if it can actually do something\n\nv1: https://patchwork.libcamera.org/patch/23106/\n---\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 5 +++++\n 1 file changed, 5 insertions(+)\n\n--\n2.49.0", "diff": "diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\nindex 5adc89fdb..a7e0fcfbc 100644\n--- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n@@ -590,6 +590,11 @@ int UVCCameraData::init(MediaDevice *media)\n \t\taddControl(cid, info, &ctrls);\n \t}\n\n+\tif (autoExposureMode_ && manualExposureMode_) {\n+\t\t/* \\todo Move this to the Camera class */\n+\t\tctrls[&controls::AeEnable] = ControlInfo(false, true, true);\n+\t}\n+\n \tcontrolInfo_ = ControlInfoMap(std::move(ctrls), controls::controls);\n\n \t/*\n", "prefixes": [ "v2" ] }